[PATCH] soundwire: intel_ace2x: use legacy formula for intel_alh_id

[PATCH] soundwire: intel_ace2x: use legacy formula for intel_alh_id

[Bard Liao]

From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

Starting with Lunar Lake, the notion of ALH is mostly irrelevant,
since the HDaudio DMAs are used. However the firmware still relies on
an 'ALH gateway' with a 'node_id' based on the same formula.

This patch in isolation has no functional impact, it's only when the
ASoC parts use it that we will see a changed behavior.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
---
 drivers/soundwire/intel_ace2x.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/soundwire/intel_ace2x.c b/drivers/soundwire/intel_ace2x.c
index 4910cab22273..75e629c938dc 100644
--- a/drivers/soundwire/intel_ace2x.c
+++ b/drivers/soundwire/intel_ace2x.c
@@ -302,6 +302,11 @@ static int intel_hw_params(struct snd_pcm_substream *substream,
 		goto error;
 	}
 
+	/* use same definitions for alh_id as previous generations */
+	pdi->intel_alh_id = (sdw->instance * 16) + pdi->num + 3;
+	if (pdi->num >= 2)
+		pdi->intel_alh_id += 2;
+
 	/* the SHIM will be configured in the callback functions */
 
 	sdw_cdns_config_stream(cdns, ch, dir, pdi);
-- 
2.34.1

Re: [PATCH] soundwire: intel_ace2x: use legacy formula for intel_alh_id

[Vinod Koul]

On Mon, 08 Apr 2024 06:22:06 +0000, Bard Liao wrote:
> Starting with Lunar Lake, the notion of ALH is mostly irrelevant,
> since the HDaudio DMAs are used. However the firmware still relies on
> an 'ALH gateway' with a 'node_id' based on the same formula.
> 
> This patch in isolation has no functional impact, it's only when the
> ASoC parts use it that we will see a changed behavior.
> 
> [...]

Applied, thanks!

[1/1] soundwire: intel_ace2x: use legacy formula for intel_alh_id
      commit: b18c25afabf80972b32a3918f6d7f16fbd54b18f

Best regards,
-- 
~Vinod