* [PATCH net-next] net: phy: mediatek-ge: do not disable EEE advertisement
@ 2024-04-13 21:08 Arınç ÜNAL via B4 Relay
2024-04-17 9:50 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Arınç ÜNAL via B4 Relay @ 2024-04-13 21:08 UTC (permalink / raw)
To: Daniel Golle, Qingfang Deng, SkyLake Huang, Andrew Lunn,
Heiner Kallweit, Russell King, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Matthias Brugger,
AngeloGioacchino Del Regno
Cc: mithat.guner, erkin.bozoglu, netdev, linux-kernel,
linux-arm-kernel, linux-mediatek, Arınç ÜNAL
From: Arınç ÜNAL <arinc.unal@arinc9.com>
The mediatek-ge PHY driver already disables EEE advertisement on the switch
PHYs but my testing [1] shows that it is somehow enabled afterwards.
Disabling EEE advertisement before the PHY driver initialises keeps it off.
Therefore, remove disabling EEE advertisement here as it's useless.
Link: https://lore.kernel.org/netdev/d286ea27-e911-4dcb-9037-b75f22b437b8@arinc9.com/ [1]
Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
---
drivers/net/phy/mediatek-ge.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/phy/mediatek-ge.c b/drivers/net/phy/mediatek-ge.c
index a493ae01b267..54ea64a37ab3 100644
--- a/drivers/net/phy/mediatek-ge.c
+++ b/drivers/net/phy/mediatek-ge.c
@@ -23,9 +23,6 @@ static int mtk_gephy_write_page(struct phy_device *phydev, int page)
static void mtk_gephy_config_init(struct phy_device *phydev)
{
- /* Disable EEE */
- phy_write_mmd(phydev, MDIO_MMD_AN, MDIO_AN_EEE_ADV, 0);
-
/* Enable HW auto downshift */
phy_modify_paged(phydev, MTK_PHY_PAGE_EXTENDED, 0x14, 0, BIT(4));
---
base-commit: 32affa5578f0e6b9abef3623d3976395afbd265c
change-id: 20240321-for-netnext-mediatek-ge-do-not-disable-eee-adv-b67dfccf9811
Best regards,
--
Arınç ÜNAL <arinc.unal@arinc9.com>
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH net-next] net: phy: mediatek-ge: do not disable EEE advertisement
2024-04-13 21:08 [PATCH net-next] net: phy: mediatek-ge: do not disable EEE advertisement Arınç ÜNAL via B4 Relay
@ 2024-04-17 9:50 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-04-17 9:50 UTC (permalink / raw)
To: =?utf-8?b?QXLEsW7DpyDDnE5BTCB2aWEgQjQgUmVsYXkgPGRldm51bGwrYXJpbmMudW5hbC5h?=,
=?utf-8?b?cmluYzkuY29tQGtlcm5lbC5vcmc+?=
Cc: daniel, dqfext, SkyLake.Huang, andrew, hkallweit1, linux, davem,
edumazet, kuba, pabeni, matthias.bgg, angelogioacchino.delregno,
mithat.guner, erkin.bozoglu, netdev, linux-kernel,
linux-arm-kernel, linux-mediatek, arinc.unal
Hello:
This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:
On Sun, 14 Apr 2024 00:08:13 +0300 you wrote:
> From: Arınç ÜNAL <arinc.unal@arinc9.com>
>
> The mediatek-ge PHY driver already disables EEE advertisement on the switch
> PHYs but my testing [1] shows that it is somehow enabled afterwards.
> Disabling EEE advertisement before the PHY driver initialises keeps it off.
> Therefore, remove disabling EEE advertisement here as it's useless.
>
> [...]
Here is the summary with links:
- [net-next] net: phy: mediatek-ge: do not disable EEE advertisement
https://git.kernel.org/netdev/net-next/c/af3b4b0e59de
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-17 9:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-13 21:08 [PATCH net-next] net: phy: mediatek-ge: do not disable EEE advertisement Arınç ÜNAL via B4 Relay
2024-04-17 9:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®