From: "tip-bot2 for Dawei Li" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Dawei Li <dawei.li@shingroup.cn>,
Thomas Gleixner <tglx@linutronix.de>,
Anup Patel <anup@brainfault.org>,
x86@kernel.org, linux-kernel@vger.kernel.org, maz@kernel.org
Subject: [tip: irq/core] irqchip/sifive-plic: Avoid explicit cpumask allocation on stack
Date: Wed, 24 Apr 2024 20:04:06 -0000 [thread overview]
Message-ID: <171398904640.10875.11548457486987058733.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20240416085454.3547175-7-dawei.li@shingroup.cn>
The following commit has been merged into the irq/core branch of tip:
Commit-ID: a7fb69ffd7ce438a259b2f9fbcebc62f5caf2d4f
Gitweb: https://git.kernel.org/tip/a7fb69ffd7ce438a259b2f9fbcebc62f5caf2d4f
Author: Dawei Li <dawei.li@shingroup.cn>
AuthorDate: Tue, 16 Apr 2024 16:54:53 +08:00
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Wed, 24 Apr 2024 21:23:49 +02:00
irqchip/sifive-plic: Avoid explicit cpumask allocation on stack
In general it's preferable to avoid placing cpumasks on the stack, as
for large values of NR_CPUS these can consume significant amounts of
stack space and make stack overflows more likely.
Use cpumask_first_and_and() to avoid the need for a temporary cpumask on
the stack.
Signed-off-by: Dawei Li <dawei.li@shingroup.cn>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Anup Patel <anup@brainfault.org>
Link: https://lore.kernel.org/r/20240416085454.3547175-7-dawei.li@shingroup.cn
---
drivers/irqchip/irq-sifive-plic.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/irqchip/irq-sifive-plic.c b/drivers/irqchip/irq-sifive-plic.c
index f3d4cb9..8fb183c 100644
--- a/drivers/irqchip/irq-sifive-plic.c
+++ b/drivers/irqchip/irq-sifive-plic.c
@@ -164,15 +164,12 @@ static int plic_set_affinity(struct irq_data *d,
const struct cpumask *mask_val, bool force)
{
unsigned int cpu;
- struct cpumask amask;
struct plic_priv *priv = irq_data_get_irq_chip_data(d);
- cpumask_and(&amask, &priv->lmask, mask_val);
-
if (force)
- cpu = cpumask_first(&amask);
+ cpu = cpumask_first_and(&priv->lmask, mask_val);
else
- cpu = cpumask_any_and(&amask, cpu_online_mask);
+ cpu = cpumask_first_and_and(&priv->lmask, mask_val, cpu_online_mask);
if (cpu >= nr_cpu_ids)
return -EINVAL;
next prev parent reply other threads:[~2024-04-24 20:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 8:54 [PATCH v2 0/7] Remove on-stack cpumask var for irq subsystem Dawei Li
2024-04-16 8:54 ` [PATCH v2 1/7] cpumask: introduce cpumask_first_and_and() Dawei Li
2024-04-16 17:45 ` Yury Norov
2024-04-16 17:49 ` Yury Norov
2024-04-17 1:35 ` Dawei Li
2024-04-24 20:04 ` [tip: irq/core] cpumask: Introduce cpumask_first_and_and() tip-bot2 for Dawei Li
2024-04-16 8:54 ` [PATCH v2 2/7] irqchip/irq-bcm6345-l1: Avoid explicit cpumask allocation on stack Dawei Li
2024-04-24 20:04 ` [tip: irq/core] " tip-bot2 for Dawei Li
2024-04-16 8:54 ` [PATCH v2 3/7] irqchip/gic-v3-its: " Dawei Li
2024-04-17 10:56 ` Marc Zyngier
2024-04-24 20:04 ` [tip: irq/core] " tip-bot2 for Dawei Li
2024-04-16 8:54 ` [PATCH v2 4/7] irqchip/loongson-eiointc: " Dawei Li
2024-04-16 18:01 ` Yury Norov
2024-04-24 20:04 ` [tip: irq/core] " tip-bot2 for Dawei Li
2024-04-16 8:54 ` [PATCH v2 5/7] irqchip/riscv-aplic-direct: " Dawei Li
2024-04-17 11:22 ` Anup Patel
2024-04-24 20:04 ` [tip: irq/core] " tip-bot2 for Dawei Li
2024-04-16 8:54 ` [PATCH v2 6/7] irqchip/sifive-plic: " Dawei Li
2024-04-17 11:21 ` Anup Patel
2024-04-24 20:04 ` tip-bot2 for Dawei Li [this message]
2024-04-16 8:54 ` [PATCH v2 7/7] cpuidle: " Dawei Li
2024-04-24 20:04 ` [tip: irq/core] " tip-bot2 for Dawei Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171398904640.10875.11548457486987058733.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=anup@brainfault.org \
--cc=dawei.li@shingroup.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®