From: Dawei Li <dawei.li@shingroup.cn>
To: tglx@linutronix.de, yury.norov@gmail.com, rafael@kernel.org
Cc: akpm@linux-foundation.org, maz@kernel.org,
florian.fainelli@broadcom.com, chenhuacai@kernel.org,
jiaxun.yang@flygoat.com, anup@brainfault.org, palmer@dabbelt.com,
samuel.holland@sifive.com, linux@rasmusvillemoes.dk,
daniel.lezcano@linaro.org, linux-kernel@vger.kernel.org,
Dawei Li <dawei.li@shingroup.cn>
Subject: [PATCH v2 3/7] irqchip/gic-v3-its: Avoid explicit cpumask allocation on stack
Date: Tue, 16 Apr 2024 16:54:50 +0800 [thread overview]
Message-ID: <20240416085454.3547175-4-dawei.li@shingroup.cn> (raw)
In-Reply-To: <20240416085454.3547175-1-dawei.li@shingroup.cn>
In general it's preferable to avoid placing cpumasks on the stack, as
for large values of NR_CPUS these can consume significant amounts of
stack space and make stack overflows more likely.
Remove cpumask var on stack and use cpumask_any_and() to address it.
Signed-off-by: Dawei Li <dawei.li@shingroup.cn>
---
drivers/irqchip/irq-gic-v3-its.c | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
index fca888b36680..20f954211c61 100644
--- a/drivers/irqchip/irq-gic-v3-its.c
+++ b/drivers/irqchip/irq-gic-v3-its.c
@@ -3826,9 +3826,9 @@ static int its_vpe_set_affinity(struct irq_data *d,
bool force)
{
struct its_vpe *vpe = irq_data_get_irq_chip_data(d);
- struct cpumask common, *table_mask;
+ unsigned int from, cpu = nr_cpu_ids;
+ struct cpumask *table_mask;
unsigned long flags;
- int from, cpu;
/*
* Changing affinity is mega expensive, so let's be as lazy as
@@ -3850,10 +3850,15 @@ static int its_vpe_set_affinity(struct irq_data *d,
* If we are offered another CPU in the same GICv4.1 ITS
* affinity, pick this one. Otherwise, any CPU will do.
*/
- if (table_mask && cpumask_and(&common, mask_val, table_mask))
- cpu = cpumask_test_cpu(from, &common) ? from : cpumask_first(&common);
- else
+ if (table_mask)
+ cpu = cpumask_any_and(mask_val, table_mask);
+ if (cpu < nr_cpu_ids) {
+ if (cpumask_test_cpu(from, mask_val) &&
+ cpumask_test_cpu(from, table_mask))
+ cpu = from;
+ } else {
cpu = cpumask_first(mask_val);
+ }
if (from == cpu)
goto out;
--
2.27.0
next prev parent reply other threads:[~2024-04-16 8:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 8:54 [PATCH v2 0/7] Remove on-stack cpumask var for irq subsystem Dawei Li
2024-04-16 8:54 ` [PATCH v2 1/7] cpumask: introduce cpumask_first_and_and() Dawei Li
2024-04-16 17:45 ` Yury Norov
2024-04-16 17:49 ` Yury Norov
2024-04-17 1:35 ` Dawei Li
2024-04-24 20:04 ` [tip: irq/core] cpumask: Introduce cpumask_first_and_and() tip-bot2 for Dawei Li
2024-04-16 8:54 ` [PATCH v2 2/7] irqchip/irq-bcm6345-l1: Avoid explicit cpumask allocation on stack Dawei Li
2024-04-24 20:04 ` [tip: irq/core] " tip-bot2 for Dawei Li
2024-04-16 8:54 ` Dawei Li [this message]
2024-04-17 10:56 ` [PATCH v2 3/7] irqchip/gic-v3-its: " Marc Zyngier
2024-04-24 20:04 ` [tip: irq/core] " tip-bot2 for Dawei Li
2024-04-16 8:54 ` [PATCH v2 4/7] irqchip/loongson-eiointc: " Dawei Li
2024-04-16 18:01 ` Yury Norov
2024-04-24 20:04 ` [tip: irq/core] " tip-bot2 for Dawei Li
2024-04-16 8:54 ` [PATCH v2 5/7] irqchip/riscv-aplic-direct: " Dawei Li
2024-04-17 11:22 ` Anup Patel
2024-04-24 20:04 ` [tip: irq/core] " tip-bot2 for Dawei Li
2024-04-16 8:54 ` [PATCH v2 6/7] irqchip/sifive-plic: " Dawei Li
2024-04-17 11:21 ` Anup Patel
2024-04-24 20:04 ` [tip: irq/core] " tip-bot2 for Dawei Li
2024-04-16 8:54 ` [PATCH v2 7/7] cpuidle: " Dawei Li
2024-04-24 20:04 ` [tip: irq/core] " tip-bot2 for Dawei Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240416085454.3547175-4-dawei.li@shingroup.cn \
--to=dawei.li@shingroup.cn \
--cc=akpm@linux-foundation.org \
--cc=anup@brainfault.org \
--cc=chenhuacai@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=florian.fainelli@broadcom.com \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=maz@kernel.org \
--cc=palmer@dabbelt.com \
--cc=rafael@kernel.org \
--cc=samuel.holland@sifive.com \
--cc=tglx@linutronix.de \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®