* [PATCH] dt-bindings: sound: tlv320adc3xxx: Fix incorrect GPIO description
@ 2024-05-28 15:40 Ricard Wanderlof
2024-06-03 15:19 ` Rob Herring (Arm)
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Ricard Wanderlof @ 2024-05-28 15:40 UTC (permalink / raw)
To: Shenghao Ding, Kevin Lu, Baojun Xu, Liam Girdwood, Mark Brown,
Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: alsa-devel, linux-sound, devicetree, linux-kernel, kernel,
Ricard Wanderlof
Fix the description for the ti,dmdin-gpio1 and ti,dmclk-gpio2
properties to correctly describe that when configured as general
purpose outputs (ADC3XXX_GPIO_GPO), the pins are available via
the GPIO framework.
Signed-off-by: Ricard Wanderlof <ricard.wanderlof@axis.com>
---
Documentation/devicetree/bindings/sound/ti,tlv320adc3xxx.yaml | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/sound/ti,tlv320adc3xxx.yaml b/Documentation/devicetree/bindings/sound/ti,tlv320adc3xxx.yaml
index ede14ca2c07a..8ac741f4cd56 100644
--- a/Documentation/devicetree/bindings/sound/ti,tlv320adc3xxx.yaml
+++ b/Documentation/devicetree/bindings/sound/ti,tlv320adc3xxx.yaml
@@ -58,8 +58,8 @@ properties:
description: |
Configuration for DMDIN/GPIO1 pin.
- When ADC3XXX_GPIO_GPO is configured, this causes corresponding the
- ALSA control "GPIOx Output" to appear, as a switch control.
+ When ADC3XXX_GPIO_GPO is selected, the pin may be controlled via the
+ GPIO framework, as pin number 0 on the device.
ti,dmclk-gpio2:
$ref: /schemas/types.yaml#/definitions/uint32
@@ -76,8 +76,8 @@ properties:
description: |
Configuration for DMCLK/GPIO2 pin.
- When ADC3XXX_GPIO_GPO is configured, this causes corresponding the
- ALSA control "GPIOx Output" to appear, as a switch control.
+ When ADC3XXX_GPIO_GPO is selected, the pin may be controlled via the
+ GPIO framework, as pin number 1 on the device.
Note that there is currently no support for reading the GPIO pins as
inputs.
---
base-commit: 47d09270d7776e46858a161f94b735640b2fb056
change-id: 20240528-tlv320adc3xxx-dt-gpio-fix-a3384e435148
Best regards,
--
--
Ricard Wolf Wanderlof ricardw(at)axis.com
Axis Communications AB, Lund, Sweden www.axis.com
Phone +46 46 272 2016 Fax +46 46 13 61 30
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: sound: tlv320adc3xxx: Fix incorrect GPIO description
2024-05-28 15:40 [PATCH] dt-bindings: sound: tlv320adc3xxx: Fix incorrect GPIO description Ricard Wanderlof
@ 2024-06-03 15:19 ` Rob Herring (Arm)
2024-06-03 15:22 ` Mark Brown
2024-06-05 21:38 ` Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring (Arm) @ 2024-06-03 15:19 UTC (permalink / raw)
To: Ricard Wanderlof
Cc: kernel, Kevin Lu, Krzysztof Kozlowski, Shenghao Ding, Baojun Xu,
alsa-devel, devicetree, linux-sound, linux-kernel, Liam Girdwood,
Mark Brown, Conor Dooley
On Tue, 28 May 2024 17:40:04 +0200, Ricard Wanderlof wrote:
> Fix the description for the ti,dmdin-gpio1 and ti,dmclk-gpio2
> properties to correctly describe that when configured as general
> purpose outputs (ADC3XXX_GPIO_GPO), the pins are available via
> the GPIO framework.
>
> Signed-off-by: Ricard Wanderlof <ricard.wanderlof@axis.com>
> ---
> Documentation/devicetree/bindings/sound/ti,tlv320adc3xxx.yaml | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: sound: tlv320adc3xxx: Fix incorrect GPIO description
2024-05-28 15:40 [PATCH] dt-bindings: sound: tlv320adc3xxx: Fix incorrect GPIO description Ricard Wanderlof
2024-06-03 15:19 ` Rob Herring (Arm)
@ 2024-06-03 15:22 ` Mark Brown
2024-06-05 21:38 ` Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2024-06-03 15:22 UTC (permalink / raw)
To: Ricard Wanderlof
Cc: Shenghao Ding, Kevin Lu, Baojun Xu, Liam Girdwood, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, alsa-devel, linux-sound,
devicetree, linux-kernel, kernel
[-- Attachment #1: Type: text/plain, Size: 615 bytes --]
On Tue, May 28, 2024 at 05:40:04PM +0200, Ricard Wanderlof wrote:
> Fix the description for the ti,dmdin-gpio1 and ti,dmclk-gpio2
> properties to correctly describe that when configured as general
> purpose outputs (ADC3XXX_GPIO_GPO), the pins are available via
> the GPIO framework.
Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: sound: tlv320adc3xxx: Fix incorrect GPIO description
2024-05-28 15:40 [PATCH] dt-bindings: sound: tlv320adc3xxx: Fix incorrect GPIO description Ricard Wanderlof
2024-06-03 15:19 ` Rob Herring (Arm)
2024-06-03 15:22 ` Mark Brown
@ 2024-06-05 21:38 ` Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2024-06-05 21:38 UTC (permalink / raw)
To: Shenghao Ding, Kevin Lu, Baojun Xu, Liam Girdwood, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Ricard Wanderlof
Cc: alsa-devel, linux-sound, devicetree, linux-kernel, kernel
On Tue, 28 May 2024 17:40:04 +0200, Ricard Wanderlof wrote:
> Fix the description for the ti,dmdin-gpio1 and ti,dmclk-gpio2
> properties to correctly describe that when configured as general
> purpose outputs (ADC3XXX_GPIO_GPO), the pins are available via
> the GPIO framework.
>
>
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] dt-bindings: sound: tlv320adc3xxx: Fix incorrect GPIO description
commit: 39d762edd1f353c4446dbce83a18da4e491cc48e
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-06-05 21:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-28 15:40 [PATCH] dt-bindings: sound: tlv320adc3xxx: Fix incorrect GPIO description Ricard Wanderlof
2024-06-03 15:19 ` Rob Herring (Arm)
2024-06-03 15:22 ` Mark Brown
2024-06-05 21:38 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®