* [PATCH RFT 2/4] arm64: dts: qcom: sm6375-pdx225: correct touchscreen interrupt flags
2024-06-05 16:00 [PATCH RFT 1/4] arm64: dts: qcom: sm6350-pdx213: correct touchscreen interrupt flags Krzysztof Kozlowski
@ 2024-06-05 16:00 ` Krzysztof Kozlowski
2024-06-06 10:18 ` Konrad Dybcio
2024-06-05 16:00 ` [PATCH RFT 3/4] arm64: dts: qcom: sm8250-sony-xperia: " Krzysztof Kozlowski
` (3 subsequent siblings)
4 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2024-06-05 16:00 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Interrupt flags 0x2008 looks like some downstream copy-paste, because
generic GPIOLIB code, used by Qualcomm pin controller drivers, ignores
flags outside of IRQ_TYPE_SENSE_MASK. Probably the intention was to
pass just 0x8, so IRQ_TYPE_LEVEL_LOW.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts b/arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts
index cca2c2eb88ad..e04a3b8f81c5 100644
--- a/arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts
+++ b/arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts
@@ -142,7 +142,7 @@ touchscreen@48 {
compatible = "samsung,s6sy761";
reg = <0x48>;
interrupt-parent = <&tlmm>;
- interrupts = <22 0x2008>;
+ interrupts = <22 IRQ_TYPE_LEVEL_LOW>;
vdd-supply = <&pm6125_l13>;
avdd-supply = <&touch_avdd>;
--
2.43.0
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH RFT 2/4] arm64: dts: qcom: sm6375-pdx225: correct touchscreen interrupt flags
2024-06-05 16:00 ` [PATCH RFT 2/4] arm64: dts: qcom: sm6375-pdx225: " Krzysztof Kozlowski
@ 2024-06-06 10:18 ` Konrad Dybcio
0 siblings, 0 replies; 9+ messages in thread
From: Konrad Dybcio @ 2024-06-06 10:18 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
linux-kernel
On 5.06.2024 6:00 PM, Krzysztof Kozlowski wrote:
> Interrupt flags 0x2008 looks like some downstream copy-paste, because
> generic GPIOLIB code, used by Qualcomm pin controller drivers, ignores
> flags outside of IRQ_TYPE_SENSE_MASK. Probably the intention was to
> pass just 0x8, so IRQ_TYPE_LEVEL_LOW.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH RFT 3/4] arm64: dts: qcom: sm8250-sony-xperia: correct touchscreen interrupt flags
2024-06-05 16:00 [PATCH RFT 1/4] arm64: dts: qcom: sm6350-pdx213: correct touchscreen interrupt flags Krzysztof Kozlowski
2024-06-05 16:00 ` [PATCH RFT 2/4] arm64: dts: qcom: sm6375-pdx225: " Krzysztof Kozlowski
@ 2024-06-05 16:00 ` Krzysztof Kozlowski
2024-06-06 10:19 ` Konrad Dybcio
2024-06-05 16:00 ` [PATCH RFT 4/4] arm64: dts: qcom: sm8450-sony-xperia: " Krzysztof Kozlowski
` (2 subsequent siblings)
4 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2024-06-05 16:00 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Interrupt flags 0x2008 looks like some downstream copy-paste, because
generic GPIOLIB code, used by Qualcomm pin controller drivers, ignores
flags outside of IRQ_TYPE_SENSE_MASK. Probably the intention was to
pass just 0x8, so IRQ_TYPE_LEVEL_LOW.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
index e07d0311ecb5..f6870d3f2886 100644
--- a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
@@ -520,7 +520,7 @@ touchscreen@48 {
compatible = "samsung,s6sy761";
reg = <0x48>;
interrupt-parent = <&tlmm>;
- interrupts = <39 0x2008>;
+ interrupts = <39 IRQ_TYPE_LEVEL_LOW>;
/* It's "vddio" downstream but it works anyway! */
vdd-supply = <&vreg_l1c_1p8>;
avdd-supply = <&vreg_l10c_3p3>;
--
2.43.0
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH RFT 3/4] arm64: dts: qcom: sm8250-sony-xperia: correct touchscreen interrupt flags
2024-06-05 16:00 ` [PATCH RFT 3/4] arm64: dts: qcom: sm8250-sony-xperia: " Krzysztof Kozlowski
@ 2024-06-06 10:19 ` Konrad Dybcio
0 siblings, 0 replies; 9+ messages in thread
From: Konrad Dybcio @ 2024-06-06 10:19 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
linux-kernel
On 5.06.2024 6:00 PM, Krzysztof Kozlowski wrote:
> Interrupt flags 0x2008 looks like some downstream copy-paste, because
> generic GPIOLIB code, used by Qualcomm pin controller drivers, ignores
> flags outside of IRQ_TYPE_SENSE_MASK. Probably the intention was to
> pass just 0x8, so IRQ_TYPE_LEVEL_LOW.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH RFT 4/4] arm64: dts: qcom: sm8450-sony-xperia: correct touchscreen interrupt flags
2024-06-05 16:00 [PATCH RFT 1/4] arm64: dts: qcom: sm6350-pdx213: correct touchscreen interrupt flags Krzysztof Kozlowski
2024-06-05 16:00 ` [PATCH RFT 2/4] arm64: dts: qcom: sm6375-pdx225: " Krzysztof Kozlowski
2024-06-05 16:00 ` [PATCH RFT 3/4] arm64: dts: qcom: sm8250-sony-xperia: " Krzysztof Kozlowski
@ 2024-06-05 16:00 ` Krzysztof Kozlowski
2024-06-06 10:19 ` Konrad Dybcio
2024-06-06 10:18 ` [PATCH RFT 1/4] arm64: dts: qcom: sm6350-pdx213: " Konrad Dybcio
2024-06-07 2:33 ` Bjorn Andersson
4 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2024-06-05 16:00 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Interrupt flags 0x2008 looks like some downstream copy-paste, because
generic GPIOLIB code, used by Qualcomm pin controller drivers, ignores
flags outside of IRQ_TYPE_SENSE_MASK. Probably the intention was to
pass just 0x8, so IRQ_TYPE_LEVEL_LOW.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara.dtsi b/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara.dtsi
index 8b29fcf483a3..17dbb67868ae 100644
--- a/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara.dtsi
@@ -488,7 +488,7 @@ touchscreen@48 {
compatible = "samsung,s6sy761";
reg = <0x48>;
interrupt-parent = <&tlmm>;
- interrupts = <21 0x2008>;
+ interrupts = <21 IRQ_TYPE_LEVEL_LOW>;
vdd-supply = <&pm8350c_l2>;
avdd-supply = <&pm8350c_l3>;
--
2.43.0
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH RFT 4/4] arm64: dts: qcom: sm8450-sony-xperia: correct touchscreen interrupt flags
2024-06-05 16:00 ` [PATCH RFT 4/4] arm64: dts: qcom: sm8450-sony-xperia: " Krzysztof Kozlowski
@ 2024-06-06 10:19 ` Konrad Dybcio
0 siblings, 0 replies; 9+ messages in thread
From: Konrad Dybcio @ 2024-06-06 10:19 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
linux-kernel
On 5.06.2024 6:00 PM, Krzysztof Kozlowski wrote:
> Interrupt flags 0x2008 looks like some downstream copy-paste, because
> generic GPIOLIB code, used by Qualcomm pin controller drivers, ignores
> flags outside of IRQ_TYPE_SENSE_MASK. Probably the intention was to
> pass just 0x8, so IRQ_TYPE_LEVEL_LOW.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
I only tested on one 8450 device, but they're all:
- the same tlmm
- the same geni
- the same touchscreen
so I suppose it's alright
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Tested-by: Konrad Dybcio <konrad.dybcio@linaro.org> # SM8450 PDX223
Konrad
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH RFT 1/4] arm64: dts: qcom: sm6350-pdx213: correct touchscreen interrupt flags
2024-06-05 16:00 [PATCH RFT 1/4] arm64: dts: qcom: sm6350-pdx213: correct touchscreen interrupt flags Krzysztof Kozlowski
` (2 preceding siblings ...)
2024-06-05 16:00 ` [PATCH RFT 4/4] arm64: dts: qcom: sm8450-sony-xperia: " Krzysztof Kozlowski
@ 2024-06-06 10:18 ` Konrad Dybcio
2024-06-07 2:33 ` Bjorn Andersson
4 siblings, 0 replies; 9+ messages in thread
From: Konrad Dybcio @ 2024-06-06 10:18 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
linux-kernel
On 5.06.2024 6:00 PM, Krzysztof Kozlowski wrote:
> Interrupt flags 0x2008 looks like some downstream copy-paste, because
> generic GPIOLIB code, used by Qualcomm pin controller drivers, ignores
> flags outside of IRQ_TYPE_SENSE_MASK. Probably the intention was to
> pass just 0x8, so IRQ_TYPE_LEVEL_LOW.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH RFT 1/4] arm64: dts: qcom: sm6350-pdx213: correct touchscreen interrupt flags
2024-06-05 16:00 [PATCH RFT 1/4] arm64: dts: qcom: sm6350-pdx213: correct touchscreen interrupt flags Krzysztof Kozlowski
` (3 preceding siblings ...)
2024-06-06 10:18 ` [PATCH RFT 1/4] arm64: dts: qcom: sm6350-pdx213: " Konrad Dybcio
@ 2024-06-07 2:33 ` Bjorn Andersson
4 siblings, 0 replies; 9+ messages in thread
From: Bjorn Andersson @ 2024-06-07 2:33 UTC (permalink / raw)
To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-arm-msm, devicetree, linux-kernel, Krzysztof Kozlowski
On Wed, 05 Jun 2024 18:00:29 +0200, Krzysztof Kozlowski wrote:
> Interrupt flags 0x2008 looks like some downstream copy-paste, because
> generic GPIOLIB code, used by Qualcomm pin controller drivers, ignores
> flags outside of IRQ_TYPE_SENSE_MASK. Probably the intention was to
> pass just 0x8, so IRQ_TYPE_LEVEL_LOW.
>
>
Applied, thanks!
[1/4] arm64: dts: qcom: sm6350-pdx213: correct touchscreen interrupt flags
commit: d044c0e36d095996f7b29a928e06c9475c4075e6
[2/4] arm64: dts: qcom: sm6375-pdx225: correct touchscreen interrupt flags
commit: fa2c8cad202195bfa87b18dc44ff4981d45085b4
[3/4] arm64: dts: qcom: sm8250-sony-xperia: correct touchscreen interrupt flags
commit: 46822d2750822dbe58bcd999cbedf24147cb5fc3
[4/4] arm64: dts: qcom: sm8450-sony-xperia: correct touchscreen interrupt flags
commit: 05d84f973d84d23e0a249ae5b3f6d7572fdc5e1e
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 9+ messages in thread