From: Jens Axboe <axboe@kernel.dk>
To: jonathan.derrick@linux.dev, nathan@kernel.org,
ndesaulniers@google.com, morbo@google.com,
justinstitt@google.com, Su Hui <suhui@nfschina.com>
Cc: jarkko@kernel.org, gjoyce@linux.vnet.ibm.com,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] block: sed-opal: avoid possible wrong address reference in read_sed_opal_key()
Date: Wed, 12 Jun 2024 11:00:27 -0600 [thread overview]
Message-ID: <171821162747.49689.15711924368254843874.b4-ty@kernel.dk> (raw)
In-Reply-To: <20240611073659.429582-1-suhui@nfschina.com>
On Tue, 11 Jun 2024 15:37:00 +0800, Su Hui wrote:
> Clang static checker (scan-build) warning:
> block/sed-opal.c:line 317, column 3
> Value stored to 'ret' is never read.
>
> Fix this problem by returning the error code when keyring_search() failed.
> Otherwise, 'key' will have a wrong value when 'kerf' stores the error code.
>
> [...]
Applied, thanks!
[1/1] block: sed-opal: avoid possible wrong address reference in read_sed_opal_key()
commit: 9b1ebce6a1fded90d4a1c6c57dc6262dac4c4c14
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2024-06-12 17:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 7:37 Su Hui
2024-06-12 17:00 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171821162747.49689.15711924368254843874.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=gjoyce@linux.vnet.ibm.com \
--cc=jarkko@kernel.org \
--cc=jonathan.derrick@linux.dev \
--cc=justinstitt@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=suhui@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®