* [PATCH] block: sed-opal: avoid possible wrong address reference in read_sed_opal_key()
@ 2024-06-11 7:37 Su Hui
2024-06-12 17:00 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Su Hui @ 2024-06-11 7:37 UTC (permalink / raw)
To: jonathan.derrick, axboe, nathan, ndesaulniers, morbo, justinstitt
Cc: Su Hui, jarkko, gjoyce, linux-block, linux-kernel, llvm, kernel-janitors
Clang static checker (scan-build) warning:
block/sed-opal.c:line 317, column 3
Value stored to 'ret' is never read.
Fix this problem by returning the error code when keyring_search() failed.
Otherwise, 'key' will have a wrong value when 'kerf' stores the error code.
Fixes: 3bfeb6125664 ("block: sed-opal: keyring support for SED keys")
Signed-off-by: Su Hui <suhui@nfschina.com>
---
block/sed-opal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/sed-opal.c b/block/sed-opal.c
index 14fe0fef811c..598fd3e7fcc8 100644
--- a/block/sed-opal.c
+++ b/block/sed-opal.c
@@ -314,7 +314,7 @@ static int read_sed_opal_key(const char *key_name, u_char *buffer, int buflen)
&key_type_user, key_name, true);
if (IS_ERR(kref))
- ret = PTR_ERR(kref);
+ return PTR_ERR(kref);
key = key_ref_to_ptr(kref);
down_read(&key->sem);
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] block: sed-opal: avoid possible wrong address reference in read_sed_opal_key()
2024-06-11 7:37 [PATCH] block: sed-opal: avoid possible wrong address reference in read_sed_opal_key() Su Hui
@ 2024-06-12 17:00 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2024-06-12 17:00 UTC (permalink / raw)
To: jonathan.derrick, nathan, ndesaulniers, morbo, justinstitt, Su Hui
Cc: jarkko, gjoyce, linux-block, linux-kernel, llvm, kernel-janitors
On Tue, 11 Jun 2024 15:37:00 +0800, Su Hui wrote:
> Clang static checker (scan-build) warning:
> block/sed-opal.c:line 317, column 3
> Value stored to 'ret' is never read.
>
> Fix this problem by returning the error code when keyring_search() failed.
> Otherwise, 'key' will have a wrong value when 'kerf' stores the error code.
>
> [...]
Applied, thanks!
[1/1] block: sed-opal: avoid possible wrong address reference in read_sed_opal_key()
commit: 9b1ebce6a1fded90d4a1c6c57dc6262dac4c4c14
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-06-12 17:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-11 7:37 [PATCH] block: sed-opal: avoid possible wrong address reference in read_sed_opal_key() Su Hui
2024-06-12 17:00 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®