From: "Rob Herring (Arm)" <robh@kernel.org>
To: Jie Gan <quic_jiegan@quicinc.com>
Cc: Tingwei Zhang <quic_tingweiz@quicinc.com>,
linux-kernel@vger.kernel.org,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
quic_xinlon@quicinc.com, Song Chai <quic_songchai@quicinc.com>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Jinlong Mao <quic_jinlmao@quicinc.com>,
quic_yanzl@quicinc.com, Tao Zhang <quic_taozha@quicinc.com>,
andersson@kernel.org, Suzuki K Poulose <suzuki.poulose@arm.com>,
linux-arm-kernel@lists.infradead.org, quic_yuanjiey@quicinc.com,
Konrad Dybcio <konradybcio@gmail.com>,
Mike Leach <mike.leach@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
coresight@lists.linaro.org, Trilok Soni <quic_tsoni@quicinc.com>,
quic_liuxin@quicinc.com, quic_yijiyang@quicinc.com,
quic_sijiwu@quicinc.com, quic_xueqnie@quicinc.com,
Yuanfang Zhang <quic_yuanfang@quicinc.com>
Subject: Re: [PATCH v1 1/3] dt-bindings: arm: Add binding document for Coresight Slave Register device.
Date: Tue, 18 Jun 2024 05:12:35 -0600 [thread overview]
Message-ID: <171870915568.1107169.13844924050806547324.robh@kernel.org> (raw)
In-Reply-To: <20240618072726.3767974-2-quic_jiegan@quicinc.com>
On Tue, 18 Jun 2024 15:27:24 +0800, Jie Gan wrote:
> Add binding document for Coresight Slave Register device.
>
> Add a new property to TMC, qcom,csr-atid-offset, to indicate which
> ATID registers will be used by the TMC ETR. Each TMC ETR device is
> associated with four ATID registers that are continuous in address.
>
> Signed-off-by: Jie Gan <quic_jiegan@quicinc.com>
> ---
> .../bindings/arm/arm,coresight-tmc.yaml | 8 ++
> .../bindings/arm/qcom,coresight-csr.yaml | 76 +++++++++++++++++++
> 2 files changed, 84 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/arm/qcom,coresight-csr.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/arm/qcom,coresight-csr.yaml: properties:clock-names: {'maxItems': 1, 'items': [{'const': 'apb_pclk'}]} should not be valid under {'required': ['maxItems']}
hint: "maxItems" is not needed with an "items" list
from schema $id: http://devicetree.org/meta-schemas/items.yaml#
Error: Documentation/devicetree/bindings/arm/qcom,coresight-csr.example.dts:43.3-44.1 syntax error
FATAL ERROR: Unable to parse input tree
make[2]: *** [scripts/Makefile.lib:427: Documentation/devicetree/bindings/arm/qcom,coresight-csr.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1430: dt_binding_check] Error 2
make: *** [Makefile:240: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240618072726.3767974-2-quic_jiegan@quicinc.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2024-06-18 11:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 7:27 [PATCH v1 0/3] Add coresight slave register driver to support data filter function Jie Gan
2024-06-18 7:27 ` [PATCH v1 1/3] dt-bindings: arm: Add binding document for Coresight Slave Register device Jie Gan
2024-06-18 9:56 ` Suzuki K Poulose
2024-06-19 6:07 ` JieGan
2024-06-18 11:12 ` Rob Herring (Arm) [this message]
2024-06-18 7:27 ` [PATCH v1 2/3] coresight: Add coresight slave register driver to support data filter function in sysfs mode Jie Gan
2024-06-19 7:55 ` [PATCH " Markus Elfring
2024-06-19 8:12 ` Greg Kroah-Hartman
2024-06-21 7:36 ` [PATCH v1 " kernel test robot
2024-06-18 7:27 ` [PATCH v1 3/3] arm64: dts: qcom: Add CSR and ETR nodes for SA8775p Jie Gan
2024-06-19 13:57 ` kernel test robot
2024-06-18 9:47 ` [PATCH v1 0/3] Add coresight slave register driver to support data filter function Suzuki K Poulose
2024-06-19 6:05 ` JieGan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171870915568.1107169.13844924050806547324.robh@kernel.org \
--to=robh@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andersson@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=konradybcio@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=quic_jiegan@quicinc.com \
--cc=quic_jinlmao@quicinc.com \
--cc=quic_liuxin@quicinc.com \
--cc=quic_sijiwu@quicinc.com \
--cc=quic_songchai@quicinc.com \
--cc=quic_taozha@quicinc.com \
--cc=quic_tingweiz@quicinc.com \
--cc=quic_tsoni@quicinc.com \
--cc=quic_xinlon@quicinc.com \
--cc=quic_xueqnie@quicinc.com \
--cc=quic_yanzl@quicinc.com \
--cc=quic_yijiyang@quicinc.com \
--cc=quic_yuanfang@quicinc.com \
--cc=quic_yuanjiey@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®