From: Markus Elfring <Markus.Elfring@web.de>
To: Jie Gan <quic_jiegan@quicinc.com>,
coresight@lists.linaro.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Konrad Dybcio <konradybcio@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Mike Leach <mike.leach@linaro.org>, Rob Herring <robh@kernel.org>,
Suzuki Poulouse <suzuki.poulose@arm.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jinlong Mao <quic_jinlmao@quicinc.com>,
Song Chai <quic_songchai@quicinc.com>,
Tao Zhang <quic_taozha@quicinc.com>,
Tingwei Zhang <quic_tingweiz@quicinc.com>,
Trilok Soni <quic_tsoni@quicinc.com>,
Yuanfang Zhang <quic_yuanfang@quicinc.com>,
quic_liuxin@quicinc.com, quic_sijiwu@quicinc.com,
quic_xinlon@quicinc.com, quic_xueqnie@quicinc.com,
quic_yanzl@quicinc.com, quic_yijiyang@quicinc.com,
quic_yuanjiey@quicinc.com
Subject: Re: [PATCH 2/3] coresight: Add coresight slave register driver to support data filter function in sysfs mode
Date: Wed, 19 Jun 2024 09:55:25 +0200 [thread overview]
Message-ID: <e916a445-f7bd-4213-ac66-cf39f6c5001b@web.de> (raw)
In-Reply-To: <20240618072726.3767974-3-quic_jiegan@quicinc.com>
…
> +++ b/drivers/hwtracing/coresight/coresight-csr.c
> @@ -0,0 +1,315 @@
…
> +static int __csr_set_etr_traceid(struct coresight_device *csdev,
> + uint32_t atid_offset, uint32_t traceid,
> + bool enable)
> +{
…
> + spin_lock_irqsave(&drvdata->spin_lock, flags);
> + CS_UNLOCK(drvdata->base);
…
> + CS_LOCK(drvdata->base);
> + spin_unlock_irqrestore(&drvdata->spin_lock, flags);
> + return 0;
> +}
…
Would you become interested to apply a statement like “guard(spinlock_irqsave)(&drvdata->spin_lock);”?
https://elixir.bootlin.com/linux/v6.10-rc4/source/include/linux/spinlock.h#L574
Regards,
Markus
next prev parent reply other threads:[~2024-06-19 7:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 7:27 [PATCH v1 0/3] Add coresight slave register driver to support data filter function Jie Gan
2024-06-18 7:27 ` [PATCH v1 1/3] dt-bindings: arm: Add binding document for Coresight Slave Register device Jie Gan
2024-06-18 9:56 ` Suzuki K Poulose
2024-06-19 6:07 ` JieGan
2024-06-18 11:12 ` Rob Herring (Arm)
2024-06-18 7:27 ` [PATCH v1 2/3] coresight: Add coresight slave register driver to support data filter function in sysfs mode Jie Gan
2024-06-19 7:55 ` Markus Elfring [this message]
2024-06-19 8:12 ` [PATCH " Greg Kroah-Hartman
2024-06-21 7:36 ` [PATCH v1 " kernel test robot
2024-06-18 7:27 ` [PATCH v1 3/3] arm64: dts: qcom: Add CSR and ETR nodes for SA8775p Jie Gan
2024-06-19 13:57 ` kernel test robot
2024-06-18 9:47 ` [PATCH v1 0/3] Add coresight slave register driver to support data filter function Suzuki K Poulose
2024-06-19 6:05 ` JieGan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e916a445-f7bd-4213-ac66-cf39f6c5001b@web.de \
--to=markus.elfring@web.de \
--cc=alexander.shishkin@linux.intel.com \
--cc=andersson@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=konradybcio@gmail.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=quic_jiegan@quicinc.com \
--cc=quic_jinlmao@quicinc.com \
--cc=quic_liuxin@quicinc.com \
--cc=quic_sijiwu@quicinc.com \
--cc=quic_songchai@quicinc.com \
--cc=quic_taozha@quicinc.com \
--cc=quic_tingweiz@quicinc.com \
--cc=quic_tsoni@quicinc.com \
--cc=quic_xinlon@quicinc.com \
--cc=quic_xueqnie@quicinc.com \
--cc=quic_yanzl@quicinc.com \
--cc=quic_yijiyang@quicinc.com \
--cc=quic_yuanfang@quicinc.com \
--cc=quic_yuanjiey@quicinc.com \
--cc=robh@kernel.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®