From: David Ahern <dsahern@gmail.com>
To: David Miller <davem@davemloft.net>, fruggeri@arista.com
Cc: yoshfuji@linux-ipv6.org, kuznet@ms2.inr.ac.ru, maxim@arista.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net: ipv6: check net in ip6_call_ra_chain
Date: Thu, 28 Feb 2019 16:31:40 -0700 [thread overview]
Message-ID: <171e33d9-ee82-6a62-693e-5d585e4eca28@gmail.com> (raw)
In-Reply-To: <20190228.130213.1481374802407995712.davem@davemloft.net>
On 2/28/19 2:02 PM, David Miller wrote:
> From: fruggeri@arista.com (Francesco Ruggeri)
> Date: Thu, 28 Feb 2019 11:01:46 -0800
>
>> ip6_call_ra_chain is called when IPv6 packet with Router Alert option
>> is forwarded.
>> It needs to check if the net of the socket is the same as the net of the
>> input device, otherwise the packet gets delivered to every IPv6 socket
>> listening for Router Alerts, no matter which network namespace it is in.
>>
>> Suggested-by: Maxim Martynov <maxim@arista.com>
>> Signed-off-by: Maxim Martynov <maxim@arista.com>
>> Signed-off-by: Francesco Ruggeri <fruggeri@arista.com>
>
> Right now someone using such a tool does get all RAs in the system.
>
> Your change not only breaks them, but also gives them no method by
> which to keep obtaining the same behavior.
>
> I don't know what to do or suggest in this situation, but right now
> I'm putting this patch on hold.
>
need an equivalent to NETLINK_LISTEN_ALL_NSID
next prev parent reply other threads:[~2019-02-28 23:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 19:01 Francesco Ruggeri
2019-02-28 21:02 ` David Miller
2019-02-28 23:31 ` David Ahern [this message]
2019-03-01 0:09 ` Francesco Ruggeri
2019-03-01 2:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171e33d9-ee82-6a62-693e-5d585e4eca28@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=fruggeri@arista.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=maxim@arista.com \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®