From: fruggeri@arista.com (Francesco Ruggeri)
To: yoshfuji@linux-ipv6.org, kuznet@ms2.inr.ac.ru,
davem@davemloft.net, maxim@arista.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
fruggeri@arista.com
Subject: [PATCH] net: ipv6: check net in ip6_call_ra_chain
Date: Thu, 28 Feb 2019 11:01:46 -0800 [thread overview]
Message-ID: <20190228190146.802CD95C016B@us180.sjc.aristanetworks.com> (raw)
ip6_call_ra_chain is called when IPv6 packet with Router Alert option
is forwarded.
It needs to check if the net of the socket is the same as the net of the
input device, otherwise the packet gets delivered to every IPv6 socket
listening for Router Alerts, no matter which network namespace it is in.
Suggested-by: Maxim Martynov <maxim@arista.com>
Signed-off-by: Maxim Martynov <maxim@arista.com>
Signed-off-by: Francesco Ruggeri <fruggeri@arista.com>
---
net/ipv6/ip6_output.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c
index 5f9fa0302b5a..3ed25e17dff3 100644
--- a/net/ipv6/ip6_output.c
+++ b/net/ipv6/ip6_output.c
@@ -299,7 +299,8 @@ static int ip6_call_ra_chain(struct sk_buff *skb, int sel)
struct sock *sk = ra->sk;
if (sk && ra->sel == sel &&
(!sk->sk_bound_dev_if ||
- sk->sk_bound_dev_if == skb->dev->ifindex)) {
+ sk->sk_bound_dev_if == skb->dev->ifindex) &&
+ net_eq(sock_net(sk), dev_net(skb->dev))) {
if (last) {
struct sk_buff *skb2 = skb_clone(skb, GFP_ATOMIC);
if (skb2)
--
2.19.1
next reply other threads:[~2019-02-28 19:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 19:01 Francesco Ruggeri [this message]
2019-02-28 21:02 ` David Miller
2019-02-28 23:31 ` David Ahern
2019-03-01 0:09 ` Francesco Ruggeri
2019-03-01 2:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190228190146.802CD95C016B@us180.sjc.aristanetworks.com \
--to=fruggeri@arista.com \
--cc=davem@davemloft.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=maxim@arista.com \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®