mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "tip-bot2 for Anna-Maria Behnsen" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: "Anna-Maria Behnsen" <anna-maria@linutronix.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	Vincenzo Frascino <vincenzo.frascino@arm.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: timers/core] vdso: Add comment about reason for vdso struct ordering
Date: Wed, 03 Jul 2024 19:36:19 -0000	[thread overview]
Message-ID: <172003537996.2215.8639468667212721241.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20240701-vdso-cleanup-v1-2-36eb64e7ece2@linutronix.de>

The following commit has been merged into the timers/core branch of tip:

Commit-ID:     d00106bbdfa82732c23cba44491c38f8c410d865
Gitweb:        https://git.kernel.org/tip/d00106bbdfa82732c23cba44491c38f8c410d865
Author:        Anna-Maria Behnsen <anna-maria@linutronix.de>
AuthorDate:    Mon, 01 Jul 2024 16:47:55 +02:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Wed, 03 Jul 2024 21:27:03 +02:00

vdso: Add comment about reason for vdso struct ordering

struct vdso_data is optimized for fast access to the often required struct
members. The optimization is not documented in the struct description but
it should be kept in mind, when working with the vdso_data struct.
                                                                                                                                                                                                                                             
Add a comment to the struct description.

Signed-off-by: Anna-Maria Behnsen <anna-maria@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
Link: https://lore.kernel.org/r/20240701-vdso-cleanup-v1-2-36eb64e7ece2@linutronix.de

---
 include/vdso/datapage.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/include/vdso/datapage.h b/include/vdso/datapage.h
index d04d394..7647e09 100644
--- a/include/vdso/datapage.h
+++ b/include/vdso/datapage.h
@@ -77,6 +77,10 @@ struct vdso_timestamp {
  * vdso_data will be accessed by 64 bit and compat code at the same time
  * so we should be careful before modifying this structure.
  *
+ * The ordering of the struct members is optimized to have fast access to the
+ * often required struct members which are related to CLOCK_REALTIME and
+ * CLOCK_MONOTONIC. This information is stored in the first cache lines.
+ *
  * @basetime is used to store the base time for the system wide time getter
  * VVAR page.
  *

  parent reply	other threads:[~2024-07-03 19:36 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-01 14:47 [PATCH 0/5] vdso (generic and x86): Misc minor cleanups Anna-Maria Behnsen
2024-07-01 14:47 ` [PATCH 1/5] vdso/gettimeofday: Clarify comment about open coded function Anna-Maria Behnsen
2024-07-01 14:58   ` Vincenzo Frascino
2024-07-03 19:36   ` [tip: timers/core] " tip-bot2 for Anna-Maria Behnsen
2024-07-01 14:47 ` [PATCH 2/5] vdso: Add comment about reason for vdso struct ordering Anna-Maria Behnsen
2024-07-01 15:10   ` Vincenzo Frascino
2024-07-01 15:31     ` Anna-Maria Behnsen
2024-07-01 16:17       ` Vincenzo Frascino
2024-07-03 19:36   ` tip-bot2 for Anna-Maria Behnsen [this message]
2024-07-01 14:47 ` [PATCH 3/5] x86/vdso: Fix function reference in comment Anna-Maria Behnsen
2024-07-01 15:11   ` Vincenzo Frascino
2024-07-03 19:36   ` [tip: timers/core] " tip-bot2 for Anna-Maria Behnsen
2024-07-01 14:47 ` [PATCH 4/5] x86/vgtod: Remove unused typedef gtod_long_t Anna-Maria Behnsen
2024-07-01 15:19   ` Vincenzo Frascino
2024-07-03 19:36   ` [tip: timers/core] " tip-bot2 for Anna-Maria Behnsen
2024-07-01 14:47 ` [PATCH 5/5] x86/vdso: Remove unused include Anna-Maria Behnsen
2024-07-01 16:19   ` Vincenzo Frascino
2024-07-03 19:36   ` [tip: timers/core] " tip-bot2 for Anna-Maria Behnsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=172003537996.2215.8639468667212721241.tip-bot2@tip-bot2 \
    --to=tip-bot2@linutronix.de \
    --cc=anna-maria@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=vincenzo.frascino@arm.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®