From: "tip-bot2 for Anna-Maria Behnsen" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: "Anna-Maria Behnsen" <anna-maria@linutronix.de>,
Thomas Gleixner <tglx@linutronix.de>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: timers/core] vdso/gettimeofday: Clarify comment about open coded function
Date: Wed, 03 Jul 2024 19:36:20 -0000 [thread overview]
Message-ID: <172003538036.2215.4609585909791491212.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20240701-vdso-cleanup-v1-1-36eb64e7ece2@linutronix.de>
The following commit has been merged into the timers/core branch of tip:
Commit-ID: f48955e038eaf43812c3701079c7371abe0315a4
Gitweb: https://git.kernel.org/tip/f48955e038eaf43812c3701079c7371abe0315a4
Author: Anna-Maria Behnsen <anna-maria@linutronix.de>
AuthorDate: Mon, 01 Jul 2024 16:47:54 +02:00
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Wed, 03 Jul 2024 21:27:03 +02:00
vdso/gettimeofday: Clarify comment about open coded function
The two comments state, that the following code open codes something but
they lack to specify what exactly is open coded.
Expand comments by mentioning the reference to the open coded function.
Signed-off-by: Anna-Maria Behnsen <anna-maria@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
Link: https://lore.kernel.org/r/20240701-vdso-cleanup-v1-1-36eb64e7ece2@linutronix.de
---
lib/vdso/gettimeofday.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/lib/vdso/gettimeofday.c b/lib/vdso/gettimeofday.c
index 899850b..c01eaaf 100644
--- a/lib/vdso/gettimeofday.c
+++ b/lib/vdso/gettimeofday.c
@@ -140,14 +140,14 @@ static __always_inline int do_hres(const struct vdso_data *vd, clockid_t clk,
do {
/*
- * Open coded to handle VDSO_CLOCKMODE_TIMENS. Time namespace
- * enabled tasks have a special VVAR page installed which
- * has vd->seq set to 1 and vd->clock_mode set to
- * VDSO_CLOCKMODE_TIMENS. For non time namespace affected tasks
- * this does not affect performance because if vd->seq is
- * odd, i.e. a concurrent update is in progress the extra
- * check for vd->clock_mode is just a few extra
- * instructions while spin waiting for vd->seq to become
+ * Open coded function vdso_read_begin() to handle
+ * VDSO_CLOCKMODE_TIMENS. Time namespace enabled tasks have a
+ * special VVAR page installed which has vd->seq set to 1 and
+ * vd->clock_mode set to VDSO_CLOCKMODE_TIMENS. For non time
+ * namespace affected tasks this does not affect performance
+ * because if vd->seq is odd, i.e. a concurrent update is in
+ * progress the extra check for vd->clock_mode is just a few
+ * extra instructions while spin waiting for vd->seq to become
* even again.
*/
while (unlikely((seq = READ_ONCE(vd->seq)) & 1)) {
@@ -223,8 +223,8 @@ static __always_inline int do_coarse(const struct vdso_data *vd, clockid_t clk,
do {
/*
- * Open coded to handle VDSO_CLOCK_TIMENS. See comment in
- * do_hres().
+ * Open coded function vdso_read_begin() to handle
+ * VDSO_CLOCK_TIMENS. See comment in do_hres().
*/
while ((seq = READ_ONCE(vd->seq)) & 1) {
if (IS_ENABLED(CONFIG_TIME_NS) &&
next prev parent reply other threads:[~2024-07-03 19:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 14:47 [PATCH 0/5] vdso (generic and x86): Misc minor cleanups Anna-Maria Behnsen
2024-07-01 14:47 ` [PATCH 1/5] vdso/gettimeofday: Clarify comment about open coded function Anna-Maria Behnsen
2024-07-01 14:58 ` Vincenzo Frascino
2024-07-03 19:36 ` tip-bot2 for Anna-Maria Behnsen [this message]
2024-07-01 14:47 ` [PATCH 2/5] vdso: Add comment about reason for vdso struct ordering Anna-Maria Behnsen
2024-07-01 15:10 ` Vincenzo Frascino
2024-07-01 15:31 ` Anna-Maria Behnsen
2024-07-01 16:17 ` Vincenzo Frascino
2024-07-03 19:36 ` [tip: timers/core] " tip-bot2 for Anna-Maria Behnsen
2024-07-01 14:47 ` [PATCH 3/5] x86/vdso: Fix function reference in comment Anna-Maria Behnsen
2024-07-01 15:11 ` Vincenzo Frascino
2024-07-03 19:36 ` [tip: timers/core] " tip-bot2 for Anna-Maria Behnsen
2024-07-01 14:47 ` [PATCH 4/5] x86/vgtod: Remove unused typedef gtod_long_t Anna-Maria Behnsen
2024-07-01 15:19 ` Vincenzo Frascino
2024-07-03 19:36 ` [tip: timers/core] " tip-bot2 for Anna-Maria Behnsen
2024-07-01 14:47 ` [PATCH 5/5] x86/vdso: Remove unused include Anna-Maria Behnsen
2024-07-01 16:19 ` Vincenzo Frascino
2024-07-03 19:36 ` [tip: timers/core] " tip-bot2 for Anna-Maria Behnsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172003538036.2215.4609585909791491212.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=anna-maria@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=vincenzo.frascino@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®