* [PATCH net v3 1/1] net: phy: microchip: lan87xx: reinit PHY after cable test
@ 2024-07-05 8:49 Oleksij Rempel
2024-07-09 3:40 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Oleksij Rempel @ 2024-07-05 8:49 UTC (permalink / raw)
To: David S. Miller, Andrew Lunn, Eric Dumazet, Florian Fainelli,
Jakub Kicinski, Paolo Abeni, Woojung Huh, Arun Ramadoss,
Heiner Kallweit, Russell King, Yuiko Oshino
Cc: Oleksij Rempel, Michal Kubiak, Florian Fainelli, kernel,
linux-kernel, netdev, UNGLinuxDriver
Reinit PHY after cable test, otherwise link can't be established on
tested port. This issue is reproducible on LAN9372 switches with
integrated 100BaseT1 PHYs.
Fixes: 788050256c411 ("net: phy: microchip_t1: add cable test support for lan87xx phy")
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
---
changes v3:
- add Reviewed-by: Michal Kubiak and Florian Fainelli from v1 patch
changes v2:
- add Reviewed-by: Andrew Lunn <andrew@lunn.ch>
- drop microchip specific SQI fix
---
drivers/net/phy/microchip_t1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/microchip_t1.c b/drivers/net/phy/microchip_t1.c
index a838b61cd844b..a35528497a576 100644
--- a/drivers/net/phy/microchip_t1.c
+++ b/drivers/net/phy/microchip_t1.c
@@ -748,7 +748,7 @@ static int lan87xx_cable_test_report(struct phy_device *phydev)
ethnl_cable_test_result(phydev, ETHTOOL_A_CABLE_PAIR_A,
lan87xx_cable_test_report_trans(detect));
- return 0;
+ return phy_init_hw(phydev);
}
static int lan87xx_cable_test_get_status(struct phy_device *phydev,
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH net v3 1/1] net: phy: microchip: lan87xx: reinit PHY after cable test
2024-07-05 8:49 [PATCH net v3 1/1] net: phy: microchip: lan87xx: reinit PHY after cable test Oleksij Rempel
@ 2024-07-09 3:40 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-07-09 3:40 UTC (permalink / raw)
To: Oleksij Rempel
Cc: davem, andrew, edumazet, f.fainelli, kuba, pabeni, woojung.huh,
arun.ramadoss, hkallweit1, linux, yuiko.oshino, michal.kubiak,
florian.fainelli, kernel, linux-kernel, netdev, UNGLinuxDriver
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 5 Jul 2024 10:49:54 +0200 you wrote:
> Reinit PHY after cable test, otherwise link can't be established on
> tested port. This issue is reproducible on LAN9372 switches with
> integrated 100BaseT1 PHYs.
>
> Fixes: 788050256c411 ("net: phy: microchip_t1: add cable test support for lan87xx phy")
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>
> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
>
> [...]
Here is the summary with links:
- [net,v3,1/1] net: phy: microchip: lan87xx: reinit PHY after cable test
https://git.kernel.org/netdev/net/c/30f747b8d53b
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-07-09 3:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-05 8:49 [PATCH net v3 1/1] net: phy: microchip: lan87xx: reinit PHY after cable test Oleksij Rempel
2024-07-09 3:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®