* [PATCH] arm64/Kconfig: Remove redundant 'if HAVE_FUNCTION_GRAPH_TRACER'
@ 2024-07-16 5:09 Anshuman Khandual
2024-07-16 13:26 ` Mark Rutland
2024-07-23 15:46 ` Will Deacon
0 siblings, 2 replies; 3+ messages in thread
From: Anshuman Khandual @ 2024-07-16 5:09 UTC (permalink / raw)
To: linux-arm-kernel
Cc: mark.rutland, masahiroy, Anshuman Khandual, Catalin Marinas,
Will Deacon, linux-kernel
Since the commit 819e50e25d0c ("arm64: Add ftrace support"),
HAVE_FUNCTION_GRAPH_TRACER has always been enabled. Although a subsequent
commit 364697032246 ("arm64: ftrace: Enable HAVE_FUNCTION_GRAPH_RETVAL")
redundantly added check on HAVE_FUNCTION_GRAPH_TRACER, while enabling the
config HAVE_FUNCTION_GRAPH_RETVAL. Let's just drop this redundant check.
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org
CC: linux-kernel@vger.kernel.org
Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
---
arch/arm64/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index 79a656a62cbc..cf1781cdc062 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -211,8 +211,8 @@ config ARM64
select HAVE_FTRACE_MCOUNT_RECORD
select HAVE_FUNCTION_TRACER
select HAVE_FUNCTION_ERROR_INJECTION
- select HAVE_FUNCTION_GRAPH_RETVAL if HAVE_FUNCTION_GRAPH_TRACER
select HAVE_FUNCTION_GRAPH_TRACER
+ select HAVE_FUNCTION_GRAPH_RETVAL
select HAVE_GCC_PLUGINS
select HAVE_HARDLOCKUP_DETECTOR_PERF if PERF_EVENTS && \
HW_PERF_EVENTS && HAVE_PERF_EVENTS_NMI
--
2.30.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64/Kconfig: Remove redundant 'if HAVE_FUNCTION_GRAPH_TRACER'
2024-07-16 5:09 [PATCH] arm64/Kconfig: Remove redundant 'if HAVE_FUNCTION_GRAPH_TRACER' Anshuman Khandual
@ 2024-07-16 13:26 ` Mark Rutland
2024-07-23 15:46 ` Will Deacon
1 sibling, 0 replies; 3+ messages in thread
From: Mark Rutland @ 2024-07-16 13:26 UTC (permalink / raw)
To: Anshuman Khandual
Cc: linux-arm-kernel, masahiroy, Catalin Marinas, Will Deacon, linux-kernel
On Tue, Jul 16, 2024 at 10:39:15AM +0530, Anshuman Khandual wrote:
> Since the commit 819e50e25d0c ("arm64: Add ftrace support"),
> HAVE_FUNCTION_GRAPH_TRACER has always been enabled. Although a subsequent
> commit 364697032246 ("arm64: ftrace: Enable HAVE_FUNCTION_GRAPH_RETVAL")
> redundantly added check on HAVE_FUNCTION_GRAPH_TRACER, while enabling the
> config HAVE_FUNCTION_GRAPH_RETVAL. Let's just drop this redundant check.
>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: linux-arm-kernel@lists.infradead.org
> CC: linux-kernel@vger.kernel.org
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Mark.
> ---
> arch/arm64/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 79a656a62cbc..cf1781cdc062 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -211,8 +211,8 @@ config ARM64
> select HAVE_FTRACE_MCOUNT_RECORD
> select HAVE_FUNCTION_TRACER
> select HAVE_FUNCTION_ERROR_INJECTION
> - select HAVE_FUNCTION_GRAPH_RETVAL if HAVE_FUNCTION_GRAPH_TRACER
> select HAVE_FUNCTION_GRAPH_TRACER
> + select HAVE_FUNCTION_GRAPH_RETVAL
> select HAVE_GCC_PLUGINS
> select HAVE_HARDLOCKUP_DETECTOR_PERF if PERF_EVENTS && \
> HW_PERF_EVENTS && HAVE_PERF_EVENTS_NMI
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64/Kconfig: Remove redundant 'if HAVE_FUNCTION_GRAPH_TRACER'
2024-07-16 5:09 [PATCH] arm64/Kconfig: Remove redundant 'if HAVE_FUNCTION_GRAPH_TRACER' Anshuman Khandual
2024-07-16 13:26 ` Mark Rutland
@ 2024-07-23 15:46 ` Will Deacon
1 sibling, 0 replies; 3+ messages in thread
From: Will Deacon @ 2024-07-23 15:46 UTC (permalink / raw)
To: linux-arm-kernel, Anshuman Khandual
Cc: catalin.marinas, kernel-team, Will Deacon, mark.rutland,
masahiroy, linux-kernel
On Tue, 16 Jul 2024 10:39:15 +0530, Anshuman Khandual wrote:
> Since the commit 819e50e25d0c ("arm64: Add ftrace support"),
> HAVE_FUNCTION_GRAPH_TRACER has always been enabled. Although a subsequent
> commit 364697032246 ("arm64: ftrace: Enable HAVE_FUNCTION_GRAPH_RETVAL")
> redundantly added check on HAVE_FUNCTION_GRAPH_TRACER, while enabling the
> config HAVE_FUNCTION_GRAPH_RETVAL. Let's just drop this redundant check.
>
>
> [...]
Applied to arm64 (for-next/core), thanks!
[1/1] arm64/Kconfig: Remove redundant 'if HAVE_FUNCTION_GRAPH_TRACER'
https://git.kernel.org/arm64/c/add6128fc7f0
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-23 15:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-16 5:09 [PATCH] arm64/Kconfig: Remove redundant 'if HAVE_FUNCTION_GRAPH_TRACER' Anshuman Khandual
2024-07-16 13:26 ` Mark Rutland
2024-07-23 15:46 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®