[PATCH 0/3] arm64: dts: imx93-11x11-evk: Add several sound cards

[PATCH 0/3] arm64: dts: imx93-11x11-evk: Add several sound cards

[Shengjiu Wang]

Add bt-sco, PDM microphone, XCVR sound card support.

Shengjiu Wang (3):
  arm64: dts: imx93-11x11-evk: add bt-sco sound card support
  arm64: dts: imx93-11x11-evk: Add PDM microphone sound card support
  arm64: dts: imx93-11x11-evk: Add audio XCVR sound card

 .../boot/dts/freescale/imx93-11x11-evk.dts    | 135 ++++++++++++++++++
 1 file changed, 135 insertions(+)

-- 
2.34.1

[PATCH 1/3] arm64: dts: imx93-11x11-evk: add bt-sco sound card support

[Shengjiu Wang]

Add bt-sco sound card, which is used by BT HFP case.
It supports wb profile as default

Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
---
 .../boot/dts/freescale/imx93-11x11-evk.dts    | 54 +++++++++++++++++++
 1 file changed, 54 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
index a15987f49e8d..7ed75fb287df 100644
--- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
@@ -80,6 +80,30 @@ reg_usdhc2_vmmc: regulator-usdhc2 {
 		off-on-delay-us = <12000>;
 		enable-active-high;
 	};
+
+	bt_sco_codec: bt_sco_codec {
+		#sound-dai-cells = <1>;
+		compatible = "linux,bt-sco";
+	};
+
+	sound-bt-sco {
+		compatible = "simple-audio-card";
+		simple-audio-card,name = "bt-sco-audio";
+		simple-audio-card,format = "dsp_a";
+		simple-audio-card,bitclock-inversion;
+		simple-audio-card,frame-master = <&btcpu>;
+		simple-audio-card,bitclock-master = <&btcpu>;
+
+		btcpu: simple-audio-card,cpu {
+			sound-dai = <&sai1>;
+			dai-tdm-slot-num = <2>;
+			dai-tdm-slot-width = <16>;
+		};
+
+		simple-audio-card,codec {
+			sound-dai = <&bt_sco_codec 1>;
+		};
+	};
 };
 
 &adc1 {
@@ -345,6 +369,18 @@ &mu2 {
 	status = "okay";
 };
 
+&sai1 {
+	#sound-dai-cells = <0>;
+	pinctrl-names = "default", "sleep";
+	pinctrl-0 = <&pinctrl_sai1>;
+	pinctrl-1 = <&pinctrl_sai1_sleep>;
+	assigned-clocks = <&clk IMX93_CLK_SAI1>;
+	assigned-clock-parents = <&clk IMX93_CLK_AUDIO_PLL>;
+	assigned-clock-rates = <12288000>;
+	fsl,sai-mclk-direction-output;
+	status = "okay";
+};
+
 &usbotg1 {
 	dr_mode = "otg";
 	hnp-disable;
@@ -528,6 +564,24 @@ MX93_PAD_CCM_CLKO2__GPIO3_IO27			0x31e
 		>;
 	};
 
+	pinctrl_sai1: sai1grp {
+		fsl,pins = <
+			MX93_PAD_SAI1_TXC__SAI1_TX_BCLK			0x31e
+			MX93_PAD_SAI1_TXFS__SAI1_TX_SYNC		0x31e
+			MX93_PAD_SAI1_TXD0__SAI1_TX_DATA00		0x31e
+			MX93_PAD_SAI1_RXD0__SAI1_RX_DATA00		0x31e
+		>;
+	};
+
+	pinctrl_sai1_sleep: sai1grpsleep {
+		fsl,pins = <
+			MX93_PAD_SAI1_TXC__GPIO1_IO12                   0x51e
+			MX93_PAD_SAI1_TXFS__GPIO1_IO11			0x51e
+			MX93_PAD_SAI1_TXD0__GPIO1_IO13			0x51e
+			MX93_PAD_SAI1_RXD0__GPIO1_IO14			0x51e
+		>;
+	};
+
 	/* need to config the SION for data and cmd pad, refer to ERR052021 */
 	pinctrl_usdhc1: usdhc1grp {
 		fsl,pins = <
-- 
2.34.1

Re: [PATCH 1/3] arm64: dts: imx93-11x11-evk: add bt-sco sound card support

[Krzysztof Kozlowski]

On 25/07/2024 10:59, Shengjiu Wang wrote:
> Add bt-sco sound card, which is used by BT HFP case.
> It supports wb profile as default

<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC (and consider --no-git-fallback argument). It might
happen, that command when run on an older kernel, gives you outdated
entries. Therefore please be sure you base your patches on recent Linux
kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.
</form letter>

> 
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> ---
>  .../boot/dts/freescale/imx93-11x11-evk.dts    | 54 +++++++++++++++++++
>  1 file changed, 54 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> index a15987f49e8d..7ed75fb287df 100644
> --- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> @@ -80,6 +80,30 @@ reg_usdhc2_vmmc: regulator-usdhc2 {
>  		off-on-delay-us = <12000>;
>  		enable-active-high;
>  	};
> +
> +	bt_sco_codec: bt_sco_codec {

No underscores, generic node names. Please follow DTS coding style.

> +		#sound-dai-cells = <1>;

Order properties and nodes according to DTS coding style.

> +		compatible = "linux,bt-sco";
> +	};
> +
> +	sound-bt-sco {

Why this is not "sound"?

How many sound cards do you have there?

> +		compatible = "simple-audio-card";
> +		simple-audio-card,name = "bt-sco-audio";
> +		simple-audio-card,format = "dsp_a";
> +		simple-audio-card,bitclock-inversion;
> +		simple-audio-card,frame-master = <&btcpu>;
> +		simple-audio-card,bitclock-master = <&btcpu>;
> +
> +		btcpu: simple-audio-card,cpu {
> +			sound-dai = <&sai1>;
> +			dai-tdm-slot-num = <2>;
> +			dai-tdm-slot-width = <16>;
> +		};
> +
> +		simple-audio-card,codec {
> +			sound-dai = <&bt_sco_codec 1>;
> +		};
> +	};
>  };
>  
>  &adc1 {
> @@ -345,6 +369,18 @@ &mu2 {
>  	status = "okay";
>  };
>  
> +&sai1 {
> +	#sound-dai-cells = <0>;
> +	pinctrl-names = "default", "sleep";
> +	pinctrl-0 = <&pinctrl_sai1>;
> +	pinctrl-1 = <&pinctrl_sai1_sleep>;
> +	assigned-clocks = <&clk IMX93_CLK_SAI1>;
> +	assigned-clock-parents = <&clk IMX93_CLK_AUDIO_PLL>;
> +	assigned-clock-rates = <12288000>;
> +	fsl,sai-mclk-direction-output;
> +	status = "okay";
> +};
> +
>  &usbotg1 {
>  	dr_mode = "otg";
>  	hnp-disable;
> @@ -528,6 +564,24 @@ MX93_PAD_CCM_CLKO2__GPIO3_IO27			0x31e
>  		>;
>  	};
>  
> +	pinctrl_sai1: sai1grp {
> +		fsl,pins = <
> +			MX93_PAD_SAI1_TXC__SAI1_TX_BCLK			0x31e
> +			MX93_PAD_SAI1_TXFS__SAI1_TX_SYNC		0x31e
> +			MX93_PAD_SAI1_TXD0__SAI1_TX_DATA00		0x31e
> +			MX93_PAD_SAI1_RXD0__SAI1_RX_DATA00		0x31e
> +		>;
> +	};
> +
> +	pinctrl_sai1_sleep: sai1grpsleep {

Does not look like tested. Srsly, NXP, start doing basic tests before
posting your code.

It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).


Best regards,
Krzysztof

Re: [PATCH 1/3] arm64: dts: imx93-11x11-evk: add bt-sco sound card support

[Shengjiu Wang]

On Thu, Jul 25, 2024 at 7:32 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 25/07/2024 10:59, Shengjiu Wang wrote:
> > Add bt-sco sound card, which is used by BT HFP case.
> > It supports wb profile as default
>
> <form letter>
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC (and consider --no-git-fallback argument). It might
> happen, that command when run on an older kernel, gives you outdated
> entries. Therefore please be sure you base your patches on recent Linux
> kernel.
>
> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
> people, so fix your workflow. Tools might also fail if you work on some
> ancient tree (don't, instead use mainline) or work on fork of kernel
> (don't, instead use mainline). Just use b4 and everything should be
> fine, although remember about `b4 prep --auto-to-cc` if you added new
> patches to the patchset.
> </form letter>

Sorry,  I don't get the point. I used the scripts/get_maintainer.pl to get
the list of people.   Anything wrong?

>
> >
> > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> > ---
> >  .../boot/dts/freescale/imx93-11x11-evk.dts    | 54 +++++++++++++++++++
> >  1 file changed, 54 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > index a15987f49e8d..7ed75fb287df 100644
> > --- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > @@ -80,6 +80,30 @@ reg_usdhc2_vmmc: regulator-usdhc2 {
> >               off-on-delay-us = <12000>;
> >               enable-active-high;
> >       };
> > +
> > +     bt_sco_codec: bt_sco_codec {
>
> No underscores, generic node names. Please follow DTS coding style.

Ok, will update it.
>
> > +             #sound-dai-cells = <1>;
>
> Order properties and nodes according to DTS coding style.

ok, will update it.

>
> > +             compatible = "linux,bt-sco";
> > +     };
> > +
> > +     sound-bt-sco {
>
> Why this is not "sound"?
>
> How many sound cards do you have there?

We will have 4 sound cards.

>
> > +             compatible = "simple-audio-card";
> > +             simple-audio-card,name = "bt-sco-audio";
> > +             simple-audio-card,format = "dsp_a";
> > +             simple-audio-card,bitclock-inversion;
> > +             simple-audio-card,frame-master = <&btcpu>;
> > +             simple-audio-card,bitclock-master = <&btcpu>;
> > +
> > +             btcpu: simple-audio-card,cpu {
> > +                     sound-dai = <&sai1>;
> > +                     dai-tdm-slot-num = <2>;
> > +                     dai-tdm-slot-width = <16>;
> > +             };
> > +
> > +             simple-audio-card,codec {
> > +                     sound-dai = <&bt_sco_codec 1>;
> > +             };
> > +     };
> >  };
> >
> >  &adc1 {
> > @@ -345,6 +369,18 @@ &mu2 {
> >       status = "okay";
> >  };
> >
> > +&sai1 {
> > +     #sound-dai-cells = <0>;
> > +     pinctrl-names = "default", "sleep";
> > +     pinctrl-0 = <&pinctrl_sai1>;
> > +     pinctrl-1 = <&pinctrl_sai1_sleep>;
> > +     assigned-clocks = <&clk IMX93_CLK_SAI1>;
> > +     assigned-clock-parents = <&clk IMX93_CLK_AUDIO_PLL>;
> > +     assigned-clock-rates = <12288000>;
> > +     fsl,sai-mclk-direction-output;
> > +     status = "okay";
> > +};
> > +
> >  &usbotg1 {
> >       dr_mode = "otg";
> >       hnp-disable;
> > @@ -528,6 +564,24 @@ MX93_PAD_CCM_CLKO2__GPIO3_IO27                   0x31e
> >               >;
> >       };
> >
> > +     pinctrl_sai1: sai1grp {
> > +             fsl,pins = <
> > +                     MX93_PAD_SAI1_TXC__SAI1_TX_BCLK                 0x31e
> > +                     MX93_PAD_SAI1_TXFS__SAI1_TX_SYNC                0x31e
> > +                     MX93_PAD_SAI1_TXD0__SAI1_TX_DATA00              0x31e
> > +                     MX93_PAD_SAI1_RXD0__SAI1_RX_DATA00              0x31e
> > +             >;
> > +     };
> > +
> > +     pinctrl_sai1_sleep: sai1grpsleep {
>
> Does not look like tested. Srsly, NXP, start doing basic tests before
> posting your code.

Did the test. but maybe my test method is not correct,  will double check.

Best regards
Shengjiu wang
>
> It does not look like you tested the DTS against bindings. Please run
> `make dtbs_check W=1` (see
> Documentation/devicetree/bindings/writing-schema.rst or
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> for instructions).
>
>
> Best regards,
> Krzysztof
>

Re: [PATCH 1/3] arm64: dts: imx93-11x11-evk: add bt-sco sound card support

[Krzysztof Kozlowski]

On 26/07/2024 05:42, Shengjiu Wang wrote:
> On Thu, Jul 25, 2024 at 7:32 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 25/07/2024 10:59, Shengjiu Wang wrote:
>>> Add bt-sco sound card, which is used by BT HFP case.
>>> It supports wb profile as default
>>
>> <form letter>
>> Please use scripts/get_maintainers.pl to get a list of necessary people
>> and lists to CC (and consider --no-git-fallback argument). It might
>> happen, that command when run on an older kernel, gives you outdated
>> entries. Therefore please be sure you base your patches on recent Linux
>> kernel.
>>
>> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
>> people, so fix your workflow. Tools might also fail if you work on some
>> ancient tree (don't, instead use mainline) or work on fork of kernel
>> (don't, instead use mainline). Just use b4 and everything should be
>> fine, although remember about `b4 prep --auto-to-cc` if you added new
>> patches to the patchset.
>> </form letter>
> 
> Sorry,  I don't get the point. I used the scripts/get_maintainer.pl to get
> the list of people.   Anything wrong?

Read the message, carefully. If you used get_maintainer.pl, then:
"YOU WORK ON SOME ANCIENT TREE"

I think I was pretty clear in above form letter, unless you just want to
ping pack to me so I will waste more time to explain why you cc wrong
addresses...

Best regards,
Krzysztof

[PATCH 2/3] arm64: dts: imx93-11x11-evk: Add PDM microphone sound card support

[Shengjiu Wang]

Add PDM micphone sound card support, configure the pinmux.

This sound card supports recording sound from PDM microphone
and convert the PDM format data to PCM data.

Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
---
 .../boot/dts/freescale/imx93-11x11-evk.dts    | 41 +++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
index 7ed75fb287df..7ad65469625f 100644
--- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
@@ -104,6 +104,20 @@ simple-audio-card,codec {
 			sound-dai = <&bt_sco_codec 1>;
 		};
 	};
+
+	sound-micfil {
+		compatible = "fsl,imx-audio-card";
+		model = "micfil-audio";
+
+		pri-dai-link {
+			link-name = "micfil hifi";
+			format = "i2s";
+
+			cpu {
+				sound-dai = <&micfil>;
+			};
+		};
+	};
 };
 
 &adc1 {
@@ -361,6 +375,17 @@ &lpuart5 {
 	status = "okay";
 };
 
+&micfil {
+	#sound-dai-cells = <0>;
+	pinctrl-names = "default", "sleep";
+	pinctrl-0 = <&pinctrl_pdm>;
+	pinctrl-1 = <&pinctrl_pdm_sleep>;
+	assigned-clocks = <&clk IMX93_CLK_PDM>;
+	assigned-clock-parents = <&clk IMX93_CLK_AUDIO_PLL>;
+	assigned-clock-rates = <49152000>;
+	status = "okay";
+};
+
 &mu1 {
 	status = "okay";
 };
@@ -564,6 +589,22 @@ MX93_PAD_CCM_CLKO2__GPIO3_IO27			0x31e
 		>;
 	};
 
+	pinctrl_pdm: pdmgrp {
+		fsl,pins = <
+			MX93_PAD_PDM_CLK__PDM_CLK			0x31e
+			MX93_PAD_PDM_BIT_STREAM0__PDM_BIT_STREAM00	0x31e
+			MX93_PAD_PDM_BIT_STREAM1__PDM_BIT_STREAM01	0x31e
+		>;
+	};
+
+	pinctrl_pdm_sleep: pdmgrpsleep {
+		fsl,pins = <
+			MX93_PAD_PDM_CLK__GPIO1_IO08			0x31e
+			MX93_PAD_PDM_BIT_STREAM0__GPIO1_IO09		0x31e
+			MX93_PAD_PDM_BIT_STREAM1__GPIO1_IO10		0x31e
+		>;
+	};
+
 	pinctrl_sai1: sai1grp {
 		fsl,pins = <
 			MX93_PAD_SAI1_TXC__SAI1_TX_BCLK			0x31e
-- 
2.34.1

[PATCH 3/3] arm64: dts: imx93-11x11-evk: Add audio XCVR sound card

[Shengjiu Wang]

Add audio XCVR sound card, which supports SPDIF TX & RX only,
eARC RX, ARC RX are not supported.

Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
---
 .../boot/dts/freescale/imx93-11x11-evk.dts    | 40 +++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
index 7ad65469625f..0bf826fa8c11 100644
--- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
@@ -118,6 +118,19 @@ cpu {
 			};
 		};
 	};
+
+	sound-xcvr {
+		compatible = "fsl,imx-audio-card";
+		model = "imx-audio-xcvr";
+
+		pri-dai-link {
+			link-name = "XCVR PCM";
+
+			cpu {
+				sound-dai = <&xcvr>;
+			};
+		};
+	};
 };
 
 &adc1 {
@@ -469,6 +482,19 @@ &wdog3 {
 	status = "okay";
 };
 
+&xcvr {
+	#sound-dai-cells = <0>;
+	pinctrl-names = "default", "sleep";
+	pinctrl-0 = <&pinctrl_spdif>;
+	pinctrl-1 = <&pinctrl_spdif_sleep>;
+	assigned-clocks = <&clk IMX93_CLK_SPDIF>,
+			 <&clk IMX93_CLK_AUDIO_XCVR>;
+	assigned-clock-parents = <&clk IMX93_CLK_AUDIO_PLL>,
+			 <&clk IMX93_CLK_SYS_PLL_PFD1_DIV2>;
+	assigned-clock-rates = <12288000>, <200000000>;
+	status = "okay";
+};
+
 &iomuxc {
 	pinctrl_eqos: eqosgrp {
 		fsl,pins = <
@@ -680,6 +706,20 @@ MX93_PAD_SD2_RESET_B__GPIO3_IO07	0x31e
 		>;
 	};
 
+	pinctrl_spdif: spdifgrp {
+		fsl,pins = <
+			MX93_PAD_GPIO_IO22__SPDIF_IN		0x31e
+			MX93_PAD_GPIO_IO23__SPDIF_OUT		0x31e
+		>;
+	};
+
+	pinctrl_spdif_sleep: spdifgrpsleep {
+		fsl,pins = <
+			MX93_PAD_GPIO_IO22__GPIO2_IO22		0x31e
+			MX93_PAD_GPIO_IO23__GPIO2_IO23		0x31e
+		>;
+	};
+
 	pinctrl_usdhc2_gpio: usdhc2gpiogrp {
 		fsl,pins = <
 			MX93_PAD_SD2_CD_B__GPIO3_IO00		0x31e
-- 
2.34.1

Re: [PATCH 3/3] arm64: dts: imx93-11x11-evk: Add audio XCVR sound card

[Krzysztof Kozlowski]

On 25/07/2024 10:59, Shengjiu Wang wrote:
> Add audio XCVR sound card, which supports SPDIF TX & RX only,
> eARC RX, ARC RX are not supported.
> 
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> ---
>  .../boot/dts/freescale/imx93-11x11-evk.dts    | 40 +++++++++++++++++++
>  1 file changed, 40 insertions(+)


>  };
>  
>  &adc1 {
> @@ -469,6 +482,19 @@ &wdog3 {
>  	status = "okay";
>  };
>  
> +&xcvr {
> +	#sound-dai-cells = <0>;

Why this is not a property of the SoC? This applies to other patches as
well.

Best regards,
Krzysztof

Re: [PATCH 3/3] arm64: dts: imx93-11x11-evk: Add audio XCVR sound card

[Shengjiu Wang]

On Thu, Jul 25, 2024 at 7:33 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 25/07/2024 10:59, Shengjiu Wang wrote:
> > Add audio XCVR sound card, which supports SPDIF TX & RX only,
> > eARC RX, ARC RX are not supported.
> >
> > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> > ---
> >  .../boot/dts/freescale/imx93-11x11-evk.dts    | 40 +++++++++++++++++++
> >  1 file changed, 40 insertions(+)
>
>
> >  };
> >
> >  &adc1 {
> > @@ -469,6 +482,19 @@ &wdog3 {
> >       status = "okay";
> >  };
> >
> > +&xcvr {
> > +     #sound-dai-cells = <0>;
>
> Why this is not a property of the SoC? This applies to other patches as
> well.

I think you mean it need to move to imx93.dtsi.
Ok, will do it.

best regards
Shengjiu Wang
>
> Best regards,
> Krzysztof
>

Re: [PATCH 0/3] arm64: dts: imx93-11x11-evk: Add several sound cards

[Rob Herring (Arm)]

On Thu, 25 Jul 2024 16:59:05 +0800, Shengjiu Wang wrote:
> Add bt-sco, PDM microphone, XCVR sound card support.
> 
> Shengjiu Wang (3):
>   arm64: dts: imx93-11x11-evk: add bt-sco sound card support
>   arm64: dts: imx93-11x11-evk: Add PDM microphone sound card support
>   arm64: dts: imx93-11x11-evk: Add audio XCVR sound card
> 
>  .../boot/dts/freescale/imx93-11x11-evk.dts    | 135 ++++++++++++++++++
>  1 file changed, 135 insertions(+)
> 
> --
> 2.34.1
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y freescale/imx93-11x11-evk.dtb' for 1721897948-6306-1-git-send-email-shengjiu.wang@nxp.com:

arch/arm64/boot/dts/freescale/imx93-11x11-evk.dtb: pinctrl@443c0000: 'pdmgrpsleep', 'sai1grpsleep', 'spdifgrpsleep' do not match any of the regexes: 'grp$', 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/pinctrl/fsl,imx9-pinctrl.yaml#

Re: [PATCH 0/3] arm64: dts: imx93-11x11-evk: Add several sound cards

[Krzysztof Kozlowski]

On 26/07/2024 00:20, Rob Herring (Arm) wrote:
> 
> On Thu, 25 Jul 2024 16:59:05 +0800, Shengjiu Wang wrote:
>> Add bt-sco, PDM microphone, XCVR sound card support.
>>
>> Shengjiu Wang (3):
>>   arm64: dts: imx93-11x11-evk: add bt-sco sound card support
>>   arm64: dts: imx93-11x11-evk: Add PDM microphone sound card support
>>   arm64: dts: imx93-11x11-evk: Add audio XCVR sound card
>>
>>  .../boot/dts/freescale/imx93-11x11-evk.dts    | 135 ++++++++++++++++++
>>  1 file changed, 135 insertions(+)
>>
>> --
>> 2.34.1
>>
>>
>>
> 
> 
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
> 
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
> 
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
> 
>   pip3 install dtschema --upgrade
> 
> 
> New warnings running 'make CHECK_DTBS=y freescale/imx93-11x11-evk.dtb' for 1721897948-6306-1-git-send-email-shengjiu.wang@nxp.com:
> 
> arch/arm64/boot/dts/freescale/imx93-11x11-evk.dtb: pinctrl@443c0000: 'pdmgrpsleep', 'sai1grpsleep', 'spdifgrpsleep' do not match any of the regexes: 'grp$', 'pinctrl-[0-9]+'

And that's a proof that you did not test it.

Is anyone in NXP testing patches before sending?

Best regards,
Krzysztof