* [tip: irq/core] irqchip/armada-370-xp: Use unsigned int type for virqs
[not found] <20240711115748.30268-3-kabel@kernel.org>
@ 2024-07-29 9:49 ` tip-bot2 for Marek Behún
2024-07-30 11:40 ` tip-bot2 for Marek Behún
1 sibling, 0 replies; 2+ messages in thread
From: tip-bot2 for Marek Behún @ 2024-07-29 9:49 UTC (permalink / raw)
To: linux-tip-commits
Cc: kabel, Thomas Gleixner, Andrew Lunn, ilpo.jarvinen, x86,
linux-kernel, maz
The following commit has been merged into the irq/core branch of tip:
Commit-ID: 661c797ad537b8097893ebc98f4995934766e423
Gitweb: https://git.kernel.org/tip/661c797ad537b8097893ebc98f4995934766e423
Author: Marek Behún <kabel@kernel.org>
AuthorDate: Thu, 11 Jul 2024 13:57:40 +02:00
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Mon, 29 Jul 2024 10:57:22 +02:00
irqchip/armada-370-xp: Use unsigned int type for virqs
The return type of irq_find_mapping() and irq_linear_revmap() is
unsigned int. Use the unsigned int type for the variables storing the
return value.
Signed-off-by: Marek Behún <kabel@kernel.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/all/20240711115748.30268-3-kabel@kernel.org
---
drivers/irqchip/irq-armada-370-xp.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/irqchip/irq-armada-370-xp.c b/drivers/irqchip/irq-armada-370-xp.c
index 7016b20..b29f3bb 100644
--- a/drivers/irqchip/irq-armada-370-xp.c
+++ b/drivers/irqchip/irq-armada-370-xp.c
@@ -462,10 +462,10 @@ static const struct irq_domain_ops ipi_domain_ops = {
static void ipi_resume(void)
{
for (int i = 0; i < IPI_DOORBELL_END; i++) {
- int virq;
+ unsigned int virq;
virq = irq_find_mapping(ipi_domain, i);
- if (virq <= 0)
+ if (!virq)
continue;
if (irq_percpu_is_enabled(virq)) {
struct irq_data *d;
@@ -539,7 +539,7 @@ static void armada_xp_mpic_reenable_percpu(void)
/* Re-enable per-CPU interrupts that were enabled before suspend */
for (unsigned int irq = 0; irq < MPIC_MAX_PER_CPU_IRQS; irq++) {
struct irq_data *data;
- int virq;
+ unsigned int virq;
virq = irq_linear_revmap(armada_370_xp_mpic_domain, irq);
if (virq == 0)
@@ -734,7 +734,7 @@ static void armada_370_xp_mpic_resume(void)
nirqs = (readl(main_int_base + MPIC_INT_CONTROL) >> 2) & 0x3ff;
for (irq_hw_number_t irq = 0; irq < nirqs; irq++) {
struct irq_data *data;
- int virq;
+ unsigned int virq;
virq = irq_linear_revmap(armada_370_xp_mpic_domain, irq);
if (virq == 0)
^ permalink raw reply [flat|nested] 2+ messages in thread* [tip: irq/core] irqchip/armada-370-xp: Use unsigned int type for virqs
[not found] <20240711115748.30268-3-kabel@kernel.org>
2024-07-29 9:49 ` [tip: irq/core] irqchip/armada-370-xp: Use unsigned int type for virqs tip-bot2 for Marek Behún
@ 2024-07-30 11:40 ` tip-bot2 for Marek Behún
1 sibling, 0 replies; 2+ messages in thread
From: tip-bot2 for Marek Behún @ 2024-07-30 11:40 UTC (permalink / raw)
To: linux-tip-commits
Cc: kabel, Thomas Gleixner, Andrew Lunn, ilpo.jarvinen, x86,
linux-kernel, maz
The following commit has been merged into the irq/core branch of tip:
Commit-ID: e4cd7c553a00e2904689cac543e314b1962c6a8e
Gitweb: https://git.kernel.org/tip/e4cd7c553a00e2904689cac543e314b1962c6a8e
Author: Marek Behún <kabel@kernel.org>
AuthorDate: Thu, 11 Jul 2024 13:57:40 +02:00
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Tue, 30 Jul 2024 13:35:46 +02:00
irqchip/armada-370-xp: Use unsigned int type for virqs
The return type of irq_find_mapping() and irq_linear_revmap() is
unsigned int. Use the unsigned int type for the variables storing the
return value.
Signed-off-by: Marek Behún <kabel@kernel.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/all/20240711115748.30268-3-kabel@kernel.org
---
drivers/irqchip/irq-armada-370-xp.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/irqchip/irq-armada-370-xp.c b/drivers/irqchip/irq-armada-370-xp.c
index 7016b20..b29f3bb 100644
--- a/drivers/irqchip/irq-armada-370-xp.c
+++ b/drivers/irqchip/irq-armada-370-xp.c
@@ -462,10 +462,10 @@ static const struct irq_domain_ops ipi_domain_ops = {
static void ipi_resume(void)
{
for (int i = 0; i < IPI_DOORBELL_END; i++) {
- int virq;
+ unsigned int virq;
virq = irq_find_mapping(ipi_domain, i);
- if (virq <= 0)
+ if (!virq)
continue;
if (irq_percpu_is_enabled(virq)) {
struct irq_data *d;
@@ -539,7 +539,7 @@ static void armada_xp_mpic_reenable_percpu(void)
/* Re-enable per-CPU interrupts that were enabled before suspend */
for (unsigned int irq = 0; irq < MPIC_MAX_PER_CPU_IRQS; irq++) {
struct irq_data *data;
- int virq;
+ unsigned int virq;
virq = irq_linear_revmap(armada_370_xp_mpic_domain, irq);
if (virq == 0)
@@ -734,7 +734,7 @@ static void armada_370_xp_mpic_resume(void)
nirqs = (readl(main_int_base + MPIC_INT_CONTROL) >> 2) & 0x3ff;
for (irq_hw_number_t irq = 0; irq < nirqs; irq++) {
struct irq_data *data;
- int virq;
+ unsigned int virq;
virq = irq_linear_revmap(armada_370_xp_mpic_domain, irq);
if (virq == 0)
^ permalink raw reply [flat|nested] 2+ messages in thread