mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "tip-bot2 for Yang Yingliang" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: stable@kernel.org, Yang Yingliang <yangyingliang@huawei.com>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: sched/core] sched/core: Fix unbalance set_rq_online/offline() in sched_cpu_deactivate()
Date: Mon, 29 Jul 2024 10:34:08 -0000	[thread overview]
Message-ID: <172224924844.2215.10671969655043849003.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20240703031610.587047-5-yangyingliang@huaweicloud.com>

The following commit has been merged into the sched/core branch of tip:

Commit-ID:     fe7a11c78d2a9bdb8b50afc278a31ac177000948
Gitweb:        https://git.kernel.org/tip/fe7a11c78d2a9bdb8b50afc278a31ac177000948
Author:        Yang Yingliang <yangyingliang@huawei.com>
AuthorDate:    Wed, 03 Jul 2024 11:16:10 +08:00
Committer:     Peter Zijlstra <peterz@infradead.org>
CommitterDate: Mon, 29 Jul 2024 12:22:33 +02:00

sched/core: Fix unbalance set_rq_online/offline() in sched_cpu_deactivate()

If cpuset_cpu_inactive() fails, set_rq_online() need be called to rollback.

Fixes: 120455c514f7 ("sched: Fix hotplug vs CPU bandwidth control")
Cc: stable@kernel.org
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/r/20240703031610.587047-5-yangyingliang@huaweicloud.com
---
 kernel/sched/core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 4d119e9..f3951e4 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -8022,6 +8022,7 @@ int sched_cpu_deactivate(unsigned int cpu)
 	ret = cpuset_cpu_inactive(cpu);
 	if (ret) {
 		sched_smt_present_inc(cpu);
+		sched_set_rq_online(rq, cpu);
 		balance_push_set(cpu, false);
 		set_cpu_active(cpu, true);
 		sched_update_numa(cpu, true);

  reply	other threads:[~2024-07-29 10:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-03  3:16 [PATCH 0/4] sched/smt: Fix error handling " Yang Yingliang
2024-07-03  3:16 ` [PATCH 1/4] sched/smt: Introduce sched_smt_present_inc/dec() helper Yang Yingliang
2024-07-29 10:34   ` [tip: sched/core] " tip-bot2 for Yang Yingliang
2024-07-03  3:16 ` [PATCH 2/4] sched/smt: fix unbalance sched_smt_present dec/inc Yang Yingliang
2024-07-29 10:34   ` [tip: sched/core] sched/smt: Fix " tip-bot2 for Yang Yingliang
2024-07-03  3:16 ` [PATCH 3/4] sched/core: Introduce sched_set_rq_on/offline() helper Yang Yingliang
2024-07-16 13:22   ` Markus Elfring
2024-07-29 10:34   ` [tip: sched/core] " tip-bot2 for Yang Yingliang
2024-07-03  3:16 ` [PATCH 4/4] sched/core: fix unbalance set_rq_online/offline() in sched_cpu_deactivate() Yang Yingliang
2024-07-29 10:34   ` tip-bot2 for Yang Yingliang [this message]
2024-07-16  9:54 ` [PATCH 0/4] sched/smt: Fix error handling " Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=172224924844.2215.10671969655043849003.tip-bot2@tip-bot2 \
    --to=tip-bot2@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=stable@kernel.org \
    --cc=x86@kernel.org \
    --cc=yangyingliang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®