From: Markus Elfring <Markus.Elfring@web.de>
To: Yang Yingliang <yangyingliang@huawei.com>,
kernel-janitors@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Ben Segall <bsegall@google.com>, Chen Yu <yu.c.chen@intel.com>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>, Mel Gorman <mgorman@suse.de>,
Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Tim Chen <tim.c.chen@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Valentin Schneider <vschneid@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Wei Li <liwei391@huawei.com>
Subject: Re: [PATCH 3/4] sched/core: Introduce sched_set_rq_on/offline() helper
Date: Tue, 16 Jul 2024 15:22:59 +0200 [thread overview]
Message-ID: <17ac3b59-b189-41d9-b88d-268d7202dde2@web.de> (raw)
In-Reply-To: <20240703031610.587047-4-yangyingliang@huaweicloud.com>
> Introduce sched_set_rq_on/offline() helper, so it can be called
> in normal or error path simply. No functional changed.
Would you like to improve such a change description another bit?
…
> +++ b/kernel/sched/core.c
> @@ -9604,6 +9604,30 @@ void set_rq_offline(struct rq *rq)
…
> +static inline void sched_set_rq_online(struct rq *rq, int cpu)
> +{
…
> + rq_lock_irqsave(rq, &rf);
> + if (rq->rd) {
…
> + }
> + rq_unlock_irqrestore(rq, &rf);
> +}
…
Under which circumstances would you become interested to apply a statement
like “guard(rq_lock_irqsave)(rq);”?
https://elixir.bootlin.com/linux/v6.10/source/kernel/sched/sched.h#L1741
Regards,
Markusbsegall@google.com
next prev parent reply other threads:[~2024-07-16 13:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 3:16 [PATCH 0/4] sched/smt: Fix error handling in sched_cpu_deactivate() Yang Yingliang
2024-07-03 3:16 ` [PATCH 1/4] sched/smt: Introduce sched_smt_present_inc/dec() helper Yang Yingliang
2024-07-29 10:34 ` [tip: sched/core] " tip-bot2 for Yang Yingliang
2024-07-03 3:16 ` [PATCH 2/4] sched/smt: fix unbalance sched_smt_present dec/inc Yang Yingliang
2024-07-29 10:34 ` [tip: sched/core] sched/smt: Fix " tip-bot2 for Yang Yingliang
2024-07-03 3:16 ` [PATCH 3/4] sched/core: Introduce sched_set_rq_on/offline() helper Yang Yingliang
2024-07-16 13:22 ` Markus Elfring [this message]
2024-07-29 10:34 ` [tip: sched/core] " tip-bot2 for Yang Yingliang
2024-07-03 3:16 ` [PATCH 4/4] sched/core: fix unbalance set_rq_online/offline() in sched_cpu_deactivate() Yang Yingliang
2024-07-29 10:34 ` [tip: sched/core] sched/core: Fix " tip-bot2 for Yang Yingliang
2024-07-16 9:54 ` [PATCH 0/4] sched/smt: Fix error handling " Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17ac3b59-b189-41d9-b88d-268d7202dde2@web.de \
--to=markus.elfring@web.de \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liwei391@huawei.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=yangyingliang@huawei.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®