mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: zhenghaowei@loongson.cn
Cc: kernel@xen0n.name, krzk+dt@kernel.org,
	linux-kernel@vger.kernel.org,  linux-serial@vger.kernel.org,
	gregkh@linuxfoundation.org,  devicetree@vger.kernel.org,
	p.zabel@pengutronix.de,  loongarch@lists.linux.dev,
	conor+dt@kernel.org, chenhuacai@kernel.org,
	 jirislaby@kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: serial: Add Loongson UART controller
Date: Sun, 04 Aug 2024 01:23:41 -0600	[thread overview]
Message-ID: <172275622121.3211162.12520346466286897443.robh@kernel.org> (raw)
In-Reply-To: <20240804063834.70022-1-zhenghaowei@loongson.cn>


On Sun, 04 Aug 2024 14:38:32 +0800, zhenghaowei@loongson.cn wrote:
> From: Haowei Zheng <zhenghaowei@loongson.cn>
> 
> Add Loongson UART controller binding with DT schema format using
> json-schema.
> 
> Signed-off-by: Haowei Zheng <zhenghaowei@loongson.cn>
> ---
>  .../bindings/serial/loongson,ls7a-uart.yaml   | 74 +++++++++++++++++++
>  MAINTAINERS                                   |  7 ++
>  2 files changed, 81 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/serial/loongson,ls7a-uart.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/serial/loongson,ls7a-uart.yaml: fractional-division: missing type definition
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/serial/loongson,ls7a-uart.yaml: rts-invert: missing type definition
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/serial/loongson,ls7a-uart.yaml: dtr-invert: missing type definition
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/serial/loongson,ls7a-uart.yaml: cts-invert: missing type definition
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/serial/loongson,ls7a-uart.yaml: dsr-invert: missing type definition
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/serial/loongson,ls7a-uart.example.dtb: serial@1fe001e0: reg: [[0, 534774240], [0, 16]] is too long
	from schema $id: http://devicetree.org/schemas/loongson,ls7a-uart.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/serial/loongson,ls7a-uart.example.dtb: serial@1fe001e0: 'clocks' is a required property
	from schema $id: http://devicetree.org/schemas/loongson,ls7a-uart.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/serial/loongson,ls7a-uart.example.dtb: serial@1fe001e0: Unevaluated properties are not allowed ('clock-frequency', 'reg' were unexpected)
	from schema $id: http://devicetree.org/schemas/loongson,ls7a-uart.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240804063834.70022-1-zhenghaowei@loongson.cn

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  parent reply	other threads:[~2024-08-04  7:23 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-04  6:38 zhenghaowei
2024-08-04  6:38 ` [PATCH v2 2/3] tty: serial: 8250: Add loongson uart driver support zhenghaowei
2024-08-04  7:13   ` Christophe JAILLET
2024-08-04 15:11   ` kernel test robot
2024-08-04 15:33   ` Krzysztof Kozlowski
2024-08-07  8:24     ` 郑豪威
2024-08-09  5:57       ` Krzysztof Kozlowski
2024-08-04 16:42   ` kernel test robot
2024-08-04  6:38 ` [PATCH v2 3/3] LoongArch: dts: Update UART driver to Loongson-2K0500, Loongson-2K1000 and Loongson-2K2000 zhenghaowei
2024-08-04  8:40   ` Krzysztof Kozlowski
2024-08-07  8:23     ` 郑豪威
2024-08-04  7:23 ` Rob Herring (Arm) [this message]
2024-08-04  8:41 ` [PATCH v2 1/3] dt-bindings: serial: Add Loongson UART controller Krzysztof Kozlowski
2024-08-07  8:23   ` 郑豪威
2024-08-04  8:43 ` Krzysztof Kozlowski
2024-08-07  8:23   ` 郑豪威
2024-08-07  8:39     ` Xi Ruoyao
2024-08-07  9:01       ` 郑豪威
2024-08-09  5:53     ` Krzysztof Kozlowski
2024-08-09  9:55       ` 郑豪威
2024-08-09 10:05         ` Krzysztof Kozlowski
2024-08-12  8:09           ` 郑豪威
2024-08-12  8:25             ` Krzysztof Kozlowski
2024-08-25  3:34               ` 郑豪威
2024-08-25  6:55                 ` Krzysztof Kozlowski
2024-08-25  8:24                   ` 郑豪威

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=172275622121.3211162.12520346466286897443.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=chenhuacai@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=kernel@xen0n.name \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=loongarch@lists.linux.dev \
    --cc=p.zabel@pengutronix.de \
    --cc=zhenghaowei@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®