From: 郑豪威 <zhenghaowei@loongson.cn>
To: Krzysztof Kozlowski <krzk@kernel.org>,
gregkh@linuxfoundation.org, jirislaby@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
chenhuacai@kernel.org, kernel@xen0n.name, p.zabel@pengutronix.de,
zhuyinbo <zhuyinbo@loongson.cn>,
Jianmin Lv <lvjianmin@loongson.cn>,
wanghongliang <wanghongliang@loongson.cn>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, loongarch@lists.linux.dev
Subject: Re: [PATCH v2 1/3] dt-bindings: serial: Add Loongson UART controller
Date: Sun, 25 Aug 2024 16:24:52 +0800 [thread overview]
Message-ID: <a4faba2b-061a-44e9-b5c0-ea06c65764a2@loongson.cn> (raw)
In-Reply-To: <efb7bba5-b19c-49f5-8ff5-214ce070015d@kernel.org>
在 2024/8/25 14:55, Krzysztof Kozlowski 写道:
> On 25/08/2024 05:34, 郑豪威 wrote:
>> 在 2024/8/12 16:25, Krzysztof Kozlowski 写道:
>>> On 12/08/2024 10:09, 郑豪威 wrote:
>>>> 在 2024/8/9 18:05, Krzysztof Kozlowski 写道:
>>>>> On 09/08/2024 11:55, 郑豪威 wrote:
>>>>>>>>>> + description: Enables fractional-N division. Currently,
>>>>>>>>>> + only LS2K1500 and LS2K2000 support this feature.
>>>>>>>>>> +
>>>>>>>>>> + rts-invert:
>>>>>>>>>> + description: Inverts the RTS value in the MCR register.
>>>>>>>>>> + This should be used on Loongson-3 series CPUs, Loongson-2K
>>>>>>>>>> + series CPUs, and Loongson LS7A bridge chips.
>>>>>>>>>> +
>>>>>>>>>> + dtr-invert:
>>>>>>>>>> + description: Inverts the DTR value in the MCR register.
>>>>>>>>>> + This should be used on Loongson-3 series CPUs, Loongson-2K
>>>>>>>>>> + series CPUs, and Loongson LS7A bridge chips.
>>>>>>>>>> +
>>>>>>>>>> + cts-invert:
>>>>>>>>>> + description: Inverts the CTS value in the MSR register.
>>>>>>>>>> + This should be used on Loongson-2K0500, Loongson-2K1000,
>>>>>>>>>> + and Loongson LS7A bridge chips.
>>>>>>>>>> +
>>>>>>>>>> + dsr-invert:
>>>>>>>>>> + description: Inverts the DSR value in the MSR register.
>>>>>>>>>> + This should be used on Loongson-2K0500, Loongson-2K1000,
>>>>>>>>>> + and Loongson LS7A bridge chips.
>>>>>>> Same questions for all these. Why choosing invert is a board level
>>>>>>> decision? If it "should be used" then why it is not used always?
>>>>>>>
>>>>>> Because these features are not applicable to all chips, such as
>>>>>> 'fractional-division',
>>>>> Hm?
>>>>>
>>>>>> which is currently supported only by 2K1500 and 2K2000, and for
>>>>>> Loongson-3 series
>>>>> These are SoCs. Compatible defines that. Please align with your
>>>>> colleagues, because *we talked about this* already.
>>>>>
>>>>> Best regards,
>>>>> Krzysztof
>>>> I consulted with my colleagues and would like to confirm with you. For
>>>> the five
>>>>
>>>> properties provided, fractional-division is offered as a new feature,
>>>> supported by
>>>>
>>>> 2K1500 and 2K2000. As for the invert property, it is due to a bug in our
>>>> controller,
>>>>
>>>> and its usage may vary across different chips. Should we add different
>>>> compatible
>>>>
>>>> values to address these issues for different chips, whether they are new
>>>> features or
>>>>
>>>> controller bugs?
>>> How did you align? We had already talks with you about this problem -
>>> you need specific compatibles. How you explain above properties, all of
>>> them are deducible from the compatible, so drop them.
>>>
>>> Your entire argument above does not address at all my concerns, so
>>> before you respond repeating the same, really talk with your colleagues.
>>>
>>> One of many previous discussions:
>>> https://lore.kernel.org/linux-devicetree/25c30964-6bd3-c7eb-640a-ba1f513b7675@linaro.org/
>>>
>>> https://lore.kernel.org/linux-devicetree/20230526-dolly-reheat-06c4d5658415@wendy/
>>>
>>> I wish we do not have to keep repeating the same to Loongson. Please
>>> STORE the feedback for any future submissions, so you will not repeat
>>> the same mistakes over and over.
>>>
>>> Best regards,
>>> Krzysztof
>> Hi:
>>
>> I have been aligning with my colleagues over the past few days and
>>
>> reviewing previous discussions. Based on these, I have made the
>>
>> following modifications according to the differences in the controller:
>>
>> +properties:
>> + compatible:
>> + oneOf:
>> + - enum:
>> + - loongson,ls7a-uart
>> + - loongson,ls3a5000-uart
>> + - loongson,ls2k2000-uart
>> + - items:
>> + - enum:
>> + - loongson,ls2k1000-uart
>> + - loongson,ls2k0500-uart
>> + - const: loongson,ls7a-uart
>> + - items:
>> + - enum:
>> + - loongson,ls2k1500-uart
>> + - const: loongson,ls2k2000-uart
>> + - items:
>> + - enum:
>> + - loongson,ls3a6000-uart
>> + - const: loongson,ls3a5000-uart
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + interrupts:
>> + maxItems: 1
>> +
>> + clock-frequency: true
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - interrupts
>> + - clock-frequency
>> +
>> +allOf:
>> + - $ref: serial.yaml
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/interrupt-controller/irq.h>
>> + #include <dt-bindings/clock/loongson,ls2k-clk.h>
>> +
>> + serial@1fe20000 {
>> + compatible = "loongson,ls2k1000-uart", "loongson,ls7a-uart";
>> + reg = <0x1fe20000 0x10>;
>> + clock-frequency = <125000000>;
>> + interrupt-parent = <&liointc0>;
>> + interrupts = <0x0 IRQ_TYPE_LEVEL_HIGH>;
>> + };
>>
>> Does this modification meet the expectation?
> Yes, assuming ls7a is a specific SoC, not a family of SoC.
>
> Best regards,
> Krzysztof
I got it, thank you for your reply. I will update the discussion
content in the next version.
Best regards,
Haowei Zheng
prev parent reply other threads:[~2024-08-25 8:24 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-04 6:38 zhenghaowei
2024-08-04 6:38 ` [PATCH v2 2/3] tty: serial: 8250: Add loongson uart driver support zhenghaowei
2024-08-04 7:13 ` Christophe JAILLET
2024-08-04 15:11 ` kernel test robot
2024-08-04 15:33 ` Krzysztof Kozlowski
2024-08-07 8:24 ` 郑豪威
2024-08-09 5:57 ` Krzysztof Kozlowski
2024-08-04 16:42 ` kernel test robot
2024-08-04 6:38 ` [PATCH v2 3/3] LoongArch: dts: Update UART driver to Loongson-2K0500, Loongson-2K1000 and Loongson-2K2000 zhenghaowei
2024-08-04 8:40 ` Krzysztof Kozlowski
2024-08-07 8:23 ` 郑豪威
2024-08-04 7:23 ` [PATCH v2 1/3] dt-bindings: serial: Add Loongson UART controller Rob Herring (Arm)
2024-08-04 8:41 ` Krzysztof Kozlowski
2024-08-07 8:23 ` 郑豪威
2024-08-04 8:43 ` Krzysztof Kozlowski
2024-08-07 8:23 ` 郑豪威
2024-08-07 8:39 ` Xi Ruoyao
2024-08-07 9:01 ` 郑豪威
2024-08-09 5:53 ` Krzysztof Kozlowski
2024-08-09 9:55 ` 郑豪威
2024-08-09 10:05 ` Krzysztof Kozlowski
2024-08-12 8:09 ` 郑豪威
2024-08-12 8:25 ` Krzysztof Kozlowski
2024-08-25 3:34 ` 郑豪威
2024-08-25 6:55 ` Krzysztof Kozlowski
2024-08-25 8:24 ` 郑豪威 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4faba2b-061a-44e9-b5c0-ea06c65764a2@loongson.cn \
--to=zhenghaowei@loongson.cn \
--cc=chenhuacai@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kernel@xen0n.name \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=lvjianmin@loongson.cn \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=wanghongliang@loongson.cn \
--cc=zhuyinbo@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®