Re: [PATCH v3] binfmt_elf: Dump smaller VMAs first in ELF cores

[Kees Cook <kees@kernel.org>]

On Tue, 06 Aug 2024 18:16:02 +0000, Brian Mak wrote:
> Large cores may be truncated in some scenarios, such as with daemons
> with stop timeouts that are not large enough or lack of disk space. This
> impacts debuggability with large core dumps since critical information
> necessary to form a usable backtrace, such as stacks and shared library
> information, are omitted.
> 
> We attempted to figure out which VMAs are needed to create a useful
> backtrace, and it turned out to be a non-trivial problem. Instead, we
> try simply sorting the VMAs by size, which has the intended effect.
> 
> [...]

While waiting on rr test validation, and since we're at the start of the
dev cycle, I figure let's get this into -next ASAP to see if anything
else pops out. We can drop/revise if there are problems. (And as always,
I will add any Acks/Reviews/etc that show up on the thread.)

Applied to for-next/execve, thanks!

[1/1] binfmt_elf: Dump smaller VMAs first in ELF cores
      https://git.kernel.org/kees/c/9c531dfdc1bc

Take care,

-- 
Kees Cook