* [PATCH] net: fec: Stop PPS on driver remove
@ 2024-08-05 14:57 Csókás, Bence
2024-08-05 15:04 ` Fabio Estevam
2024-08-07 8:09 ` [PATCH resubmit net] " Csókás, Bence
0 siblings, 2 replies; 7+ messages in thread
From: Csókás, Bence @ 2024-08-05 14:57 UTC (permalink / raw)
To: imx, netdev, linux-kernel
Cc: Csókás, Bence, Wei Fang, Shenwei Wang, Clark Wang,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Richard Cochran
PPS was not stopped in `fec_ptp_stop()`, called when
the adapter was removed. Consequentially, you couldn't
safely reload the driver with the PPS signal on.
Signed-off-by: Csókás, Bence <csokas.bence@prolan.hu>
---
drivers/net/ethernet/freescale/fec_ptp.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/freescale/fec_ptp.c b/drivers/net/ethernet/freescale/fec_ptp.c
index c5b89352373a..93953d252d99 100644
--- a/drivers/net/ethernet/freescale/fec_ptp.c
+++ b/drivers/net/ethernet/freescale/fec_ptp.c
@@ -787,6 +787,9 @@ void fec_ptp_stop(struct platform_device *pdev)
struct net_device *ndev = platform_get_drvdata(pdev);
struct fec_enet_private *fep = netdev_priv(ndev);
+ if (fep->pps_enable)
+ fec_ptp_enable_pps(fep, 0);
+
cancel_delayed_work_sync(&fep->time_keep);
hrtimer_cancel(&fep->perout_timer);
if (fep->ptp_clock)
--
2.34.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] net: fec: Stop PPS on driver remove
2024-08-05 14:57 [PATCH] net: fec: Stop PPS on driver remove Csókás, Bence
@ 2024-08-05 15:04 ` Fabio Estevam
2024-08-06 23:00 ` Andrew Lunn
2024-08-07 8:09 ` [PATCH resubmit net] " Csókás, Bence
1 sibling, 1 reply; 7+ messages in thread
From: Fabio Estevam @ 2024-08-05 15:04 UTC (permalink / raw)
To: Csókás, Bence
Cc: imx, netdev, linux-kernel, Wei Fang, Shenwei Wang, Clark Wang,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Richard Cochran
On Mon, Aug 5, 2024 at 11:59 AM Csókás, Bence <csokas.bence@prolan.hu> wrote:
>
> PPS was not stopped in `fec_ptp_stop()`, called when
> the adapter was removed. Consequentially, you couldn't
> safely reload the driver with the PPS signal on.
>
> Signed-off-by: Csókás, Bence <csokas.bence@prolan.hu>
It seems this one deserves a Fixes tag.
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] net: fec: Stop PPS on driver remove
2024-08-05 15:04 ` Fabio Estevam
@ 2024-08-06 23:00 ` Andrew Lunn
0 siblings, 0 replies; 7+ messages in thread
From: Andrew Lunn @ 2024-08-06 23:00 UTC (permalink / raw)
To: Fabio Estevam
Cc: Csókás, Bence, imx, netdev, linux-kernel, Wei Fang,
Shenwei Wang, Clark Wang, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Richard Cochran
On Mon, Aug 05, 2024 at 12:04:35PM -0300, Fabio Estevam wrote:
> On Mon, Aug 5, 2024 at 11:59 AM Csókás, Bence <csokas.bence@prolan.hu> wrote:
> >
> > PPS was not stopped in `fec_ptp_stop()`, called when
> > the adapter was removed. Consequentially, you couldn't
> > safely reload the driver with the PPS signal on.
> >
> > Signed-off-by: Csókás, Bence <csokas.bence@prolan.hu>
>
> It seems this one deserves a Fixes tag.
>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
And should be based on the correct tree, and indicate that tree in the
Subject: line:
https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#netdev-faq
Andrew
---
pw-bot: cr
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH resubmit net] net: fec: Stop PPS on driver remove
2024-08-05 14:57 [PATCH] net: fec: Stop PPS on driver remove Csókás, Bence
2024-08-05 15:04 ` Fabio Estevam
@ 2024-08-07 8:09 ` Csókás, Bence
2024-08-07 13:36 ` Andrew Lunn
` (2 more replies)
1 sibling, 3 replies; 7+ messages in thread
From: Csókás, Bence @ 2024-08-07 8:09 UTC (permalink / raw)
To: Fugang Duan, David S. Miller, Lucas Stach, imx, netdev, linux-kernel
Cc: Csókás, Bence, Fabio Estevam, Wei Fang, Shenwei Wang,
Clark Wang, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Richard Cochran
PPS was not stopped in `fec_ptp_stop()`, called when
the adapter was removed. Consequentially, you couldn't
safely reload the driver with the PPS signal on.
Fixes: 32cba57ba74b ("net: fec: introduce fec_ptp_stop and use in probe fail path")
Reviewed-by: Fabio Estevam <festevam@gmail.com>
Link: https://lore.kernel.org/netdev/CAOMZO5BzcZR8PwKKwBssQq_wAGzVgf1ffwe_nhpQJjviTdxy-w@mail.gmail.com/T/#m01dcb810bfc451a492140f6797ca77443d0cb79f
Signed-off-by: Csókás, Bence <csokas.bence@prolan.hu>
---
drivers/net/ethernet/freescale/fec_ptp.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/freescale/fec_ptp.c b/drivers/net/ethernet/freescale/fec_ptp.c
index e32f6724f568..2e4f3e1782a2 100644
--- a/drivers/net/ethernet/freescale/fec_ptp.c
+++ b/drivers/net/ethernet/freescale/fec_ptp.c
@@ -775,6 +775,9 @@ void fec_ptp_stop(struct platform_device *pdev)
struct net_device *ndev = platform_get_drvdata(pdev);
struct fec_enet_private *fep = netdev_priv(ndev);
+ if (fep->pps_enable)
+ fec_ptp_enable_pps(fep, 0);
+
cancel_delayed_work_sync(&fep->time_keep);
hrtimer_cancel(&fep->perout_timer);
if (fep->ptp_clock)
--
2.34.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH resubmit net] net: fec: Stop PPS on driver remove
2024-08-07 8:09 ` [PATCH resubmit net] " Csókás, Bence
@ 2024-08-07 13:36 ` Andrew Lunn
2024-08-07 14:04 ` Frank Li
2024-08-08 16:20 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 7+ messages in thread
From: Andrew Lunn @ 2024-08-07 13:36 UTC (permalink / raw)
To: Csókás, Bence
Cc: Fugang Duan, David S. Miller, Lucas Stach, imx, netdev,
linux-kernel, Fabio Estevam, Wei Fang, Shenwei Wang, Clark Wang,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Richard Cochran
On Wed, Aug 07, 2024 at 10:09:56AM +0200, Csókás, Bence wrote:
> PPS was not stopped in `fec_ptp_stop()`, called when
> the adapter was removed. Consequentially, you couldn't
> safely reload the driver with the PPS signal on.
>
> Fixes: 32cba57ba74b ("net: fec: introduce fec_ptp_stop and use in probe fail path")
>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
> Link: https://lore.kernel.org/netdev/CAOMZO5BzcZR8PwKKwBssQq_wAGzVgf1ffwe_nhpQJjviTdxy-w@mail.gmail.com/T/#m01dcb810bfc451a492140f6797ca77443d0cb79f
> Signed-off-by: Csókás, Bence <csokas.bence@prolan.hu>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH resubmit net] net: fec: Stop PPS on driver remove
2024-08-07 8:09 ` [PATCH resubmit net] " Csókás, Bence
2024-08-07 13:36 ` Andrew Lunn
@ 2024-08-07 14:04 ` Frank Li
2024-08-08 16:20 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 7+ messages in thread
From: Frank Li @ 2024-08-07 14:04 UTC (permalink / raw)
To: Csókás, Bence
Cc: Fugang Duan, David S. Miller, Lucas Stach, imx, netdev,
linux-kernel, Fabio Estevam, Wei Fang, Shenwei Wang, Clark Wang,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Richard Cochran
On Wed, Aug 07, 2024 at 10:09:56AM +0200, Csókás, Bence wrote:
> PPS was not stopped in `fec_ptp_stop()`, called when
> the adapter was removed. Consequentially, you couldn't
> safely reload the driver with the PPS signal on.
>
> Fixes: 32cba57ba74b ("net: fec: introduce fec_ptp_stop and use in probe fail path")
>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
> Link: https://lore.kernel.org/netdev/CAOMZO5BzcZR8PwKKwBssQq_wAGzVgf1ffwe_nhpQJjviTdxy-w@mail.gmail.com/T/#m01dcb810bfc451a492140f6797ca77443d0cb79f
> Signed-off-by: Csókás, Bence <csokas.bence@prolan.hu>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> ---
> drivers/net/ethernet/freescale/fec_ptp.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/ethernet/freescale/fec_ptp.c b/drivers/net/ethernet/freescale/fec_ptp.c
> index e32f6724f568..2e4f3e1782a2 100644
> --- a/drivers/net/ethernet/freescale/fec_ptp.c
> +++ b/drivers/net/ethernet/freescale/fec_ptp.c
> @@ -775,6 +775,9 @@ void fec_ptp_stop(struct platform_device *pdev)
> struct net_device *ndev = platform_get_drvdata(pdev);
> struct fec_enet_private *fep = netdev_priv(ndev);
>
> + if (fep->pps_enable)
> + fec_ptp_enable_pps(fep, 0);
> +
> cancel_delayed_work_sync(&fep->time_keep);
> hrtimer_cancel(&fep->perout_timer);
> if (fep->ptp_clock)
> --
> 2.34.1
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH resubmit net] net: fec: Stop PPS on driver remove
2024-08-07 8:09 ` [PATCH resubmit net] " Csókás, Bence
2024-08-07 13:36 ` Andrew Lunn
2024-08-07 14:04 ` Frank Li
@ 2024-08-08 16:20 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 7+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-08-08 16:20 UTC (permalink / raw)
To: =?utf-8?b?Q3PDs2vDoXMgQmVuY2UgPGNzb2thcy5iZW5jZUBwcm9sYW4uaHU+?=
Cc: B38611, davem, l.stach, imx, netdev, linux-kernel, festevam,
wei.fang, shenwei.wang, xiaoning.wang, edumazet, kuba, pabeni,
richardcochran
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 7 Aug 2024 10:09:56 +0200 you wrote:
> PPS was not stopped in `fec_ptp_stop()`, called when
> the adapter was removed. Consequentially, you couldn't
> safely reload the driver with the PPS signal on.
>
> Fixes: 32cba57ba74b ("net: fec: introduce fec_ptp_stop and use in probe fail path")
>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
> Link: https://lore.kernel.org/netdev/CAOMZO5BzcZR8PwKKwBssQq_wAGzVgf1ffwe_nhpQJjviTdxy-w@mail.gmail.com/T/#m01dcb810bfc451a492140f6797ca77443d0cb79f
> Signed-off-by: Csókás, Bence <csokas.bence@prolan.hu>
>
> [...]
Here is the summary with links:
- [resubmit,net] net: fec: Stop PPS on driver remove
https://git.kernel.org/netdev/net/c/8fee6d5ad5fa
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-08-08 16:20 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-05 14:57 [PATCH] net: fec: Stop PPS on driver remove Csókás, Bence
2024-08-05 15:04 ` Fabio Estevam
2024-08-06 23:00 ` Andrew Lunn
2024-08-07 8:09 ` [PATCH resubmit net] " Csókás, Bence
2024-08-07 13:36 ` Andrew Lunn
2024-08-07 14:04 ` Frank Li
2024-08-08 16:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®