mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Tristram.Ha@microchip.com
Cc: Eric Dumazet <edumazet@google.com>,
	linux-kernel@vger.kernel.org,  UNGLinuxDriver@microchip.com,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Paolo Abeni <pabeni@redhat.com>,
	"David S. Miller" <davem@davemloft.net>,
	 Vladimir Oltean <olteanv@gmail.com>,
	devicetree@vger.kernel.org,
	 Florian Fainelli <f.fainelli@gmail.com>,
	 Woojung Huh <woojung.huh@microchip.com>,
	Andrew Lunn <andrew@lunn.ch>,  Jakub Kicinski <kuba@kernel.org>,
	Marek Vasut <marex@denx.de>,
	 Tristram Ha <tristram.ha@microchip.com>,
	netdev@vger.kernel.org,  Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH net-next 1/4] dt-bindings: net: dsa: microchip: add SGMII port support to KSZ9477 switch
Date: Fri, 09 Aug 2024 18:20:21 -0600	[thread overview]
Message-ID: <172324922165.2057557.834820350130126130.robh@kernel.org> (raw)
In-Reply-To: <20240809233840.59953-2-Tristram.Ha@microchip.com>


On Fri, 09 Aug 2024 16:38:37 -0700, Tristram.Ha@microchip.com wrote:
> From: Tristram Ha <tristram.ha@microchip.com>
> 
> The SGMII module of KSZ9477 switch can be setup in 3 ways: 0 for direct
> connect, 1 for 1000BaseT SFP, and 2 for 10/100/1000 SFP.
> 
> SFP is typically used so the default is 1.  The driver can detect
> 10/100/1000 SFP and change the mode to 2.  For direct connect this mode
> has to be explicitly set to 0 as driver cannot detect that
> configuration.
> 
> Signed-off-by: Tristram Ha <tristram.ha@microchip.com>
> ---
>  .../devicetree/bindings/net/dsa/microchip,ksz.yaml   | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/dsa/microchip,ksz.example.dtb: switch@0: Unevaluated properties are not allowed ('sgmii-mode' was unexpected)
	from schema $id: http://devicetree.org/schemas/net/dsa/microchip,ksz.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240809233840.59953-2-Tristram.Ha@microchip.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2024-08-10  0:20 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-09 23:38 [PATCH net-next 0/4] " Tristram.Ha
2024-08-09 23:38 ` [PATCH net-next 1/4] dt-bindings: " Tristram.Ha
2024-08-10  0:20   ` Rob Herring (Arm) [this message]
2024-08-10 11:48   ` Krzysztof Kozlowski
2024-08-13 23:09     ` Tristram.Ha
2024-08-14  6:12       ` Krzysztof Kozlowski
2024-08-14 22:32         ` Tristram.Ha
2024-08-10 17:26   ` Andrew Lunn
2024-08-13 21:14     ` Tristram.Ha
2024-08-13 21:32       ` Andrew Lunn
2024-08-13 22:17         ` Tristram.Ha
2024-08-14 13:50           ` Andrew Lunn
2024-08-14 22:30             ` Tristram.Ha
2024-08-14 22:40               ` Andrew Lunn
2024-08-15 21:54                 ` Tristram.Ha
2024-08-15 22:50                   ` Andrew Lunn
2024-08-09 23:38 ` [PATCH net-next 2/4] net: dsa: microchip: support global switch interrupt in KSZ DSA driver Tristram.Ha
2024-08-09 23:38 ` [PATCH net-next 3/4] net: dsa: microchip: handle most interrupts in KSZ9477/KSZ9893 switch families Tristram.Ha
2024-08-10 17:43   ` Sai Krishna Gajula
2024-08-10 17:44   ` Andrew Lunn
2024-08-13 22:24     ` Tristram.Ha
2024-08-14 13:55       ` Andrew Lunn
2024-08-09 23:38 ` [PATCH net-next 4/4] net: dsa: microchip: add SGMII port support to KSZ9477 switch Tristram.Ha
2024-08-10 17:52   ` Andrew Lunn
2024-08-13 20:59     ` Tristram.Ha
2024-08-11 16:32   ` Andrew Lunn
2024-08-13 20:54     ` Tristram.Ha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=172324922165.2057557.834820350130126130.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=Tristram.Ha@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=woojung.huh@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®