From: <Tristram.Ha@microchip.com>
To: <andrew@lunn.ch>
Cc: <Woojung.Huh@microchip.com>, <UNGLinuxDriver@microchip.com>,
<devicetree@vger.kernel.org>, <f.fainelli@gmail.com>,
<olteanv@gmail.com>, <robh@kernel.org>, <krzk+dt@kernel.org>,
<conor+dt@kernel.org>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<marex@denx.de>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net-next 4/4] net: dsa: microchip: add SGMII port support to KSZ9477 switch
Date: Tue, 13 Aug 2024 20:59:36 +0000 [thread overview]
Message-ID: <BYAPR11MB355872F35F8758BA7F761B6DEC862@BYAPR11MB3558.namprd11.prod.outlook.com> (raw)
In-Reply-To: <2f59b854-c1d4-4007-bc6e-4c8e88eda940@lunn.ch>
> On Fri, Aug 09, 2024 at 04:38:40PM -0700, Tristram.Ha@microchip.com wrote:
> > From: Tristram Ha <tristram.ha@microchip.com>
> >
> > The SGMII module of KSZ9477 switch can be setup in 3 ways: 0 for direct
> > connect, 1 for 1000BaseT SFP, and 2 for 10/100/1000 SFP.
> >
> > SFP is typically used so the default is 1. The driver can detect
> > 10/100/1000 SFP and change the mode to 2. For direct connect this mode
> > has to be explicitly set to 0 as driver cannot detect that
> > configuration.
> >
> > The SGMII module can only report basic link status of the SFP, so it is
> > simulated as a regular internal PHY.
> >
> > Since the regular PHY in the switch uses interrupt instead of polling the
> > driver has to handle the SGMII interrupt indicating link on/off.
> >
> > One issue for the 1000BaseT SFP is there is no link down interrupt, so
> > the driver has to use polling to detect link down when the link is up.
> >
> > Recent change in the DSA operation can setup the port before the PHY
> > interrupt handling function is registered. As the SGMII interrupt can
> > be triggered after port setup there is extra code in the interrupt
> > processing to handle this situation. Otherwise a kernel fault can be
> > triggered.
> >
> > Note the SGMII interrupt cannot be masked in hardware. Also the module
> > is not reset when the switch is reset. It is important to reset the
> > module properly to make sure the interrupt is not triggered prematurely.
>
> Why not model this as a PCS? Russell has been converting all PCS like
> things in DSA into try PCS drivers. So i suspect Russell will not like
> this code, and would prefer a PCS driver.
I am not familiar with PCS. It seems too complicated after looking at
the phylink_pcs structure and associated phylink_pcs_ops functions.
The SGMII module can only report link and does not even restart
auto-negotiation. It is a set once and forget operation.
next prev parent reply other threads:[~2024-08-13 20:59 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-09 23:38 [PATCH net-next 0/4] " Tristram.Ha
2024-08-09 23:38 ` [PATCH net-next 1/4] dt-bindings: " Tristram.Ha
2024-08-10 0:20 ` Rob Herring (Arm)
2024-08-10 11:48 ` Krzysztof Kozlowski
2024-08-13 23:09 ` Tristram.Ha
2024-08-14 6:12 ` Krzysztof Kozlowski
2024-08-14 22:32 ` Tristram.Ha
2024-08-10 17:26 ` Andrew Lunn
2024-08-13 21:14 ` Tristram.Ha
2024-08-13 21:32 ` Andrew Lunn
2024-08-13 22:17 ` Tristram.Ha
2024-08-14 13:50 ` Andrew Lunn
2024-08-14 22:30 ` Tristram.Ha
2024-08-14 22:40 ` Andrew Lunn
2024-08-15 21:54 ` Tristram.Ha
2024-08-15 22:50 ` Andrew Lunn
2024-08-09 23:38 ` [PATCH net-next 2/4] net: dsa: microchip: support global switch interrupt in KSZ DSA driver Tristram.Ha
2024-08-09 23:38 ` [PATCH net-next 3/4] net: dsa: microchip: handle most interrupts in KSZ9477/KSZ9893 switch families Tristram.Ha
2024-08-10 17:43 ` Sai Krishna Gajula
2024-08-10 17:44 ` Andrew Lunn
2024-08-13 22:24 ` Tristram.Ha
2024-08-14 13:55 ` Andrew Lunn
2024-08-09 23:38 ` [PATCH net-next 4/4] net: dsa: microchip: add SGMII port support to KSZ9477 switch Tristram.Ha
2024-08-10 17:52 ` Andrew Lunn
2024-08-13 20:59 ` Tristram.Ha [this message]
2024-08-11 16:32 ` Andrew Lunn
2024-08-13 20:54 ` Tristram.Ha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB355872F35F8758BA7F761B6DEC862@BYAPR11MB3558.namprd11.prod.outlook.com \
--to=tristram.ha@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®