From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Yong Wu <yong.wu@mediatek.com>, Joerg Roedel <joro@8bytes.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>
Cc: Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Hans Verkuil <hverkuil@xs4all.nl>,
nfraprado@collabora.com, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
iommu@lists.linux.dev, mingyuan.ma@mediatek.com,
yf.wang@mediatek.com, jianjiao.zeng@mediatek.com,
Yunfei Dong <yunfei.dong@mediatek.com>,
kyrie wu <kyrie.wu@mediatek.corp-partner.google.com>,
chengci.xu@mediatek.com, youlin.pei@mediatek.com,
anan.sun@mediatek.com
Subject: Re: [PATCH v3 05/11] iommu/mediatek: mt8195: Add iova_region_larb_msk
Date: Tue, 14 Feb 2023 10:36:11 +0100 [thread overview]
Message-ID: <17239a6f-1d85-d725-89d6-02afe4fbe56a@collabora.com> (raw)
In-Reply-To: <20230214031114.926-6-yong.wu@mediatek.com>
Il 14/02/23 04:11, Yong Wu ha scritto:
> Add iova_region_larb_msk for mt8195. We separate the 16GB iova regions
> by each device's larbid/portid.
> Refer to include/dt-bindings/memory/mt8195-memory-port.h
>
> Define a new macro MT8192_MULTI_REGION_MAX_NR to indicate
> the index of mt8xxx_larb_region_msk and
> "struct mtk_iommu_iova_region mt8192_multi_dom"
> are the same.
>
> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
Sorry but... you *are* introducing a iova_region_larb_msk for MT8192 later,
while you're introducing definitions containing the `MT8192` name in a commit
that introduces the same but for MT8195.
I strongly suggest to, at this point, introduce MT8192 region mask here, along
with the MT8192 definitions, and MT8195 after that :-)
Regards,
Angelo
next prev parent reply other threads:[~2023-02-14 9:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 3:11 [PATCH v3 00/11] Adjust the dma-ranges for MTK IOMMU Yong Wu
2023-02-14 3:11 ` [PATCH v3 01/11] dt-bindings: media: mediatek,vcodec: Remove dma-ranges property Yong Wu
2023-02-14 3:11 ` [PATCH v3 02/11] dt-bindings: media: mediatek,jpeg: " Yong Wu
2023-02-14 3:11 ` [PATCH v3 03/11] iommu/mediatek: Improve comment for the current region/bank Yong Wu
2023-02-14 9:48 ` AngeloGioacchino Del Regno
2023-02-14 3:11 ` [PATCH v3 04/11] iommu/mediatek: Get regionid from larb/port id Yong Wu
2023-02-14 9:07 ` AngeloGioacchino Del Regno
2023-02-14 9:12 ` AngeloGioacchino Del Regno
2023-02-14 3:11 ` [PATCH v3 05/11] iommu/mediatek: mt8195: Add iova_region_larb_msk Yong Wu
2023-02-14 9:36 ` AngeloGioacchino Del Regno [this message]
2023-02-14 9:49 ` Yong Wu (吴勇)
2023-02-14 3:11 ` [PATCH v3 06/11] iommu/mediatek: mt8186: " Yong Wu
2023-02-14 9:36 ` AngeloGioacchino Del Regno
2023-02-14 3:11 ` [PATCH v3 07/11] iommu/mediatek: mt8192: " Yong Wu
2023-02-14 3:11 ` [PATCH v3 08/11] iommu/mediatek: Add a gap for the iova regions Yong Wu
2023-02-14 9:55 ` AngeloGioacchino Del Regno
2023-02-14 3:11 ` [PATCH v3 09/11] arm64: dts: mt8195: Add dma-ranges for the parent "soc" node Yong Wu
2023-02-14 3:11 ` [PATCH v3 10/11] arm64: dts: mt8195: Remove the unnecessary dma-ranges Yong Wu
2023-02-14 3:11 ` [PATCH v3 11/11] arm64: dts: mt8186: Add dma-ranges for the parent "soc" node Yong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17239a6f-1d85-d725-89d6-02afe4fbe56a@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=anan.sun@mediatek.com \
--cc=chengci.xu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=iommu@lists.linux.dev \
--cc=jianjiao.zeng@mediatek.com \
--cc=joro@8bytes.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kyrie.wu@mediatek.corp-partner.google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=mingyuan.ma@mediatek.com \
--cc=nfraprado@collabora.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
--cc=yf.wang@mediatek.com \
--cc=yong.wu@mediatek.com \
--cc=youlin.pei@mediatek.com \
--cc=yunfei.dong@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®