From: Yong Wu <yong.wu@mediatek.com>
To: Joerg Roedel <joro@8bytes.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>
Cc: Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Hans Verkuil <hverkuil@xs4all.nl>, <nfraprado@collabora.com>,
<linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <iommu@lists.linux.dev>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
<mingyuan.ma@mediatek.com>, <yf.wang@mediatek.com>,
<jianjiao.zeng@mediatek.com>,
Yunfei Dong <yunfei.dong@mediatek.com>,
kyrie wu <kyrie.wu@mediatek.corp-partner.google.com>,
<chengci.xu@mediatek.com>, <youlin.pei@mediatek.com>,
<anan.sun@mediatek.com>, Yong Wu <yong.wu@mediatek.com>
Subject: [PATCH v3 04/11] iommu/mediatek: Get regionid from larb/port id
Date: Tue, 14 Feb 2023 11:11:07 +0800 [thread overview]
Message-ID: <20230214031114.926-5-yong.wu@mediatek.com> (raw)
In-Reply-To: <20230214031114.926-1-yong.wu@mediatek.com>
After commit f1ad5338a4d5 ("of: Fix "dma-ranges" handling for bus
controllers"), the dma-ranges is not allowed for dts leaf node.
but we still would like to separate to different masters
into different iova regions.
Thus we have to separate it by the HW larbid and portid. For example,
larb1/2 are in region2 and larb3 is in region3. The problem is that
some ports inside a larb are in region4 while some ports inside this
larb are in region5. Therefore I define a "iova_region_larb_msk" to help
record the information for each a port. Take a example for a larb:
[1] = ~0: means all ports in this larb are in region1;
[2] = BIT(3) | BIT(4): means port3/4 in this larb are region2;
[3] = ~(BIT(3) | BIT(4)): means all the other ports except port3/4
in this larb are region3.
This method also avoids the users forget/abuse the iova regions.
Signed-off-by: Yong Wu <yong.wu@mediatek.com>
---
drivers/iommu/mtk_iommu.c | 47 ++++++++++++++++++++++-----------------
1 file changed, 27 insertions(+), 20 deletions(-)
diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c
index ab53edcb221f..7e2cb3b8cac8 100644
--- a/drivers/iommu/mtk_iommu.c
+++ b/drivers/iommu/mtk_iommu.c
@@ -8,7 +8,6 @@
#include <linux/clk.h>
#include <linux/component.h>
#include <linux/device.h>
-#include <linux/dma-direct.h>
#include <linux/err.h>
#include <linux/interrupt.h>
#include <linux/io.h>
@@ -212,6 +211,11 @@ struct mtk_iommu_plat_data {
struct {
unsigned int iova_region_nr;
const struct mtk_iommu_iova_region *iova_region;
+ /*
+ * Indicate the correspondence between larbs/ports and regions.
+ * The index is same with iova_region.
+ */
+ const u32 (*iova_region_larb_msk)[MTK_LARB_NR_MAX];
};
/*
@@ -529,30 +533,33 @@ static unsigned int mtk_iommu_get_bank_id(struct device *dev,
static int mtk_iommu_get_iova_region_id(struct device *dev,
const struct mtk_iommu_plat_data *plat_data)
{
- const struct mtk_iommu_iova_region *rgn = plat_data->iova_region;
- const struct bus_dma_region *dma_rgn = dev->dma_range_map;
- int i, candidate = -1;
- dma_addr_t dma_end;
+ struct iommu_fwspec *fwspec = dev_iommu_fwspec_get(dev);
+ unsigned int portidmsk = 0, larbid;
+ const u32 *rgn_larb_msk;
+ int i, region_id = -1;
- if (!dma_rgn || plat_data->iova_region_nr == 1)
+ if (plat_data->iova_region_nr == 1)
return 0;
- dma_end = dma_rgn->dma_start + dma_rgn->size - 1;
- for (i = 0; i < plat_data->iova_region_nr; i++, rgn++) {
- /* Best fit. */
- if (dma_rgn->dma_start == rgn->iova_base &&
- dma_end == rgn->iova_base + rgn->size - 1)
- return i;
- /* ok if it is inside this region. */
- if (dma_rgn->dma_start >= rgn->iova_base &&
- dma_end < rgn->iova_base + rgn->size)
- candidate = i;
+ larbid = MTK_M4U_TO_LARB(fwspec->ids[0]);
+ for (i = 0; i < fwspec->num_ids; i++)
+ portidmsk |= BIT(MTK_M4U_TO_PORT(fwspec->ids[i]));
+
+ for (i = 0; i < plat_data->iova_region_nr; i++) {
+ rgn_larb_msk = plat_data->iova_region_larb_msk[i];
+ if (!rgn_larb_msk)
+ continue;
+
+ if ((rgn_larb_msk[larbid] & portidmsk) == portidmsk) {
+ region_id = i;
+ break;
+ }
}
- if (candidate >= 0)
- return candidate;
- dev_err(dev, "Can NOT find the iommu domain id(%pad 0x%llx).\n",
- &dma_rgn->dma_start, dma_rgn->size);
+ if (region_id >= 0)
+ return region_id;
+ dev_err(dev, "Can NOT find the region for larb(%d-%x).\n",
+ larbid, portidmsk);
return -EINVAL;
}
--
2.18.0
next prev parent reply other threads:[~2023-02-14 3:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 3:11 [PATCH v3 00/11] Adjust the dma-ranges for MTK IOMMU Yong Wu
2023-02-14 3:11 ` [PATCH v3 01/11] dt-bindings: media: mediatek,vcodec: Remove dma-ranges property Yong Wu
2023-02-14 3:11 ` [PATCH v3 02/11] dt-bindings: media: mediatek,jpeg: " Yong Wu
2023-02-14 3:11 ` [PATCH v3 03/11] iommu/mediatek: Improve comment for the current region/bank Yong Wu
2023-02-14 9:48 ` AngeloGioacchino Del Regno
2023-02-14 3:11 ` Yong Wu [this message]
2023-02-14 9:07 ` [PATCH v3 04/11] iommu/mediatek: Get regionid from larb/port id AngeloGioacchino Del Regno
2023-02-14 9:12 ` AngeloGioacchino Del Regno
2023-02-14 3:11 ` [PATCH v3 05/11] iommu/mediatek: mt8195: Add iova_region_larb_msk Yong Wu
2023-02-14 9:36 ` AngeloGioacchino Del Regno
2023-02-14 9:49 ` Yong Wu (吴勇)
2023-02-14 3:11 ` [PATCH v3 06/11] iommu/mediatek: mt8186: " Yong Wu
2023-02-14 9:36 ` AngeloGioacchino Del Regno
2023-02-14 3:11 ` [PATCH v3 07/11] iommu/mediatek: mt8192: " Yong Wu
2023-02-14 3:11 ` [PATCH v3 08/11] iommu/mediatek: Add a gap for the iova regions Yong Wu
2023-02-14 9:55 ` AngeloGioacchino Del Regno
2023-02-14 3:11 ` [PATCH v3 09/11] arm64: dts: mt8195: Add dma-ranges for the parent "soc" node Yong Wu
2023-02-14 3:11 ` [PATCH v3 10/11] arm64: dts: mt8195: Remove the unnecessary dma-ranges Yong Wu
2023-02-14 3:11 ` [PATCH v3 11/11] arm64: dts: mt8186: Add dma-ranges for the parent "soc" node Yong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230214031114.926-5-yong.wu@mediatek.com \
--to=yong.wu@mediatek.com \
--cc=anan.sun@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chengci.xu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=iommu@lists.linux.dev \
--cc=jianjiao.zeng@mediatek.com \
--cc=joro@8bytes.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kyrie.wu@mediatek.corp-partner.google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=mingyuan.ma@mediatek.com \
--cc=nfraprado@collabora.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
--cc=yf.wang@mediatek.com \
--cc=youlin.pei@mediatek.com \
--cc=yunfei.dong@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®