* [PATCH] dt-bindings: samsung: exynos-usi: add missing constraints
@ 2024-08-18 17:28 Krzysztof Kozlowski
2024-08-19 17:13 ` Rob Herring (Arm)
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-18 17:28 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar,
Sam Protsenko, devicetree, linux-arm-kernel, linux-samsung-soc,
linux-kernel
Cc: Krzysztof Kozlowski
Properties with variable number of items per each device are expected to
have widest constraints in top-level "properties:" block and further
customized (narrowed) in "if:then:". Add missing top-level constraints
for reg, clocks and clock-names.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../bindings/soc/samsung/exynos-usi.yaml | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml b/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml
index 8b478d6cdc30..f80fcbc3128b 100644
--- a/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml
+++ b/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml
@@ -32,11 +32,16 @@ properties:
- enum:
- samsung,exynos850-usi
- reg: true
+ reg:
+ maxItems: 1
- clocks: true
+ clocks:
+ maxItems: 2
- clock-names: true
+ clock-names:
+ items:
+ - const: pclk
+ - const: ipclk
ranges: true
@@ -113,9 +118,7 @@ then:
- description: Operating clock for UART/SPI/I2C protocol
clock-names:
- items:
- - const: pclk
- - const: ipclk
+ maxItems: 2
required:
- reg
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: samsung: exynos-usi: add missing constraints
2024-08-18 17:28 [PATCH] dt-bindings: samsung: exynos-usi: add missing constraints Krzysztof Kozlowski
@ 2024-08-19 17:13 ` Rob Herring (Arm)
2024-08-19 18:26 ` Sam Protsenko
2024-08-19 19:55 ` Krzysztof Kozlowski
2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring (Arm) @ 2024-08-19 17:13 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Krzysztof Kozlowski, Sam Protsenko, linux-arm-kernel,
Alim Akhtar, Conor Dooley, devicetree, linux-samsung-soc,
linux-kernel
On Sun, 18 Aug 2024 19:28:04 +0200, Krzysztof Kozlowski wrote:
> Properties with variable number of items per each device are expected to
> have widest constraints in top-level "properties:" block and further
> customized (narrowed) in "if:then:". Add missing top-level constraints
> for reg, clocks and clock-names.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../bindings/soc/samsung/exynos-usi.yaml | 15 +++++++++------
> 1 file changed, 9 insertions(+), 6 deletions(-)
>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: samsung: exynos-usi: add missing constraints
2024-08-18 17:28 [PATCH] dt-bindings: samsung: exynos-usi: add missing constraints Krzysztof Kozlowski
2024-08-19 17:13 ` Rob Herring (Arm)
@ 2024-08-19 18:26 ` Sam Protsenko
2024-08-19 19:55 ` Krzysztof Kozlowski
2 siblings, 0 replies; 4+ messages in thread
From: Sam Protsenko @ 2024-08-19 18:26 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar,
devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel
On Sun, Aug 18, 2024 at 12:28 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> Properties with variable number of items per each device are expected to
> have widest constraints in top-level "properties:" block and further
> customized (narrowed) in "if:then:". Add missing top-level constraints
> for reg, clocks and clock-names.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
> .../bindings/soc/samsung/exynos-usi.yaml | 15 +++++++++------
> 1 file changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml b/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml
> index 8b478d6cdc30..f80fcbc3128b 100644
> --- a/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml
> +++ b/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml
> @@ -32,11 +32,16 @@ properties:
> - enum:
> - samsung,exynos850-usi
>
> - reg: true
> + reg:
> + maxItems: 1
>
> - clocks: true
> + clocks:
> + maxItems: 2
>
> - clock-names: true
> + clock-names:
> + items:
> + - const: pclk
> + - const: ipclk
>
> ranges: true
>
> @@ -113,9 +118,7 @@ then:
> - description: Operating clock for UART/SPI/I2C protocol
>
> clock-names:
> - items:
> - - const: pclk
> - - const: ipclk
> + maxItems: 2
>
> required:
> - reg
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: samsung: exynos-usi: add missing constraints
2024-08-18 17:28 [PATCH] dt-bindings: samsung: exynos-usi: add missing constraints Krzysztof Kozlowski
2024-08-19 17:13 ` Rob Herring (Arm)
2024-08-19 18:26 ` Sam Protsenko
@ 2024-08-19 19:55 ` Krzysztof Kozlowski
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-19 19:55 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar,
Sam Protsenko, devicetree, linux-arm-kernel, linux-samsung-soc,
linux-kernel, Krzysztof Kozlowski
On Sun, 18 Aug 2024 19:28:04 +0200, Krzysztof Kozlowski wrote:
> Properties with variable number of items per each device are expected to
> have widest constraints in top-level "properties:" block and further
> customized (narrowed) in "if:then:". Add missing top-level constraints
> for reg, clocks and clock-names.
>
>
Applied, thanks!
[1/1] dt-bindings: samsung: exynos-usi: add missing constraints
https://git.kernel.org/krzk/linux/c/84236ed0a2b1d40a0b72e8dde4b18d641263f5f9
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-08-19 19:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-18 17:28 [PATCH] dt-bindings: samsung: exynos-usi: add missing constraints Krzysztof Kozlowski
2024-08-19 17:13 ` Rob Herring (Arm)
2024-08-19 18:26 ` Sam Protsenko
2024-08-19 19:55 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®