mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: reset: socionext,uniphier-glue-reset: add top-level constraints
@ 2024-08-18 17:28 Krzysztof Kozlowski
  2024-08-19 17:13 ` Rob Herring (Arm)
  2024-08-21 10:31 ` Kunihiko Hayashi
  0 siblings, 2 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-18 17:28 UTC (permalink / raw)
  To: Philipp Zabel, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Kunihiko Hayashi, Masami Hiramatsu, devicetree, linux-arm-kernel,
	linux-kernel
  Cc: Krzysztof Kozlowski

Properties with variable number of items per each device are expected to
have widest constraints in top-level "properties:" block and further
customized (narrowed) in "if:then:".  Add missing top-level constraints
for clock-names and reset-names.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../bindings/reset/socionext,uniphier-glue-reset.yaml     | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/reset/socionext,uniphier-glue-reset.yaml b/Documentation/devicetree/bindings/reset/socionext,uniphier-glue-reset.yaml
index fa253c518d79..babc563ae61e 100644
--- a/Documentation/devicetree/bindings/reset/socionext,uniphier-glue-reset.yaml
+++ b/Documentation/devicetree/bindings/reset/socionext,uniphier-glue-reset.yaml
@@ -38,13 +38,17 @@ properties:
     minItems: 1
     maxItems: 2
 
-  clock-names: true
+  clock-names:
+    minItems: 1
+    maxItems: 2
 
   resets:
     minItems: 1
     maxItems: 2
 
-  reset-names: true
+  reset-names:
+    minItems: 1
+    maxItems: 2
 
 allOf:
   - if:
-- 
2.43.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: reset: socionext,uniphier-glue-reset: add top-level constraints
  2024-08-18 17:28 [PATCH] dt-bindings: reset: socionext,uniphier-glue-reset: add top-level constraints Krzysztof Kozlowski
@ 2024-08-19 17:13 ` Rob Herring (Arm)
  2024-08-21 10:31 ` Kunihiko Hayashi
  1 sibling, 0 replies; 4+ messages in thread
From: Rob Herring (Arm) @ 2024-08-19 17:13 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Philipp Zabel, devicetree, linux-arm-kernel, Conor Dooley,
	Masami Hiramatsu, linux-kernel, Krzysztof Kozlowski,
	Kunihiko Hayashi


On Sun, 18 Aug 2024 19:28:19 +0200, Krzysztof Kozlowski wrote:
> Properties with variable number of items per each device are expected to
> have widest constraints in top-level "properties:" block and further
> customized (narrowed) in "if:then:".  Add missing top-level constraints
> for clock-names and reset-names.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  .../bindings/reset/socionext,uniphier-glue-reset.yaml     | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: reset: socionext,uniphier-glue-reset: add top-level constraints
  2024-08-18 17:28 [PATCH] dt-bindings: reset: socionext,uniphier-glue-reset: add top-level constraints Krzysztof Kozlowski
  2024-08-19 17:13 ` Rob Herring (Arm)
@ 2024-08-21 10:31 ` Kunihiko Hayashi
  2024-09-02  9:48   ` Philipp Zabel
  1 sibling, 1 reply; 4+ messages in thread
From: Kunihiko Hayashi @ 2024-08-21 10:31 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Philipp Zabel, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Masami Hiramatsu, devicetree, linux-arm-kernel, linux-kernel

Hi Krzysztof,

On 2024/08/19 2:28, Krzysztof Kozlowski wrote:
> Properties with variable number of items per each device are expected to
> have widest constraints in top-level "properties:" block and further
> customized (narrowed) in "if:then:".  Add missing top-level constraints
> for clock-names and reset-names.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>   .../bindings/reset/socionext,uniphier-glue-reset.yaml     | 8 ++++++--
>   1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git
> a/Documentation/devicetree/bindings/reset/socionext,uniphier-glue-reset.ya
> ml
> b/Documentation/devicetree/bindings/reset/socionext,uniphier-glue-reset.ya
> ml
> index fa253c518d79..babc563ae61e 100644
> ---
> a/Documentation/devicetree/bindings/reset/socionext,uniphier-glue-reset.ya
> ml
> +++
> b/Documentation/devicetree/bindings/reset/socionext,uniphier-glue-reset.ya
> ml
> @@ -38,13 +38,17 @@ properties:
>       minItems: 1
>       maxItems: 2
>   
> -  clock-names: true
> +  clock-names:
> +    minItems: 1
> +    maxItems: 2
>   
>     resets:
>       minItems: 1
>       maxItems: 2
>   
> -  reset-names: true
> +  reset-names:
> +    minItems: 1
> +    maxItems: 2
>   
>   allOf:
>     - if:

Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>

I'd appreciate if it could be applied in devicetree or reset.

Thank you,

---
Best Regards
Kunihiko Hayashi

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: reset: socionext,uniphier-glue-reset: add top-level constraints
  2024-08-21 10:31 ` Kunihiko Hayashi
@ 2024-09-02  9:48   ` Philipp Zabel
  0 siblings, 0 replies; 4+ messages in thread
From: Philipp Zabel @ 2024-09-02  9:48 UTC (permalink / raw)
  To: Kunihiko Hayashi, Krzysztof Kozlowski
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Masami Hiramatsu,
	devicetree, linux-arm-kernel, linux-kernel

On Mi, 2024-08-21 at 19:31 +0900, Kunihiko Hayashi wrote:
> On 2024/08/19 2:28, Krzysztof Kozlowski wrote:
> > Properties with variable number of items per each device are expected to
> > have widest constraints in top-level "properties:" block and further
> > customized (narrowed) in "if:then:".  Add missing top-level constraints
> > for clock-names and reset-names.
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
[...]
> Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> 
> I'd appreciate if it could be applied in devicetree or reset.

Thank you, applied to reset/next.

regards
Philipp

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-09-02  9:48 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-18 17:28 [PATCH] dt-bindings: reset: socionext,uniphier-glue-reset: add top-level constraints Krzysztof Kozlowski
2024-08-19 17:13 ` Rob Herring (Arm)
2024-08-21 10:31 ` Kunihiko Hayashi
2024-09-02  9:48   ` Philipp Zabel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®