* [PATCH net-next] net: dsa: b53: Use dev_err_probe()
@ 2024-08-20 0:44 Florian Fainelli
2024-08-20 13:46 ` Andrew Lunn
2024-08-21 1:30 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Florian Fainelli @ 2024-08-20 0:44 UTC (permalink / raw)
To: netdev
Cc: robimarko, Florian Fainelli, Andrew Lunn, Vladimir Oltean,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
open list
Rather than print an error even when we get -EPROBE_DEFER, use
dev_err_probe() to filter out those messages.
Link: https://github.com/openwrt/openwrt/pull/11680
Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
---
drivers/net/dsa/b53/b53_mdio.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/net/dsa/b53/b53_mdio.c b/drivers/net/dsa/b53/b53_mdio.c
index 897e5e8b3d69..31d070bf161a 100644
--- a/drivers/net/dsa/b53/b53_mdio.c
+++ b/drivers/net/dsa/b53/b53_mdio.c
@@ -343,10 +343,9 @@ static int b53_mdio_probe(struct mdio_device *mdiodev)
dev_set_drvdata(&mdiodev->dev, dev);
ret = b53_switch_register(dev);
- if (ret) {
- dev_err(&mdiodev->dev, "failed to register switch: %i\n", ret);
- return ret;
- }
+ if (ret)
+ return dev_err_probe(&mdiodev->dev, ret,
+ "failed to register switch\n");
return ret;
}
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: dsa: b53: Use dev_err_probe()
2024-08-20 0:44 [PATCH net-next] net: dsa: b53: Use dev_err_probe() Florian Fainelli
@ 2024-08-20 13:46 ` Andrew Lunn
2024-08-21 1:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2024-08-20 13:46 UTC (permalink / raw)
To: Florian Fainelli
Cc: netdev, robimarko, Vladimir Oltean, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, open list
On Mon, Aug 19, 2024 at 05:44:35PM -0700, Florian Fainelli wrote:
> Rather than print an error even when we get -EPROBE_DEFER, use
> dev_err_probe() to filter out those messages.
>
> Link: https://github.com/openwrt/openwrt/pull/11680
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: dsa: b53: Use dev_err_probe()
2024-08-20 0:44 [PATCH net-next] net: dsa: b53: Use dev_err_probe() Florian Fainelli
2024-08-20 13:46 ` Andrew Lunn
@ 2024-08-21 1:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-08-21 1:30 UTC (permalink / raw)
To: Florian Fainelli
Cc: netdev, robimarko, andrew, olteanv, davem, edumazet, kuba,
pabeni, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 19 Aug 2024 17:44:35 -0700 you wrote:
> Rather than print an error even when we get -EPROBE_DEFER, use
> dev_err_probe() to filter out those messages.
>
> Link: https://github.com/openwrt/openwrt/pull/11680
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
> ---
> drivers/net/dsa/b53/b53_mdio.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
Here is the summary with links:
- [net-next] net: dsa: b53: Use dev_err_probe()
https://git.kernel.org/netdev/net-next/c/4d36b2b1dea4
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-21 1:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-20 0:44 [PATCH net-next] net: dsa: b53: Use dev_err_probe() Florian Fainelli
2024-08-20 13:46 ` Andrew Lunn
2024-08-21 1:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®