From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, linaro-kernel@lists.linaro.org,
robin.randhawa@arm.com, Steve.Bannister@arm.com,
Liviu.Dudau@arm.com, charles.garcia-tobin@arm.com,
rickard.andersson@stericsson.com, fabio.baltieri@linaro.org,
Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH 1/3] workqueue: define mod_scheduled_delayed_work[_on]() helpers
Date: Tue, 12 Mar 2013 00:28:18 +0100 [thread overview]
Message-ID: <1725153.RTNj7Pf8GC@vostro.rjw.lan> (raw)
In-Reply-To: <5249868a014d716eb38cc90e04ed0f6051e65fc3.1361964515.git.viresh.kumar@linaro.org>
On Wednesday, February 27, 2013 04:59:10 PM Viresh Kumar wrote:
> The only difference between schedule_delayed_work[_on]() and
> queue_delayed_work[_on]() is the workqueue, work is scheduled on. We may need to
> modify the delay for works queued with schedule_delayed_work[_on]() calls and
> thus adding these helpers.
>
> First users of these new helpers is cpufreq governors which need to modify the
> delay for its works.
>
> Cc: Tejun Heo <tj@kernel.org>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Do I assume correctly that you have withdrawn this patch?
Rafael
> ---
> include/linux/workqueue.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/include/linux/workqueue.h b/include/linux/workqueue.h
> index 2b58905..864c2b3 100644
> --- a/include/linux/workqueue.h
> +++ b/include/linux/workqueue.h
> @@ -412,6 +412,7 @@ extern bool schedule_delayed_work_on(int cpu, struct delayed_work *work,
> extern bool schedule_delayed_work(struct delayed_work *work,
> unsigned long delay);
> extern int schedule_on_each_cpu(work_func_t func);
> +
> extern int keventd_up(void);
>
> int execute_in_process_context(work_func_t fn, struct execute_work *);
> @@ -465,6 +466,11 @@ static inline long work_on_cpu(unsigned int cpu, long (*fn)(void *), void *arg)
> long work_on_cpu(unsigned int cpu, long (*fn)(void *), void *arg);
> #endif /* CONFIG_SMP */
>
> +#define mod_scheduled_delayed_work_on(cpu, dwork, delay) \
> + mod_delayed_work_on(cpu, system_wq, dwork, delay)
> +#define mod_scheduled_delayed_work(dwork, delay) \
> + mod_delayed_work(system_wq, dwork, delay)
> +
> #ifdef CONFIG_FREEZER
> extern void freeze_workqueues_begin(void);
> extern bool freeze_workqueues_busy(void);
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2013-03-11 23:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 11:29 Viresh Kumar
2013-02-27 11:29 ` [PATCH 2/3] cpufreq: ondemand: Don't update sample_type if we don't evaluate load again Viresh Kumar
2013-02-27 11:29 ` [PATCH 3/3] cpufreq: governors: Avoid unnecessary per cpu timer interrupts Viresh Kumar
2013-02-27 12:20 ` [PATCH 1/3] workqueue: define mod_scheduled_delayed_work[_on]() helpers Viresh Kumar
2013-02-27 15:10 ` Tejun Heo
2013-02-27 15:14 ` Viresh Kumar
2013-02-27 15:29 ` Tejun Heo
2013-03-11 23:28 ` Rafael J. Wysocki [this message]
2013-03-12 0:54 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1725153.RTNj7Pf8GC@vostro.rjw.lan \
--to=rjw@sisk.pl \
--cc=Liviu.Dudau@arm.com \
--cc=Steve.Bannister@arm.com \
--cc=charles.garcia-tobin@arm.com \
--cc=cpufreq@vger.kernel.org \
--cc=fabio.baltieri@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rickard.andersson@stericsson.com \
--cc=robin.randhawa@arm.com \
--cc=tj@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®