From: Tejun Heo <tj@kernel.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: rjw@sisk.pl, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, linaro-kernel@lists.linaro.org,
robin.randhawa@arm.com, Steve.Bannister@arm.com,
Liviu.Dudau@arm.com, charles.garcia-tobin@arm.com,
rickard.andersson@stericsson.com, fabio.baltieri@linaro.org
Subject: Re: [PATCH 1/3] workqueue: define mod_scheduled_delayed_work[_on]() helpers
Date: Wed, 27 Feb 2013 07:29:49 -0800 [thread overview]
Message-ID: <20130227152949.GD22383@htj.dyndns.org> (raw)
In-Reply-To: <CAKohponvsL7BsabqkLS6W4EHx1N7=Ua04JwZksztPqwzW2ze=w@mail.gmail.com>
Hello, Viresh.
On Wed, Feb 27, 2013 at 08:44:52PM +0530, Viresh Kumar wrote:
> To keep things aligned probably i should replace schedule_work() with
> queue_work() and use system_wq there too..
Yeah, that probably is more preferable. There are codes like the
following in kernel and they always irk me.
if (custom_wq)
queue_work();
else
schedule_work();
It's just silly.
Thanks.
--
tejun
next prev parent reply other threads:[~2013-02-27 15:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 11:29 Viresh Kumar
2013-02-27 11:29 ` [PATCH 2/3] cpufreq: ondemand: Don't update sample_type if we don't evaluate load again Viresh Kumar
2013-02-27 11:29 ` [PATCH 3/3] cpufreq: governors: Avoid unnecessary per cpu timer interrupts Viresh Kumar
2013-02-27 12:20 ` [PATCH 1/3] workqueue: define mod_scheduled_delayed_work[_on]() helpers Viresh Kumar
2013-02-27 15:10 ` Tejun Heo
2013-02-27 15:14 ` Viresh Kumar
2013-02-27 15:29 ` Tejun Heo [this message]
2013-03-11 23:28 ` Rafael J. Wysocki
2013-03-12 0:54 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130227152949.GD22383@htj.dyndns.org \
--to=tj@kernel.org \
--cc=Liviu.Dudau@arm.com \
--cc=Steve.Bannister@arm.com \
--cc=charles.garcia-tobin@arm.com \
--cc=cpufreq@vger.kernel.org \
--cc=fabio.baltieri@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rickard.andersson@stericsson.com \
--cc=rjw@sisk.pl \
--cc=robin.randhawa@arm.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®