[PATCH] regulator: qcom-smd: make smd_vreg_rpm static

[PATCH] regulator: qcom-smd: make smd_vreg_rpm static

[Min-Hua Chen]

Since smd_vreg_rpm is used only in
drivers/regulator/qcom_smd-regulator.c, make it static and fix the
following sparse warning:

drivers/regulator/qcom_smd-regulator.c:14:21: sparse: warning:
symbol 'smd_vreg_rpm' was not declared. Should it be static?

No functional changes intended.

Fixes: 5df3b41bd6b5 ("regulator: qcom_smd: Keep one rpm handle for all vregs")
Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com>
---
 drivers/regulator/qcom_smd-regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/qcom_smd-regulator.c b/drivers/regulator/qcom_smd-regulator.c
index 28e7ce60cb61..25ed9f713974 100644
--- a/drivers/regulator/qcom_smd-regulator.c
+++ b/drivers/regulator/qcom_smd-regulator.c
@@ -11,7 +11,7 @@
 #include <linux/regulator/of_regulator.h>
 #include <linux/soc/qcom/smd-rpm.h>
 
-struct qcom_smd_rpm *smd_vreg_rpm;
+static struct qcom_smd_rpm *smd_vreg_rpm;
 
 struct qcom_rpm_reg {
 	struct device *dev;
-- 
2.43.0

Re: [PATCH] regulator: qcom-smd: make smd_vreg_rpm static

[Dmitry Baryshkov]

On Fri, Sep 27, 2024 at 07:10:36AM GMT, Min-Hua Chen wrote:
> Since smd_vreg_rpm is used only in
> drivers/regulator/qcom_smd-regulator.c, make it static and fix the
> following sparse warning:
> 
> drivers/regulator/qcom_smd-regulator.c:14:21: sparse: warning:
> symbol 'smd_vreg_rpm' was not declared. Should it be static?
> 
> No functional changes intended.
> 
> Fixes: 5df3b41bd6b5 ("regulator: qcom_smd: Keep one rpm handle for all vregs")
> Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com>
> ---
>  drivers/regulator/qcom_smd-regulator.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

-- 
With best wishes
Dmitry

Re: [PATCH] regulator: qcom-smd: make smd_vreg_rpm static

[Mark Brown]

On Fri, 27 Sep 2024 07:10:36 +0800, Min-Hua Chen wrote:
> Since smd_vreg_rpm is used only in
> drivers/regulator/qcom_smd-regulator.c, make it static and fix the
> following sparse warning:
> 
> drivers/regulator/qcom_smd-regulator.c:14:21: sparse: warning:
> symbol 'smd_vreg_rpm' was not declared. Should it be static?
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: qcom-smd: make smd_vreg_rpm static
      commit: 18be43aca2c0ec475037923a8086d0a29fcc9d16

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark