* [PATCH] x86: acer-wmi: remove unused mocros
@ 2024-10-14 18:38 Ba Jing
2024-10-16 12:22 ` Ilpo Järvinen
0 siblings, 1 reply; 2+ messages in thread
From: Ba Jing @ 2024-10-14 18:38 UTC (permalink / raw)
To: jlee; +Cc: hdegoede, ilpo.jarvinen, platform-driver-x86, linux-kernel, Ba Jing
After reviewing the code, it was found that these macros are never
referenced in the code and are all set to 0. They should be removed.
Signed-off-by: Ba Jing <bajing@cmss.chinamobile.com>
---
drivers/platform/x86/acer-wmi.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index 7169b84ccdb6..ae916a7a01ca 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -258,11 +258,6 @@ enum interface_flags {
ACER_WMID_v2,
};
-#define ACER_DEFAULT_WIRELESS 0
-#define ACER_DEFAULT_BLUETOOTH 0
-#define ACER_DEFAULT_MAILLED 0
-#define ACER_DEFAULT_THREEG 0
-
static int max_brightness = 0xF;
static int mailled = -1;
--
2.33.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] x86: acer-wmi: remove unused mocros
2024-10-14 18:38 [PATCH] x86: acer-wmi: remove unused mocros Ba Jing
@ 2024-10-16 12:22 ` Ilpo Järvinen
0 siblings, 0 replies; 2+ messages in thread
From: Ilpo Järvinen @ 2024-10-16 12:22 UTC (permalink / raw)
To: jlee, Ba Jing; +Cc: hdegoede, platform-driver-x86, linux-kernel
On Tue, 15 Oct 2024 02:38:56 +0800, Ba Jing wrote:
> After reviewing the code, it was found that these macros are never
> referenced in the code and are all set to 0. They should be removed.
>
>
Thank you for your contribution, it has been applied to my local
review-ilpo branch. Note it will show up in the public
platform-drivers-x86/review-ilpo branch only once I've pushed my
local branch there, which might take a while.
The list of commits applied:
[1/1] x86: acer-wmi: remove unused mocros
commit: 7dd1233931271f4c7efd5456aaa6e8bb8f77b5e8
--
i.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-16 12:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-14 18:38 [PATCH] x86: acer-wmi: remove unused mocros Ba Jing
2024-10-16 12:22 ` Ilpo Järvinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®