* [PATCH V5][next] Bluetooth: btintel_pcie: Remove structurally deadcode
@ 2024-10-16 21:39 Everest K.C.
2024-10-17 16:00 ` patchwork-bot+bluetooth
0 siblings, 1 reply; 2+ messages in thread
From: Everest K.C. @ 2024-10-16 21:39 UTC (permalink / raw)
To: marcel, luiz.dentz
Cc: Everest K.C.,
skhan, dan.carpenter, kernel-janitors, linux-bluetooth,
linux-kernel
The switch case statement has a default branch. Thus, the return
statement at the end of the function can never be reached.
Fix it by removing the return statement at the end of the
function.
This issue was reported by Coverity Scan.
Signed-off-by: Everest K.C. <everestkc@everestkc.com.np>
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
---
V4 -> V5: - Fixed typo in the subject
- Removed Fixes tag as this is a code cleanup
V3 -> V4: - Fixed typo in the subject
V2 -> V3: - Removed that the change was successfully built
- Removed the link to Coverity Scan report
V1 -> V2: - Changed "Fixing" to "Fix" in the changelog
- Added that the change was successfully built
- Added kernel-janitors mailing list to CC
drivers/bluetooth/btintel_pcie.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c
index e4ae8c898dfd..660496e55276 100644
--- a/drivers/bluetooth/btintel_pcie.c
+++ b/drivers/bluetooth/btintel_pcie.c
@@ -391,7 +391,6 @@ static inline char *btintel_pcie_alivectxt_state2str(u32 alive_intr_ctxt)
default:
return "unknown";
}
- return "null";
}
/* This function handles the MSI-X interrupt for gp0 cause (bit 0 in
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH V5][next] Bluetooth: btintel_pcie: Remove structurally deadcode
2024-10-16 21:39 [PATCH V5][next] Bluetooth: btintel_pcie: Remove structurally deadcode Everest K.C.
@ 2024-10-17 16:00 ` patchwork-bot+bluetooth
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+bluetooth @ 2024-10-17 16:00 UTC (permalink / raw)
To: Everest K.C.
Cc: marcel, luiz.dentz, skhan, dan.carpenter, kernel-janitors,
linux-bluetooth, linux-kernel
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
On Wed, 16 Oct 2024 15:39:55 -0600 you wrote:
> The switch case statement has a default branch. Thus, the return
> statement at the end of the function can never be reached.
> Fix it by removing the return statement at the end of the
> function.
>
> This issue was reported by Coverity Scan.
>
> [...]
Here is the summary with links:
- [V5,next] Bluetooth: btintel_pcie: Remove structurally deadcode
https://git.kernel.org/bluetooth/bluetooth-next/c/8f66f6498463
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-17 16:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-16 21:39 [PATCH V5][next] Bluetooth: btintel_pcie: Remove structurally deadcode Everest K.C.
2024-10-17 16:00 ` patchwork-bot+bluetooth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®