* [net-next v2] net: ftgmac100: correct the phy interface of NC-SI mode
@ 2024-10-18 5:33 Jacky Chou
2024-10-18 18:09 ` Andrew Lunn
2024-10-20 16:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Jacky Chou @ 2024-10-18 5:33 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni, jacky_chou, u.kleine-koenig,
jacob.e.keller, netdev, linux-kernel
In NC-SI specification, NC-SI is using RMII, not MII.
Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com>
---
v2:
- Correct the subject
---
drivers/net/ethernet/faraday/ftgmac100.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c
index e64a90a91dd4..10c1a2f11000 100644
--- a/drivers/net/ethernet/faraday/ftgmac100.c
+++ b/drivers/net/ethernet/faraday/ftgmac100.c
@@ -1913,7 +1913,7 @@ static int ftgmac100_probe(struct platform_device *pdev)
goto err_phy_connect;
}
err = phy_connect_direct(netdev, phydev, ftgmac100_adjust_link,
- PHY_INTERFACE_MODE_MII);
+ PHY_INTERFACE_MODE_RMII);
if (err) {
dev_err(&pdev->dev, "Connecting PHY failed\n");
goto err_phy_connect;
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [net-next v2] net: ftgmac100: correct the phy interface of NC-SI mode
2024-10-18 5:33 [net-next v2] net: ftgmac100: correct the phy interface of NC-SI mode Jacky Chou
@ 2024-10-18 18:09 ` Andrew Lunn
2024-10-20 16:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2024-10-18 18:09 UTC (permalink / raw)
To: Jacky Chou
Cc: davem, edumazet, kuba, pabeni, u.kleine-koenig, jacob.e.keller,
netdev, linux-kernel
On Fri, Oct 18, 2024 at 01:33:31PM +0800, Jacky Chou wrote:
> In NC-SI specification, NC-SI is using RMII, not MII.
>
> Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [net-next v2] net: ftgmac100: correct the phy interface of NC-SI mode
2024-10-18 5:33 [net-next v2] net: ftgmac100: correct the phy interface of NC-SI mode Jacky Chou
2024-10-18 18:09 ` Andrew Lunn
@ 2024-10-20 16:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-10-20 16:10 UTC (permalink / raw)
To: Jacky Chou
Cc: davem, edumazet, kuba, pabeni, u.kleine-koenig, jacob.e.keller,
netdev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Andrew Lunn <andrew@lunn.ch>:
On Fri, 18 Oct 2024 13:33:31 +0800 you wrote:
> In NC-SI specification, NC-SI is using RMII, not MII.
>
> Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com>
> ---
> v2:
> - Correct the subject
>
> [...]
Here is the summary with links:
- [net-next,v2] net: ftgmac100: correct the phy interface of NC-SI mode
https://git.kernel.org/netdev/net-next/c/906c68657850
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-20 16:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-18 5:33 [net-next v2] net: ftgmac100: correct the phy interface of NC-SI mode Jacky Chou
2024-10-18 18:09 ` Andrew Lunn
2024-10-20 16:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®