* [tip: timers/core] timekeeping: Don't stop time readers across hard_pps() update
@ 2024-10-25 18:01 tip-bot2 for Thomas Gleixner
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot2 for Thomas Gleixner @ 2024-10-25 18:01 UTC (permalink / raw)
To: linux-tip-commits; +Cc: Thomas Gleixner, Anna-Maria Behnsen, x86, linux-kernel
The following commit has been merged into the timers/core branch of tip:
Commit-ID: 886150fb4f19505b8f9d26201d7671b25c233a9f
Gitweb: https://git.kernel.org/tip/886150fb4f19505b8f9d26201d7671b25c233a9f
Author: Thomas Gleixner <tglx@linutronix.de>
AuthorDate: Wed, 09 Oct 2024 10:28:55 +02:00
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Fri, 25 Oct 2024 19:49:13 +02:00
timekeeping: Don't stop time readers across hard_pps() update
hard_pps() update does not modify anything which might be required by time
readers so forcing readers out of the way during the update is a pointless
exercise.
The interaction with adjtimex() and timekeeper updates which call into the
NTP code is properly serialized by timekeeper_lock.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Anna-Maria Behnsen <anna-maria@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/20241009-devel-anna-maria-b4-timers-ptp-timekeeping-v2-2-554456a44a15@linutronix.de
---
kernel/time/timekeeping.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
index 2bc3542..ff98a0b 100644
--- a/kernel/time/timekeeping.c
+++ b/kernel/time/timekeeping.c
@@ -2746,11 +2746,7 @@ void hardpps(const struct timespec64 *phase_ts, const struct timespec64 *raw_ts)
unsigned long flags;
raw_spin_lock_irqsave(&timekeeper_lock, flags);
- write_seqcount_begin(&tk_core.seq);
-
__hardpps(phase_ts, raw_ts);
-
- write_seqcount_end(&tk_core.seq);
raw_spin_unlock_irqrestore(&timekeeper_lock, flags);
}
EXPORT_SYMBOL(hardpps);
^ permalink raw reply [flat|nested] 2+ messages in thread
* [tip: timers/core] timekeeping: Don't stop time readers across hard_pps() update
@ 2024-10-25 14:54 tip-bot2 for Thomas Gleixner
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot2 for Thomas Gleixner @ 2024-10-25 14:54 UTC (permalink / raw)
To: linux-tip-commits; +Cc: Thomas Gleixner, Anna-Maria Behnsen, x86, linux-kernel
The following commit has been merged into the timers/core branch of tip:
Commit-ID: 708573a8f75ec94e9063d6c47e0571bcf39f0bb0
Gitweb: https://git.kernel.org/tip/708573a8f75ec94e9063d6c47e0571bcf39f0bb0
Author: Thomas Gleixner <tglx@linutronix.de>
AuthorDate: Wed, 09 Oct 2024 10:28:55 +02:00
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Fri, 25 Oct 2024 16:41:11 +02:00
timekeeping: Don't stop time readers across hard_pps() update
From: Thomas Gleixner <tglx@linutronix.de>
hard_pps() update does not modify anything which might be required by time
readers so forcing readers out of the way during the update is a pointless
exercise.
The interaction with adjtimex() and timekeeper updates which call into the
NTP code is properly serialized by timekeeper_lock.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Anna-Maria Behnsen <anna-maria@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/20241009-devel-anna-maria-b4-timers-ptp-timekeeping-v2-2-554456a44a15@linutronix.de
---
kernel/time/timekeeping.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
index 2bc3542..ff98a0b 100644
--- a/kernel/time/timekeeping.c
+++ b/kernel/time/timekeeping.c
@@ -2746,11 +2746,7 @@ void hardpps(const struct timespec64 *phase_ts, const struct timespec64 *raw_ts)
unsigned long flags;
raw_spin_lock_irqsave(&timekeeper_lock, flags);
- write_seqcount_begin(&tk_core.seq);
-
__hardpps(phase_ts, raw_ts);
-
- write_seqcount_end(&tk_core.seq);
raw_spin_unlock_irqrestore(&timekeeper_lock, flags);
}
EXPORT_SYMBOL(hardpps);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-25 18:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-25 18:01 [tip: timers/core] timekeeping: Don't stop time readers across hard_pps() update tip-bot2 for Thomas Gleixner
-- strict thread matches above, loose matches on Subject: below --
2024-10-25 14:54 tip-bot2 for Thomas Gleixner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®