* [PATCH net-next] net: amd8111e: Remove duplicate definition of PCI_VENDOR_ID_AMD
@ 2024-10-21 15:38 Yazen Ghannam
2024-10-21 15:47 ` Kalesh Anakkur Purayil
2024-10-28 23:00 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Yazen Ghannam @ 2024-10-21 15:38 UTC (permalink / raw)
To: andrew+netdev, davem, edumazet, kuba, pabeni
Cc: linux-kernel, netdev, Yazen Ghannam
The AMD PCI vendor ID is already defined in <linux/pci_ids.h>.
Remove this local definition as it is not needed.
Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
---
drivers/net/ethernet/amd/amd8111e.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/amd/amd8111e.h b/drivers/net/ethernet/amd/amd8111e.h
index 305232f5476d..e4ee4c28800c 100644
--- a/drivers/net/ethernet/amd/amd8111e.h
+++ b/drivers/net/ethernet/amd/amd8111e.h
@@ -550,7 +550,6 @@ typedef enum {
/* Driver definitions */
-#define PCI_VENDOR_ID_AMD 0x1022
#define PCI_DEVICE_ID_AMD8111E_7462 0x7462
#define MAX_UNITS 8 /* Maximum number of devices possible */
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: amd8111e: Remove duplicate definition of PCI_VENDOR_ID_AMD
2024-10-21 15:38 [PATCH net-next] net: amd8111e: Remove duplicate definition of PCI_VENDOR_ID_AMD Yazen Ghannam
@ 2024-10-21 15:47 ` Kalesh Anakkur Purayil
2024-10-28 23:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Kalesh Anakkur Purayil @ 2024-10-21 15:47 UTC (permalink / raw)
To: Yazen Ghannam
Cc: andrew+netdev, davem, edumazet, kuba, pabeni, linux-kernel, netdev
[-- Attachment #1: Type: text/plain, Size: 363 bytes --]
On Mon, Oct 21, 2024 at 9:08 PM Yazen Ghannam <yazen.ghannam@amd.com> wrote:
>
> The AMD PCI vendor ID is already defined in <linux/pci_ids.h>.
>
> Remove this local definition as it is not needed.
>
> Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
LGTM
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
--
Regards,
Kalesh A P
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4239 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: amd8111e: Remove duplicate definition of PCI_VENDOR_ID_AMD
2024-10-21 15:38 [PATCH net-next] net: amd8111e: Remove duplicate definition of PCI_VENDOR_ID_AMD Yazen Ghannam
2024-10-21 15:47 ` Kalesh Anakkur Purayil
@ 2024-10-28 23:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-10-28 23:00 UTC (permalink / raw)
To: Yazen Ghannam
Cc: andrew+netdev, davem, edumazet, kuba, pabeni, linux-kernel,
netdev, yazen.ghannam
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 21 Oct 2024 15:38:25 +0000 you wrote:
> The AMD PCI vendor ID is already defined in <linux/pci_ids.h>.
>
> Remove this local definition as it is not needed.
>
> Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
> ---
> drivers/net/ethernet/amd/amd8111e.h | 1 -
> 1 file changed, 1 deletion(-)
Here is the summary with links:
- [net-next] net: amd8111e: Remove duplicate definition of PCI_VENDOR_ID_AMD
https://git.kernel.org/netdev/net-next/c/9f6cb3197973
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-28 23:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-21 15:38 [PATCH net-next] net: amd8111e: Remove duplicate definition of PCI_VENDOR_ID_AMD Yazen Ghannam
2024-10-21 15:47 ` Kalesh Anakkur Purayil
2024-10-28 23:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®