From: "Rob Herring (Arm)" <robh@kernel.org>
To: Janne Grunau <j@jannau.net>
Cc: asahi@lists.linux.dev, Hector Martin <marcan@marcan.st>,
Sven Peter <sven@svenpeter.dev>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Mark Brown <broonie@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Krzysztof Kozlowski <krzk+dt@kernel.org>
Subject: Re: [PATCH v2 1/3] dt-bindings: spi: apple,spi: Add binding for Apple SPI controllers
Date: Fri, 01 Nov 2024 10:43:13 -0500 [thread overview]
Message-ID: <173047579349.3488175.222264580667894425.robh@kernel.org> (raw)
In-Reply-To: <20241101-asahi-spi-v2-1-763a8a84d834@jannau.net>
On Fri, 01 Nov 2024 15:25:03 +0100, Janne Grunau wrote:
> From: Hector Martin <marcan@marcan.st>
>
> The Apple SPI controller is present in SoCs such as the M1 (t8103) and
> M1 Pro/Max (t600x). This controller uses one IRQ and one clock, and
> doesn't need any special properties, so the binding is trivial.
>
> Signed-off-by: Hector Martin <marcan@marcan.st>
> Signed-off-by: Janne Grunau <j@jannau.net>
> ---
> .../devicetree/bindings/spi/apple,spi.yaml | 62 ++++++++++++++++++++++
> 1 file changed, 62 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
./Documentation/devicetree/bindings/spi/apple,spi.yaml:10:11: [error] string value is redundantly quoted with any quotes (quoted-strings)
dtschema/dtc warnings/errors:
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241101-asahi-spi-v2-1-763a8a84d834@jannau.net
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2024-11-01 15:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 14:25 [PATCH v2 0/3] Apple SPI controller driver Janne Grunau via B4 Relay
2024-11-01 14:25 ` [PATCH v2 1/3] dt-bindings: spi: apple,spi: Add binding for Apple SPI controllers Janne Grunau via B4 Relay
2024-11-01 15:43 ` Rob Herring (Arm) [this message]
2024-11-01 14:25 ` [PATCH v2 2/3] spi: apple: Add driver for Apple SPI controller Janne Grunau via B4 Relay
2024-11-01 15:59 ` Christophe JAILLET
2024-11-01 16:08 ` Mark Brown
2024-11-01 16:19 ` Janne Grunau
2024-11-01 16:27 ` Mark Brown
2024-11-01 16:39 ` Janne Grunau
2024-11-01 14:25 ` [PATCH v2 3/3] MAINTAINERS: Add apple-spi driver & binding files Janne Grunau via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173047579349.3488175.222264580667894425.robh@kernel.org \
--to=robh@kernel.org \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j@jannau.net \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®