From: Mark Brown <broonie@kernel.org>
To: j@jannau.net
Cc: Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] spi: apple: Add driver for Apple SPI controller
Date: Fri, 1 Nov 2024 16:08:20 +0000 [thread overview]
Message-ID: <e3008c6b-ba71-46cf-810b-053dbafe2cfb@sirena.org.uk> (raw)
In-Reply-To: <20241101-asahi-spi-v2-2-763a8a84d834@jannau.net>
[-- Attachment #1: Type: text/plain, Size: 800 bytes --]
On Fri, Nov 01, 2024 at 03:25:04PM +0100, Janne Grunau via B4 Relay wrote:
> transfer, most of which we do not use right now. Hardware CS control
> is available, but we haven't found a way to make it stay low across
> multiple logical transfers, so we just use software CS control for now.
It is extremely common for hardware CS control to not support multiple
transfers, I wouldn't be surprised if it's simply not possible. We
could potentially use it with compatible messages it seems dubious that
it'd be worth the time/effort of checking and using it only some of the
time.
> +++ b/drivers/spi/spi-apple.c
> @@ -0,0 +1,531 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Apple SoC SPI device driver
> + *
Please make the entire comment block a C++ one so things look more
intentional.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-11-01 16:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 14:25 [PATCH v2 0/3] Apple SPI controller driver Janne Grunau via B4 Relay
2024-11-01 14:25 ` [PATCH v2 1/3] dt-bindings: spi: apple,spi: Add binding for Apple SPI controllers Janne Grunau via B4 Relay
2024-11-01 15:43 ` Rob Herring (Arm)
2024-11-01 14:25 ` [PATCH v2 2/3] spi: apple: Add driver for Apple SPI controller Janne Grunau via B4 Relay
2024-11-01 15:59 ` Christophe JAILLET
2024-11-01 16:08 ` Mark Brown [this message]
2024-11-01 16:19 ` Janne Grunau
2024-11-01 16:27 ` Mark Brown
2024-11-01 16:39 ` Janne Grunau
2024-11-01 14:25 ` [PATCH v2 3/3] MAINTAINERS: Add apple-spi driver & binding files Janne Grunau via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3008c6b-ba71-46cf-810b-053dbafe2cfb@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j@jannau.net \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=robh@kernel.org \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®