* [PATCH] mfd: rt5033: Fix missing regmap_del_irq_chip()
@ 2024-10-30 15:41 Zhang Changzhong
2024-11-06 8:04 ` (subset) " Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Zhang Changzhong @ 2024-10-30 15:41 UTC (permalink / raw)
To: Lee Jones, Beomho Seo, Chanwoo Choi, linux-kernel
Cc: Zhang Changzhong, Wei Yongjun
Fix missing call to regmap_del_irq_chip() in error handling path by
using devm_regmap_add_irq_chip().
Fixes: 0b271258544b ("mfd: rt5033: Add Richtek RT5033 driver core.")
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
---
drivers/mfd/rt5033.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/rt5033.c b/drivers/mfd/rt5033.c
index 7e23ab3..84ebc96 100644
--- a/drivers/mfd/rt5033.c
+++ b/drivers/mfd/rt5033.c
@@ -81,8 +81,8 @@ static int rt5033_i2c_probe(struct i2c_client *i2c)
chip_rev = dev_id & RT5033_CHIP_REV_MASK;
dev_info(&i2c->dev, "Device found (rev. %d)\n", chip_rev);
- ret = regmap_add_irq_chip(rt5033->regmap, rt5033->irq,
- IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
+ ret = devm_regmap_add_irq_chip(rt5033->dev, rt5033->regmap,
+ rt5033->irq, IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
0, &rt5033_irq_chip, &rt5033->irq_data);
if (ret) {
dev_err(&i2c->dev, "Failed to request IRQ %d: %d\n",
--
2.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: (subset) [PATCH] mfd: rt5033: Fix missing regmap_del_irq_chip()
2024-10-30 15:41 [PATCH] mfd: rt5033: Fix missing regmap_del_irq_chip() Zhang Changzhong
@ 2024-11-06 8:04 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2024-11-06 8:04 UTC (permalink / raw)
To: Lee Jones, Beomho Seo, Chanwoo Choi, linux-kernel, Zhang Changzhong
Cc: Wei Yongjun
On Wed, 30 Oct 2024 23:41:06 +0800, Zhang Changzhong wrote:
> Fix missing call to regmap_del_irq_chip() in error handling path by
> using devm_regmap_add_irq_chip().
>
>
Applied, thanks!
[1/1] mfd: rt5033: Fix missing regmap_del_irq_chip()
commit: d256d612f47529ed0b332298e2d5ea981a4dd5b8
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-11-06 8:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-30 15:41 [PATCH] mfd: rt5033: Fix missing regmap_del_irq_chip() Zhang Changzhong
2024-11-06 8:04 ` (subset) " Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®