From: "Rob Herring (Arm)" <robh@kernel.org>
To: Charles Wang <charles.goodix@gmail.com>
Cc: conor.dooley@microchip.com, linux-input@vger.kernel.org,
bentiss@kernel.org, linux-kernel@vger.kernel.org,
dmitry.torokhov@gmail.com, hbarnor@chromium.org,
devicetree@vger.kernel.org, dianders@chromium.org,
jikos@kernel.org, krzk@kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: input: Goodix GT7986U SPI HID Touchscreen
Date: Fri, 08 Nov 2024 07:33:34 -0600 [thread overview]
Message-ID: <173107281349.1752060.15353696141928017835.robh@kernel.org> (raw)
In-Reply-To: <20241108120311.87795-2-charles.goodix@gmail.com>
On Fri, 08 Nov 2024 20:03:10 +0800, Charles Wang wrote:
> The Goodix GT7986U touch controller report touch data according to the
> HID protocol through the SPI bus. However, it is incompatible with
> Microsoft's HID-over-SPI protocol.
>
> NOTE: these bindings are distinct from the bindings used with the
> GT7986U when the chip is running I2C firmware. For some background,
> see discussion on the mailing lists in the thread:
>
> https://lore.kernel.org/r/20241018020815.3098263-2-charles.goodix@gmail.com
>
> Signed-off-by: Charles Wang <charles.goodix@gmail.com>
> ---
> .../bindings/input/goodix,gt7986u-spifw.yaml | 75 +++++++++++++++++++
> 1 file changed, 75 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/input/goodix,gt7986u-spifw.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
./Documentation/devicetree/bindings/input/goodix,gt7986u-spifw.yaml:16:7: [error] syntax error: mapping values are not allowed here (syntax)
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/input/goodix,gt7986u-spifw.yaml: ignoring, error parsing file
./Documentation/devicetree/bindings/input/goodix,gt7986u-spifw.yaml:16:7: mapping values are not allowed in this context
make[2]: *** Deleting file 'Documentation/devicetree/bindings/input/goodix,gt7986u-spifw.example.dts'
Documentation/devicetree/bindings/input/goodix,gt7986u-spifw.yaml:16:7: mapping values are not allowed in this context
make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/input/goodix,gt7986u-spifw.example.dts] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1442: dt_binding_check] Error 2
make: *** [Makefile:224: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241108120311.87795-2-charles.goodix@gmail.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2024-11-08 13:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 12:03 [PATCH v3 0/2] " Charles Wang
2024-11-08 12:03 ` [PATCH v3 1/2] " Charles Wang
2024-11-08 13:33 ` Rob Herring (Arm) [this message]
2024-11-08 15:13 ` Doug Anderson
2024-11-11 3:03 ` Charles Wang
2024-11-08 16:10 ` Rob Herring
2024-11-11 3:07 ` Charles Wang
2024-11-08 12:03 ` [PATCH v3 2/2] dt-bindings: input: gt7986u-spifw: Remove hid-report-addr property Charles Wang
2024-11-08 13:33 ` Rob Herring (Arm)
2024-11-08 16:13 ` Rob Herring
2024-11-11 3:32 ` Charles Wang
2024-11-08 15:11 ` [PATCH v3 0/2] dt-bindings: input: Goodix GT7986U SPI HID Touchscreen Doug Anderson
2024-11-11 2:22 ` Charles Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173107281349.1752060.15353696141928017835.robh@kernel.org \
--to=robh@kernel.org \
--cc=bentiss@kernel.org \
--cc=charles.goodix@gmail.com \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=hbarnor@chromium.org \
--cc=jikos@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®