mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Charles Wang <charles.goodix@gmail.com>
Cc: bentiss@kernel.org, linux-kernel@vger.kernel.org,
	 conor.dooley@microchip.com, hbarnor@chromium.org,
	krzk@kernel.org,  dianders@chromium.org,
	linux-input@vger.kernel.org,  dmitry.torokhov@gmail.com,
	jikos@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 2/2] dt-bindings: input: gt7986u-spifw: Remove hid-report-addr property
Date: Fri, 08 Nov 2024 07:33:36 -0600	[thread overview]
Message-ID: <173107281430.1752099.17871606474453144556.robh@kernel.org> (raw)
In-Reply-To: <20241108120311.87795-3-charles.goodix@gmail.com>


On Fri, 08 Nov 2024 20:03:11 +0800, Charles Wang wrote:
> Since all boards use the same address, drop the goodix,hid-report-addr
> property and hardcode it in the driver as a default value.
> 
> Signed-off-by: Charles Wang <charles.goodix@gmail.com>
> ---
>  .../devicetree/bindings/input/goodix,gt7986u-spifw.yaml    | 7 -------
>  1 file changed, 7 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:


doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241108120311.87795-3-charles.goodix@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2024-11-08 13:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-08 12:03 [PATCH v3 0/2] dt-bindings: input: Goodix GT7986U SPI HID Touchscreen Charles Wang
2024-11-08 12:03 ` [PATCH v3 1/2] " Charles Wang
2024-11-08 13:33   ` Rob Herring (Arm)
2024-11-08 15:13     ` Doug Anderson
2024-11-11  3:03       ` Charles Wang
2024-11-08 16:10   ` Rob Herring
2024-11-11  3:07     ` Charles Wang
2024-11-08 12:03 ` [PATCH v3 2/2] dt-bindings: input: gt7986u-spifw: Remove hid-report-addr property Charles Wang
2024-11-08 13:33   ` Rob Herring (Arm) [this message]
2024-11-08 16:13   ` Rob Herring
2024-11-11  3:32     ` Charles Wang
2024-11-08 15:11 ` [PATCH v3 0/2] dt-bindings: input: Goodix GT7986U SPI HID Touchscreen Doug Anderson
2024-11-11  2:22   ` Charles Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=173107281430.1752099.17871606474453144556.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=bentiss@kernel.org \
    --cc=charles.goodix@gmail.com \
    --cc=conor.dooley@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hbarnor@chromium.org \
    --cc=jikos@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®