From: Catalin Marinas <catalin.marinas@arm.com>
To: mhiramat@kernel.org, oleg@redhat.com, peterz@infradead.org,
will@kernel.org, mark.rutland@arm.com,
Liao Chang <liaochang1@huawei.com>
Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: uprobes: Optimize cache flushes for xol slot
Date: Fri, 8 Nov 2024 16:49:53 +0000 [thread overview]
Message-ID: <173108456812.1559945.17269799494713828811.b4-ty@arm.com> (raw)
In-Reply-To: <20240919121719.2148361-1-liaochang1@huawei.com>
On Thu, 19 Sep 2024 12:17:19 +0000, Liao Chang wrote:
> The profiling of single-thread selftests bench reveals a bottlenect in
> caches_clean_inval_pou() on ARM64. On my local testing machine, this
> function takes approximately 34% of CPU cycles for trig-uprobe-nop and
> trig-uprobe-push.
>
> This patch add a check to avoid unnecessary cache flush when writing
> instruction to the xol slot. If the instruction is same with the
> existing instruction in slot, there is no need to synchronize D/I cache.
> Since xol slot allocation and updates occur on the hot path of uprobe
> handling, The upstream kernel running on Kunpeng916 (Hi1616), 4 NUMA
> nodes, 64 cores@ 2.4GHz reveals this optimization has obvious gain for
> nop and push testcases.
>
> [...]
Applied to arm64 (for-next/misc), thanks!
[1/1] arm64: uprobes: Optimize cache flushes for xol slot
https://git.kernel.org/arm64/c/bdf94836c22a
--
Catalin
prev parent reply other threads:[~2024-11-08 16:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-19 12:17 Liao Chang
2024-09-19 14:18 ` Oleg Nesterov
2024-09-20 8:58 ` Liao, Chang
2024-09-20 11:03 ` Oleg Nesterov
2024-09-20 15:32 ` Catalin Marinas
2024-09-20 17:32 ` Oleg Nesterov
2024-09-22 14:09 ` Will Deacon
2024-09-22 14:39 ` Oleg Nesterov
2024-09-23 11:16 ` Liao, Chang
2024-09-23 1:57 ` Liao, Chang
2024-09-23 7:18 ` Will Deacon
2024-09-23 10:52 ` Oleg Nesterov
2024-09-26 12:06 ` Liao, Chang
2024-09-26 16:08 ` Oleg Nesterov
2024-09-23 11:16 ` Liao, Chang
2024-09-23 16:03 ` Catalin Marinas
2024-11-06 9:55 ` Liao, Chang
2024-11-07 18:35 ` Catalin Marinas
2024-11-08 16:49 ` Catalin Marinas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173108456812.1559945.17269799494713828811.b4-ty@arm.com \
--to=catalin.marinas@arm.com \
--cc=liaochang1@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®