[PATCH 0/2] arm64: dts: qcom: sdm450-lenovo-tbx605f: add panel nodes

[PATCH 0/2] arm64: dts: qcom: sdm450-lenovo-tbx605f: add panel nodes

[Neil Armstrong]

Add the necessary nodes to enable the DSI Panel on the Lenovo
Lenovo Smart Tab M10.

The panel is already upstream with:
https://lore.kernel.org/all/20240828-topic-sdm450-upstream-tbx605f-panel-v3-0-b792f93e1d6b@linaro.org/

And the LAB-IBB bindings changes was sent at:
https://lore.kernel.org/all/20241115-topic-sdm450-upstream-lab-ibb-bindings-v1-1-1f4bff4583b0@linaro.org/

Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
Neil Armstrong (2):
      arm64: dts: qcom: pmi8950: add LAB-IBB nodes
      arm64: dts: qcom: sdm450-lenovo-tbx605f: add DSI panel nodes

 arch/arm64/boot/dts/qcom/pmi8950.dtsi              | 17 ++++
 arch/arm64/boot/dts/qcom/sdm450-lenovo-tbx605f.dts | 97 ++++++++++++++++++++++
 2 files changed, 114 insertions(+)
---
base-commit: 2d5404caa8c7bb5c4e0435f94b28834ae5456623
change-id: 20241115-topic-sdm450-upstream-lab-ibb-5acee981556c

Best regards,
-- 
Neil Armstrong <neil.armstrong@linaro.org>

[PATCH 1/2] arm64: dts: qcom: pmi8950: add LAB-IBB nodes

[Neil Armstrong]

Add the PMI8950 LAB-IBB regulator nodes, with the
PMI8998 compatible as fallback.

The LAB-IBB regulators are used as panels supplies
on existing phones or tablets.

Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
 arch/arm64/boot/dts/qcom/pmi8950.dtsi | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/pmi8950.dtsi b/arch/arm64/boot/dts/qcom/pmi8950.dtsi
index 4aff437263a2930489216c81c53e0d7ef7d14b35..3d3b1cd97cc3d04b2c5a78c06fbeb3fee3c5af8d 100644
--- a/arch/arm64/boot/dts/qcom/pmi8950.dtsi
+++ b/arch/arm64/boot/dts/qcom/pmi8950.dtsi
@@ -84,6 +84,23 @@ pmic@3 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
+		labibb {
+			compatible = "qcom,pmi8950-lab-ibb",
+				     "qcom,pmi8998-lab-ibb";
+
+			ibb: ibb {
+				interrupts = <0x3 0xdc 0x2 IRQ_TYPE_EDGE_RISING>,
+					     <0x3 0xdc 0x0 IRQ_TYPE_LEVEL_LOW>;
+				interrupt-names = "sc-err", "ocp";
+			};
+
+			lab: lab {
+				interrupts = <0x3 0xde 0x1 IRQ_TYPE_EDGE_RISING>,
+					     <0x3 0xde 0x0 IRQ_TYPE_LEVEL_LOW>;
+				interrupt-names = "sc-err", "ocp";
+			};
+		};
+
 		pmi8950_pwm: pwm {
 			compatible = "qcom,pmi8950-pwm";
 			#pwm-cells = <2>;

-- 
2.34.1

[PATCH 2/2] arm64: dts: qcom: sdm450-lenovo-tbx605f: add DSI panel nodes

[Neil Armstrong]

Add the necessary nodes to enable the DSI panel on the
Lenovo Smart Tab M10 tablet.

Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
 arch/arm64/boot/dts/qcom/sdm450-lenovo-tbx605f.dts | 97 ++++++++++++++++++++++
 1 file changed, 97 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm450-lenovo-tbx605f.dts b/arch/arm64/boot/dts/qcom/sdm450-lenovo-tbx605f.dts
index 175befc02b22f5df895e95d828edac35fbaed963..e80a89c59818573c7068c3adeaf51fd51defc7f0 100644
--- a/arch/arm64/boot/dts/qcom/sdm450-lenovo-tbx605f.dts
+++ b/arch/arm64/boot/dts/qcom/sdm450-lenovo-tbx605f.dts
@@ -46,6 +46,18 @@ other_ext_region@0 {
 		};
 	};
 
+	backlight: gpio-backlight {
+		compatible = "gpio-backlight";
+
+		gpios = <&tlmm 16 GPIO_ACTIVE_HIGH>;
+
+		default-on;
+
+		pinctrl-names = "default";
+		pinctrl-0 = <&backlight_enable_active>;
+		pinctrl-1 = <&backlight_enable_sleep>;
+	};
+
 	gpio-keys {
 		compatible = "gpio-keys";
 		key-volume-up {
@@ -63,6 +75,49 @@ vph_pwr: vph-pwr-regulator {
 	};
 };
 
+&mdss {
+	status = "okay";
+};
+
+&mdss_dsi0 {
+	vdda-supply = <&pm8953_s3>;
+	vddio-supply = <&pm8953_l6>;
+
+	status = "okay";
+
+	panel@0 {
+		compatible = "boe,tv101wum-ll2";
+		reg = <0>;
+
+		vsp-supply = <&lab>;
+		vsn-supply = <&ibb>;
+		reset-gpios = <&tlmm 61 GPIO_ACTIVE_LOW>;
+
+		backlight = <&backlight>;
+
+		pinctrl-names = "default";
+		pinctrl-0 = <&panel_reset_active>;
+		pinctrl-1 = <&panel_reset_sleep>;
+
+		port {
+			panel_in: endpoint {
+				remote-endpoint = <&mdss_dsi0_out>;
+			};
+		};
+	};
+};
+
+&mdss_dsi0_out {
+	remote-endpoint = <&panel_in>;
+	data-lanes = <0 1 2 3>;
+};
+
+&mdss_dsi0_phy {
+	vcca-supply = <&pm8953_l3>;
+
+	status = "okay";
+};
+
 &hsusb_phy {
 	vdd-supply = <&pm8953_l3>;
 	vdda-pll-supply = <&pm8953_l7>;
@@ -90,6 +145,18 @@ touchscreen@38 {
 	};
 };
 
+&ibb {
+	regulator-min-microvolt = <4600000>;
+	regulator-max-microvolt = <6000000>;
+	qcom,discharge-resistor-kohms = <32>;
+};
+
+&lab {
+	regulator-min-microvolt = <4600000>;
+	regulator-max-microvolt = <6000000>;
+	qcom,soft-start-us = <800>;
+};
+
 &pm8953_resin {
 	linux,code = <KEY_VOLUMEDOWN>;
 	status = "okay";
@@ -237,6 +304,36 @@ &sdhc_2 {
 &tlmm {
 	gpio-reserved-ranges = <0 4>, <135 4>;
 
+	backlight_enable_active: backlight-enable-active-state {
+		pins = "gpio16";
+		function = "gpio";
+		drive-strength = <8>;
+		bias-disable;
+		output-high;
+	};
+
+	backlight_enable_sleep: backlight-enable-sleep-state {
+		pins = "gpio16";
+		function = "gpio";
+		drive-strength = <2>;
+		bias-pull-down;
+	};
+
+	panel_reset_active: panel-reset-active-state {
+		pins = "gpio61";
+		function = "gpio";
+		drive-strength = <8>;
+		bias-disable;
+		output-high;
+	};
+
+	panel_reset_sleep: panel-reset-sleep-state {
+		pins = "gpio61";
+		function = "gpio";
+		drive-strength = <2>;
+		bias-pull-down;
+	};
+
 	ts_int_active: ts-int-active-state {
 		pins = "gpio65";
 		function = "gpio";

-- 
2.34.1

Re: [PATCH 1/2] arm64: dts: qcom: pmi8950: add LAB-IBB nodes

[Dmitry Baryshkov]

On Fri, Nov 15, 2024 at 11:20:53AM +0100, Neil Armstrong wrote:
> Add the PMI8950 LAB-IBB regulator nodes, with the
> PMI8998 compatible as fallback.
> 
> The LAB-IBB regulators are used as panels supplies
> on existing phones or tablets.
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/pmi8950.dtsi | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

-- 
With best wishes
Dmitry

Re: [PATCH 2/2] arm64: dts: qcom: sdm450-lenovo-tbx605f: add DSI panel nodes

[Dmitry Baryshkov]

On Fri, Nov 15, 2024 at 11:20:54AM +0100, Neil Armstrong wrote:
> Add the necessary nodes to enable the DSI panel on the
> Lenovo Smart Tab M10 tablet.
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/sdm450-lenovo-tbx605f.dts | 97 ++++++++++++++++++++++
>  1 file changed, 97 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

-- 
With best wishes
Dmitry

Re: [PATCH 0/2] arm64: dts: qcom: sdm450-lenovo-tbx605f: add panel nodes

[Rob Herring (Arm)]

On Fri, 15 Nov 2024 11:20:52 +0100, Neil Armstrong wrote:
> Add the necessary nodes to enable the DSI Panel on the Lenovo
> Lenovo Smart Tab M10.
> 
> The panel is already upstream with:
> https://lore.kernel.org/all/20240828-topic-sdm450-upstream-tbx605f-panel-v3-0-b792f93e1d6b@linaro.org/
> 
> And the LAB-IBB bindings changes was sent at:
> https://lore.kernel.org/all/20241115-topic-sdm450-upstream-lab-ibb-bindings-v1-1-1f4bff4583b0@linaro.org/
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> Neil Armstrong (2):
>       arm64: dts: qcom: pmi8950: add LAB-IBB nodes
>       arm64: dts: qcom: sdm450-lenovo-tbx605f: add DSI panel nodes
> 
>  arch/arm64/boot/dts/qcom/pmi8950.dtsi              | 17 ++++
>  arch/arm64/boot/dts/qcom/sdm450-lenovo-tbx605f.dts | 97 ++++++++++++++++++++++
>  2 files changed, 114 insertions(+)
> ---
> base-commit: 2d5404caa8c7bb5c4e0435f94b28834ae5456623
> change-id: 20241115-topic-sdm450-upstream-lab-ibb-5acee981556c
> 
> Best regards,
> --
> Neil Armstrong <neil.armstrong@linaro.org>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y qcom/sdm450-lenovo-tbx605f.dtb' for 20241115-topic-sdm450-upstream-lab-ibb-v1-0-8a8e74befbfe@linaro.org:

arch/arm64/boot/dts/qcom/sdm450-lenovo-tbx605f.dtb: gpu@1c00000: clock-names:5: 'alwayson' is not one of ['core', 'iface', 'mem', 'mem_iface', 'alt_mem_iface', 'gfx3d', 'rbbmtimer', 'rbcpr']
	from schema $id: http://devicetree.org/schemas/display/msm/gpu.yaml#
arch/arm64/boot/dts/qcom/sdm450-lenovo-tbx605f.dtb: pmic@3: labibb:compatible:0: 'qcom,pmi8998-lab-ibb' was expected
	from schema $id: http://devicetree.org/schemas/mfd/qcom,spmi-pmic.yaml#
arch/arm64/boot/dts/qcom/sdm450-lenovo-tbx605f.dtb: pmic@3: labibb:compatible: ['qcom,pmi8950-lab-ibb', 'qcom,pmi8998-lab-ibb'] is too long
	from schema $id: http://devicetree.org/schemas/mfd/qcom,spmi-pmic.yaml#
arch/arm64/boot/dts/qcom/sdm450-lenovo-tbx605f.dtb: labibb: compatible:0: 'qcom,pmi8998-lab-ibb' was expected
	from schema $id: http://devicetree.org/schemas/regulator/qcom-labibb-regulator.yaml#
arch/arm64/boot/dts/qcom/sdm450-lenovo-tbx605f.dtb: labibb: compatible: ['qcom,pmi8950-lab-ibb', 'qcom,pmi8998-lab-ibb'] is too long
	from schema $id: http://devicetree.org/schemas/regulator/qcom-labibb-regulator.yaml#
arch/arm64/boot/dts/qcom/sdm450-lenovo-tbx605f.dtb: /soc@0/spmi@200f000/pmic@3/labibb: failed to match any schema with compatible: ['qcom,pmi8950-lab-ibb', 'qcom,pmi8998-lab-ibb']

Re: [PATCH 0/2] arm64: dts: qcom: sdm450-lenovo-tbx605f: add panel nodes

[Bjorn Andersson]

On Fri, 15 Nov 2024 11:20:52 +0100, Neil Armstrong wrote:
> Add the necessary nodes to enable the DSI Panel on the Lenovo
> Lenovo Smart Tab M10.
> 
> The panel is already upstream with:
> https://lore.kernel.org/all/20240828-topic-sdm450-upstream-tbx605f-panel-v3-0-b792f93e1d6b@linaro.org/
> 
> And the LAB-IBB bindings changes was sent at:
> https://lore.kernel.org/all/20241115-topic-sdm450-upstream-lab-ibb-bindings-v1-1-1f4bff4583b0@linaro.org/
> 
> [...]

Applied, thanks!

[1/2] arm64: dts: qcom: pmi8950: add LAB-IBB nodes
      commit: f8ed8fd08426df23037fd73e9f1c3cfdef827769
[2/2] arm64: dts: qcom: sdm450-lenovo-tbx605f: add DSI panel nodes
      commit: cddaf231361d83a0605d51a8b70855eb57a58131

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>