* [PATCH net v3] netdev-genl: Hold rcu_read_lock in napi_get
@ 2024-11-14 17:51 Joe Damato
2024-11-15 23:10 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Joe Damato @ 2024-11-14 17:51 UTC (permalink / raw)
To: netdev
Cc: pabeni, edumazet, amritha.nambiar, sridhar.samudrala, kuba,
mkarsten, Joe Damato, stable, David S. Miller, Simon Horman,
Mina Almasry, Xuan Zhuo, Stanislav Fomichev, open list
Hold rcu_read_lock in netdev_nl_napi_get_doit, which calls napi_by_id
and is required to be called under rcu_read_lock.
Cc: stable@vger.kernel.org
Fixes: 27f91aaf49b3 ("netdev-genl: Add netlink framework functions for napi")
Signed-off-by: Joe Damato <jdamato@fastly.com>
---
v3:
- Separate the patches that were a series in v2 (and earlier) as
they target different trees.
v2:
- Simplified by removing the helper and calling rcu_read_lock /
unlock directly instead.
net/core/netdev-genl.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/core/netdev-genl.c b/net/core/netdev-genl.c
index 1cb954f2d39e..d2baa1af9df0 100644
--- a/net/core/netdev-genl.c
+++ b/net/core/netdev-genl.c
@@ -215,6 +215,7 @@ int netdev_nl_napi_get_doit(struct sk_buff *skb, struct genl_info *info)
return -ENOMEM;
rtnl_lock();
+ rcu_read_lock();
napi = napi_by_id(napi_id);
if (napi) {
@@ -224,6 +225,7 @@ int netdev_nl_napi_get_doit(struct sk_buff *skb, struct genl_info *info)
err = -ENOENT;
}
+ rcu_read_unlock();
rtnl_unlock();
if (err)
base-commit: 5b366eae71937ae7412365340b431064625f9617
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH net v3] netdev-genl: Hold rcu_read_lock in napi_get
2024-11-14 17:51 [PATCH net v3] netdev-genl: Hold rcu_read_lock in napi_get Joe Damato
@ 2024-11-15 23:10 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-11-15 23:10 UTC (permalink / raw)
To: Joe Damato
Cc: netdev, pabeni, edumazet, amritha.nambiar, sridhar.samudrala,
kuba, mkarsten, stable, davem, horms, almasrymina, xuanzhuo, sdf,
linux-kernel
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 14 Nov 2024 17:51:56 +0000 you wrote:
> Hold rcu_read_lock in netdev_nl_napi_get_doit, which calls napi_by_id
> and is required to be called under rcu_read_lock.
>
> Cc: stable@vger.kernel.org
> Fixes: 27f91aaf49b3 ("netdev-genl: Add netlink framework functions for napi")
> Signed-off-by: Joe Damato <jdamato@fastly.com>
>
> [...]
Here is the summary with links:
- [net,v3] netdev-genl: Hold rcu_read_lock in napi_get
https://git.kernel.org/netdev/net/c/c53bf100f686
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-11-15 23:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-14 17:51 [PATCH net v3] netdev-genl: Hold rcu_read_lock in napi_get Joe Damato
2024-11-15 23:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®