From: Kees Cook <kees@kernel.org>
To: ebiederm@xmission.com, viro@zeniv.linux.org.uk,
brauner@kernel.org, jack@suse.cz, linux-kernel@vger.kernel.org,
Nir Lichtman <nir@lichtman.org>
Cc: Kees Cook <kees@kernel.org>
Subject: Re: [PATCH] exec: remove legacy custom binfmt modules autoloading
Date: Sat, 16 Nov 2024 20:56:02 -0800 [thread overview]
Message-ID: <173181935997.601589.16672643288623371390.b4-ty@kernel.org> (raw)
In-Reply-To: <20241116231323.GA225987@lichtman.org>
On Sat, 16 Nov 2024 23:13:23 +0000, Nir Lichtman wrote:
> Problem: The search binary handler logic contains legacy code
> to handle automatically loading kernel modules of unsupported
> binary formats.
> This logic is a leftover from a.out-to-ELF transition.
> After removal of a.out support, this code has no use anymore.
>
> Solution: Clean up this code from the search binary handler,
> also remove the line initialising retval to -ENOENT and instead
> just return -ENOEXEC if the flow has reached the end of the func.
>
> [...]
And it removes a goto. :)
Applied to for-next/execve, thanks!
[1/1] exec: remove legacy custom binfmt modules autoloading
https://git.kernel.org/kees/c/8c9870077aac
Take care,
--
Kees Cook
prev parent reply other threads:[~2024-11-17 4:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-16 23:13 Nir Lichtman
2024-11-17 4:56 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173181935997.601589.16672643288623371390.b4-ty@kernel.org \
--to=kees@kernel.org \
--cc=brauner@kernel.org \
--cc=ebiederm@xmission.com \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=nir@lichtman.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®