[PATCH net v1 1/1] net: usb: lan78xx: Fix refcounting and autosuspend on invalid WoL configuration

[PATCH net v1 1/1] net: usb: lan78xx: Fix refcounting and autosuspend on invalid WoL configuration

[Oleksij Rempel]

Validate Wake-on-LAN (WoL) options in `lan78xx_set_wol` before calling
`usb_autopm_get_interface`. This prevents USB autopm refcounting issues
and ensures the adapter can properly enter autosuspend when invalid WoL
options are provided.

Fixes: eb9ad088f966 ("lan78xx: Check for supported Wake-on-LAN modes")
Cc: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 drivers/net/usb/lan78xx.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
index 9f191b6ce821..531b1b6a37d1 100644
--- a/drivers/net/usb/lan78xx.c
+++ b/drivers/net/usb/lan78xx.c
@@ -1652,13 +1652,13 @@ static int lan78xx_set_wol(struct net_device *netdev,
 	struct lan78xx_priv *pdata = (struct lan78xx_priv *)(dev->data[0]);
 	int ret;
 
+	if (wol->wolopts & ~WAKE_ALL)
+		return -EINVAL;
+
 	ret = usb_autopm_get_interface(dev->intf);
 	if (ret < 0)
 		return ret;
 
-	if (wol->wolopts & ~WAKE_ALL)
-		return -EINVAL;
-
 	pdata->wol = wol->wolopts;
 
 	device_set_wakeup_enable(&dev->udev->dev, (bool)wol->wolopts);
-- 
2.39.5

Re: [PATCH net v1 1/1] net: usb: lan78xx: Fix refcounting and autosuspend on invalid WoL configuration

[Florian Fainelli]

On 11/18/24 06:03, Oleksij Rempel wrote:
> Validate Wake-on-LAN (WoL) options in `lan78xx_set_wol` before calling
> `usb_autopm_get_interface`. This prevents USB autopm refcounting issues
> and ensures the adapter can properly enter autosuspend when invalid WoL
> options are provided.
> 
> Fixes: eb9ad088f966 ("lan78xx: Check for supported Wake-on-LAN modes")
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>

Thank you!
-- 
Florian

Re: [PATCH net v1 1/1] net: usb: lan78xx: Fix refcounting and autosuspend on invalid WoL configuration

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 18 Nov 2024 15:03:51 +0100 you wrote:
> Validate Wake-on-LAN (WoL) options in `lan78xx_set_wol` before calling
> `usb_autopm_get_interface`. This prevents USB autopm refcounting issues
> and ensures the adapter can properly enter autosuspend when invalid WoL
> options are provided.
> 
> Fixes: eb9ad088f966 ("lan78xx: Check for supported Wake-on-LAN modes")
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> 
> [...]

Here is the summary with links:
  - [net,v1,1/1] net: usb: lan78xx: Fix refcounting and autosuspend on invalid WoL configuration
    https://git.kernel.org/netdev/net/c/e863ff806f72

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html