mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] spi: apple: Set use_gpio_descriptors to true
@ 2024-11-27 22:18 Sasha Finkelstein via B4 Relay
  2024-11-28  8:31 ` Janne Grunau
  2024-12-02 13:30 ` Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Sasha Finkelstein via B4 Relay @ 2024-11-27 22:18 UTC (permalink / raw)
  To: Mark Brown, Hector Martin, Sven Peter, Alyssa Rosenzweig
  Cc: linux-spi, asahi, linux-arm-kernel, linux-kernel, Sasha Finkelstein

From: Sasha Finkelstein <fnkl.kernel@gmail.com>

There is at least one peripheral that is attached to this
controller and can not use native CS. Make it possible to use
a GPIO instead.

Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com>
---
 drivers/spi/spi-apple.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/spi-apple.c b/drivers/spi/spi-apple.c
index d4b126c8701a67083e7247d1c82fb56f1725d9cb..6273352a2b2861c9da0976a46ec2adbc4c71d3d2 100644
--- a/drivers/spi/spi-apple.c
+++ b/drivers/spi/spi-apple.c
@@ -493,6 +493,7 @@ static int apple_spi_probe(struct platform_device *pdev)
 	ctlr->prepare_message = apple_spi_prepare_message;
 	ctlr->set_cs = apple_spi_set_cs;
 	ctlr->transfer_one = apple_spi_transfer_one;
+	ctlr->use_gpio_descriptors = true;
 	ctlr->auto_runtime_pm = true;
 
 	pm_runtime_set_active(&pdev->dev);

---
base-commit: 9f16d5e6f220661f73b36a4be1b21575651d8833
change-id: 20241127-gpio-descs-58fcf9a04c4c



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] spi: apple: Set use_gpio_descriptors to true
  2024-11-27 22:18 [PATCH] spi: apple: Set use_gpio_descriptors to true Sasha Finkelstein via B4 Relay
@ 2024-11-28  8:31 ` Janne Grunau
  2024-12-02 13:30 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Janne Grunau @ 2024-11-28  8:31 UTC (permalink / raw)
  To: fnkl.kernel
  Cc: Mark Brown, Hector Martin, Sven Peter, Alyssa Rosenzweig,
	linux-spi, asahi, linux-arm-kernel, linux-kernel

On Wed, Nov 27, 2024 at 11:18:29PM +0100, Sasha Finkelstein via B4 Relay wrote:
> From: Sasha Finkelstein <fnkl.kernel@gmail.com>
> 
> There is at least one peripheral that is attached to this
> controller and can not use native CS. Make it possible to use
> a GPIO instead.
> 
> Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com>
> ---
>  drivers/spi/spi-apple.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/spi/spi-apple.c b/drivers/spi/spi-apple.c
> index d4b126c8701a67083e7247d1c82fb56f1725d9cb..6273352a2b2861c9da0976a46ec2adbc4c71d3d2 100644
> --- a/drivers/spi/spi-apple.c
> +++ b/drivers/spi/spi-apple.c
> @@ -493,6 +493,7 @@ static int apple_spi_probe(struct platform_device *pdev)
>  	ctlr->prepare_message = apple_spi_prepare_message;
>  	ctlr->set_cs = apple_spi_set_cs;
>  	ctlr->transfer_one = apple_spi_transfer_one;
> +	ctlr->use_gpio_descriptors = true;
>  	ctlr->auto_runtime_pm = true;
>  
>  	pm_runtime_set_active(&pdev->dev);
> 

Reviewed-by: Janne Grunau <j@jannau.net>

Janne

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] spi: apple: Set use_gpio_descriptors to true
  2024-11-27 22:18 [PATCH] spi: apple: Set use_gpio_descriptors to true Sasha Finkelstein via B4 Relay
  2024-11-28  8:31 ` Janne Grunau
@ 2024-12-02 13:30 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2024-12-02 13:30 UTC (permalink / raw)
  To: Hector Martin, Sven Peter, Alyssa Rosenzweig, Sasha Finkelstein
  Cc: linux-spi, asahi, linux-arm-kernel, linux-kernel

On Wed, 27 Nov 2024 23:18:29 +0100, Sasha Finkelstein wrote:
> There is at least one peripheral that is attached to this
> controller and can not use native CS. Make it possible to use
> a GPIO instead.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: apple: Set use_gpio_descriptors to true
      commit: 1b299bd0c22887543b276bcc5b4ed26f5bd83ae4

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-12-02 13:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-27 22:18 [PATCH] spi: apple: Set use_gpio_descriptors to true Sasha Finkelstein via B4 Relay
2024-11-28  8:31 ` Janne Grunau
2024-12-02 13:30 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®